Re: [VOTE] April 2023 PR of the Month

2023-04-25 Thread Pankaj Koti
+1 for #30373 by @bbovenzi: “Improve task & run actions UX in grid view” < https://github.com/apache/airflow/pull/30373> Regards, Pankaj Koti *Senior Software Engineer, *OSS Engineering Team. Location: Pune, India Timezone: Indian Standard Time (IST) Email: pankaj.k...@astronomer.io Mobile:

Re: [VOTE] April 2023 PR of the Month

2023-04-25 Thread Abhishek Bhakat
+1 for #30375 is must to have. Thanks, Abhishek Bhakat Airflow Engineer On 26-Apr-2023 at 01:31:22, Jarek Potiuk wrote: > Indeed. Extremely tough choice this time, but I'd go for 30175 for me -> > Kafka provider has been long in the making and Dylan had done a lot of > effort to make it work we

Re: [VOTE] Airflow Providers prepared on April 25, 2023

2023-04-25 Thread Elad Kalif
This vote is cancelled. RC3 will follow On Wed, Apr 26, 2023 at 4:23 AM Mehta, Shubham wrote: > Thank Jarek, good catch! You're right, it's better to keep aiobotocore as > additional dependency for now. > If you attempt to install apache-airflow-providers-amazon[aiobotocore] > using constraints

Re: [VOTE] April 2023 PR of the Month

2023-04-25 Thread Jarek Potiuk
Indeed. Extremely tough choice this time, but I'd go for 30175 for me -> Kafka provider has been long in the making and Dylan had done a lot of effort to make it work well and respond to plenty of comments, including adding new integration in breeze which means that the new provider is automaticall

Re: [VOTE] Airflow Providers prepared on April 25, 2023

2023-04-25 Thread Mehta, Shubham
Thank Jarek, good catch! You're right, it's better to keep aiobotocore as additional dependency for now. If you attempt to install apache-airflow-providers-amazon[aiobotocore] using constraints for older Airflow versions, like Pankaj, you will still encounter conflicts. However, the impact woul

Re: [VOTE] April 2023 PR of the Month

2023-04-25 Thread Mehta, Shubham
That's an amazing set of PRs. I vote for #29940. Kudos to Maciej for the effort he put into it and laying out the foundation for OL work. Shubham On 2023-04-25, 6:08 PM, "Michael Robinson" mailto:michael.robin...@astronomer.io.inva>LID> wrote: CAUTION: This email originated from outside of t

Re: [VOTE] April 2023 PR of the Month

2023-04-25 Thread Collin McNulty
So many great ones this month. My vote is for 30375 on account of having been personally affected by the behavior. On Tue, Apr 25, 2023 at 8:08 PM Michael Robinson wrote: > Hello all, > > It’s once again time to vote for the PR of the Month. > > With the help of the script in dev/stats, I’ve ide

[VOTE] April 2023 PR of the Month

2023-04-25 Thread Michael Robinson
Hello all, It’s once again time to vote for the PR of the Month. With the help of the script in dev/stats, I’ve identified the following candidates: #30255 by @potiuk: “Decouple 'job under' from BaseJob ORM model” #29940 by @mobuchowski: “Add base

Re: [VOTE] Airflow Providers prepared on April 25, 2023

2023-04-25 Thread Jarek Potiuk
PR here: https://github.com/apache/airflow/pull/30874 On Wed, Apr 26, 2023 at 2:08 AM Jarek Potiuk wrote: > -1: Pankaj is right. We need to fix the dependencies. The aiobotocore was > mistakenly added as the "required" dependency 2 days ago in: > https://github.com/apache/airflow/pull/30032 > >

Re: [VOTE] Airflow Providers prepared on April 25, 2023

2023-04-25 Thread Jarek Potiuk
-1: Pankaj is right. We need to fix the dependencies. The aiobotocore was mistakenly added as the "required" dependency 2 days ago in: https://github.com/apache/airflow/pull/30032 However for the Amazon provider we have it as an optional one. Currently in provider,yaml we have both: dependencie

Re: [VOTE] Airflow Providers prepared on April 25, 2023

2023-04-25 Thread Mehta, Shubham
Hey Pankaj, I have a few clarifying questions: 1. Can you specify the Airflow version used during testing? Based on the botocore version constraint, it appears to be v2.5.3. 2. Did you use a modified constraint file to install the Amazon provider v8.0.0rc2 with Airflow v2.5.3? If so, what were t

Re: [VOTE] Release Airflow 2.6.0 from 2.6.0rc1

2023-04-25 Thread Ephraim Anierobi
A bug was found in rc1 that'll necessitate an rc2. I'm canceling this vote and will create 2.6.0rc2 soon. On Tue, 25 Apr 2023 at 15:48, Dennis Akpenyi wrote: > +1 non-binding > > On Tue, Apr 25, 2023 at 4:46 PM Brent Bovenzi > > wrote: > > > +1 binding > > > > - Brent > > > > On Tue, Apr 25, 20

Re: [VOTE] Airflow Providers prepared on April 25, 2023

2023-04-25 Thread Pankaj Singh
-1 (non-binding) We won't be able to use the amazon provider for airflow version less than equal to 2.5.3 because conflict cause by aibotocore ERROR: Cannot install aiobotocore[boto3]==2.2.0, aiobotocore[boto3]==2.3.0, aiobotocore[boto3]==2.3.1, aiobotocore[boto3]==2.3.2, aiobotocore[boto3]==2.3

Re: AIP-56 Extensible user management

2023-04-25 Thread Bolke de Bruin
I'm not sure if I read the AIP correctly. I think I concur with Jarek here. AuthN and AuthZ should be completely removed from Airflow. Access management should be outsourced to something like Open Policy Agent. In other words there should be no user management at all within Airflow. This removes t

Re: [VOTE] Airflow Providers prepared on April 25, 2023

2023-04-25 Thread Jed Cunningham
+1 (binding) Checked signatures, checksums, licences.

Re: [VOTE] Release Airflow 2.6.0 from 2.6.0rc1

2023-04-25 Thread Dennis Akpenyi
+1 non-binding On Tue, Apr 25, 2023 at 4:46 PM Brent Bovenzi wrote: > +1 binding > > - Brent > > On Tue, Apr 25, 2023 at 10:09 AM Xiaodong Deng wrote: > > > +1 (binding)! > > > > Thanks! > > > > Regards, > > XD > > > > On Tue, Apr 25, 2023 at 01:43 Bolke de Bruin wrote: > > > > > +1 binding. >

Re: [VOTE] Release Airflow 2.6.0 from 2.6.0rc1

2023-04-25 Thread Brent Bovenzi
+1 binding - Brent On Tue, Apr 25, 2023 at 10:09 AM Xiaodong Deng wrote: > +1 (binding)! > > Thanks! > > Regards, > XD > > On Tue, Apr 25, 2023 at 01:43 Bolke de Bruin wrote: > > > +1 binding. > > > > Ty. > > Bolke > > > > Op ma 24 apr 2023 om 16:28 schreef Pierre Jeambrun < > pierrejb...@gmai

Re: [VOTE] Release Airflow 2.6.0 from 2.6.0rc1

2023-04-25 Thread Xiaodong Deng
+1 (binding)! Thanks! Regards, XD On Tue, Apr 25, 2023 at 01:43 Bolke de Bruin wrote: > +1 binding. > > Ty. > Bolke > > Op ma 24 apr 2023 om 16:28 schreef Pierre Jeambrun >: > > > +1 (binding), tested my changes, verified licences, checksum and > > signatures, all looks good. > > > > Le lun.

Re: [VOTE] Release Airflow 2.6.0 from 2.6.0rc1

2023-04-25 Thread Bolke de Bruin
+1 binding. Ty. Bolke Op ma 24 apr 2023 om 16:28 schreef Pierre Jeambrun : > +1 (binding), tested my changes, verified licences, checksum and > signatures, all looks good. > > Le lun. 24 avr. 2023 à 16:08, Pankaj Koti .invalid> > a écrit : > > > +1 non-binding. We tested our asynchronous provid