[Desktop-packages] [Bug 908508] Re: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre

2012-05-04 Thread Bug Watch Updater
** Changed in: firefox Status: In Progress => Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/ya

[Desktop-packages] [Bug 908508]

2012-05-04 Thread Landry-openbsd
Finally \o/ -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre Status in The Mozilla Firefox Browser: Fix

[Desktop-packages] [Bug 908508]

2012-05-04 Thread SharkCZ
Created attachment 621000 the patch backported to xulrunner 12, no warranty it could be useful for someone, I'm using it on Fedora/s390 to build the xulrunner version 12 package -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird

[Desktop-packages] [Bug 908508]

2012-05-04 Thread Bmo-edmorley
\o/ https://hg.mozilla.org/mozilla-central/rev/f5a3a7b9c6b0 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pc

[Desktop-packages] [Bug 908508]

2012-05-03 Thread Spectre
I'm fine with comment 119, that shouldn't break me. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre Statu

[Desktop-packages] [Bug 908508]

2012-05-03 Thread Mh+mozilla
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5a3a7b9c6b0 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/

[Desktop-packages] [Bug 908508]

2012-05-03 Thread Landry-openbsd
Created attachment 620274 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported That also works. New patch which only removes the #else #error from ExecutableAllocator.h, tested working here on ppc. -- You received this bug notification because you are a member of De

[Desktop-packages] [Bug 908508]

2012-05-02 Thread Mh+mozilla
What might work, is to remove the error and put nothing to replace it. Adding a JIT for a new platform will make the function required, and compilation will fail because it is completely missing. -- You received this bug notification because you are a member of Desktop Packages, which is subscrib

[Desktop-packages] [Bug 908508]

2012-05-02 Thread Mh+mozilla
(In reply to Landry Breuil from comment #117) > So that'd mean replacing : > > #error "The cacheFlush support is missing on this platform." > > by > > static void cacheFlush(void*, size_t) > { > #warning "Using dummy generic & empty cacheFlush for this platform." > } > > Do you think that'll wo

[Desktop-packages] [Bug 908508]

2012-05-02 Thread Landry-openbsd
So that'd mean replacing : #error "The cacheFlush support is missing on this platform." by static void cacheFlush(void*, size_t) { #warning "Using dummy generic & empty cacheFlush for this platform." } Do you think that'll work out ? Since from my understanding of the previous comments cacheFlu

[Desktop-packages] [Bug 908508]

2012-05-02 Thread Mh+mozilla
(In reply to Landry Breuil from comment #115) > So let's try to get this reviewed and hope this time it sticks. Only change > from att 619876 is indentation fixed in Makefile.in (use tabs) and > (defined(WTF_CPU_PPC) && !defined(JS_CPU_PPC_OSX)) for using the dummy > cacheFlush. You should use som

[Desktop-packages] [Bug 908508]

2012-05-02 Thread Landry-openbsd
Created attachment 620233 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported So with this smaller patch (and also patches from 750447, 750620 & 750853..) i have a working firefox (Mozilla/5.0 (X11; OpenBSD macppc; rv:15.0) Gecko/15.0 Firefox/15.0a1), browsed hg.m.o/

[Desktop-packages] [Bug 908508]

2012-05-02 Thread Landry-openbsd
(In reply to Cameron Kaiser from comment #113) > Can you change the ifsef WTF_CPU_PPC to defined(WTF_CPU_PPC) && > !defined(JS_CPU_PPC_OSX) around cacheFlush? Sure, no problem. I've sent the current patch to try here : https://tbpl.mozilla.org/?tree=Try&rev=ec2fff3441e3 I'm not an expert for dec

[Desktop-packages] [Bug 908508]

2012-05-02 Thread Spectre
Can you change the ifsef WTF_CPU_PPC to defined(WTF_CPU_PPC) && !defined(JS_CPU_PPC_OSX) around cacheFlush? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Th

[Desktop-packages] [Bug 908508]

2012-05-01 Thread Landry-openbsd
Created attachment 619876 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported Fwiw here's the (simpler) patch i'm working on (no, i didn't gave up..) : - it doesnt touch the ENABLE_ASSEMBLER hell -> shouldnt affect tier1 archs - it uses the dummy empty cacheFlush imp

[Desktop-packages] [Bug 908508]

2012-05-01 Thread Landry-openbsd
(In reply to Cameron Kaiser from comment #110) > Landry, how close are you to a patch for this? I'd like to get bug 731110 > revised and landed with the next train so that downstreamers can get it and > I can stop schlepping it around in our own changesets. It may actually > simplify your work. If

[Desktop-packages] [Bug 908508] Re: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre

2012-04-24 Thread naticia
** Branch unlinked: lp:ubuntu/firefox -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre Status in The Mozil

[Desktop-packages] [Bug 908508]

2012-04-23 Thread Spectre
Landry, how close are you to a patch for this? I'd like to get bug 731110 revised and landed with the next train so that downstreamers can get it and I can stop schlepping it around in our own changesets. It may actually simplify your work. If you have a new patch imminent, I'll wait, but if not I'

[Desktop-packages] [Bug 908508]

2012-04-21 Thread Anarchy
(In reply to ifinisheri from comment #108) > I encountered the same question while building firefox11.0 and patches here > seem like to be the right answer. > But when I checked the latest patch,which is modified on 2012-03-06 08:11 > PST, by Landry Breuil,I found this patch can hardly match souce

[Desktop-packages] [Bug 908508]

2012-04-20 Thread Ifinisheri
I encountered the same question while building firefox11.0 and patches here seem like to be the right answer. But when I checked the latest patch,which is modified on 2012-03-06 08:11 PST, by Landry Breuil,I found this patch can hardly match souce code in js/src of FF11.0. I wonder that if the p

[Desktop-packages] [Bug 908508]

2012-04-19 Thread Mh+mozilla
A safe way to implement cacheFlush that would be to have a dummy implementation that does nothing (cacheFlush is completely unimportant when there is no JIT), with the following preprocessor goop (or something similar): #ifndef ENABLE_ASSEMBLER #error cacheFlush unimplemented for this platform #e

[Desktop-packages] [Bug 908508]

2012-04-19 Thread Spectre
The cacheFlush implementation I have for OS X/ppc is OS X specific and calls sys_icache_invalidate() which is provided by the kernel. You could fake it up with isync/icbi on other architectures (a blank one wouldn't be correct, PPCs are very cache dependent). -- You received this bug notification

[Desktop-packages] [Bug 908508]

2012-04-19 Thread Spectre
s/architectures/operating systems/ -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre Status in The Mozilla

[Desktop-packages] [Bug 908508]

2012-04-19 Thread Dmandelin
(In reply to Landry Breuil from comment #103) > (In reply to David Mandelin from comment #102) > > This is getting really confusing--I feel like I need to back up a few steps. > > Yes, i'm also confused. > > > 1. First off, do you still need to leave out the executableAllocators in > > jscntxt.h?

[Desktop-packages] [Bug 908508]

2012-04-19 Thread Landry-openbsd
(In reply to David Mandelin from comment #102) > This is getting really confusing--I feel like I need to back up a few steps. Yes, i'm also confused. > 1. First off, do you still need to leave out the executableAllocators in > jscntxt.h? If you have the JITs now, then it seems like you don't even

[Desktop-packages] [Bug 908508]

2012-04-18 Thread Dmandelin
This is getting really confusing--I feel like I need to back up a few steps. 1. First off, do you still need to leave out the executableAllocators in jscntxt.h? If you have the JITs now, then it seems like you don't even need to patch jscntxt.h. I'm going to assume you do, and continue, but if we

[Desktop-packages] [Bug 908508]

2012-04-17 Thread Landry-openbsd
I've tried a slightly different approach in https://tbpl.mozilla.org/?tree=Try&rev=49b9616807cc but looking at the results it wasnt working 100%.. The idea (https://hg.mozilla.org/try/rev/96ce117be086) was to set ENABLE_ASSEMBLER=1 through configure.in + config/autoconf.mk so that it got applied a

[Desktop-packages] [Bug 908508]

2012-04-14 Thread Landry-openbsd
(In reply to David Mandelin from comment #99) > I would suggest making the minimal change that actually works and doesn't > make things more confusing. Exactly what that would be, I don't know without > trying things out. My *guess* would be that adding JS_ENABLE_JIT to > Makefile.in and using it o

[Desktop-packages] [Bug 908508]

2012-04-13 Thread Dmandelin
I would suggest making the minimal change that actually works and doesn't make things more confusing. Exactly what that would be, I don't know without trying things out. My *guess* would be that adding JS_ENABLE_JIT to Makefile.in and using it only in the places you need here would be it. I'm not s

[Desktop-packages] [Bug 908508]

2012-04-13 Thread Landry-openbsd
And looking at Makefile.in, the list of archs is really the same as ENABLE_METHODJIT, so i'd be tempted to replace ifeq (,$(filter arm% sparc %86 x86_64 mips%,$(TARGET_CPU))) by ifdef ENABLE_METHODJIT, or even better merge the two blocks with the ENABLE_METHODJIT above. Thoughs ? -- You received

[Desktop-packages] [Bug 908508]

2012-04-13 Thread Landry-openbsd
(In reply to David Mandelin from comment #95) > Landry, it's definitely a maze. Sorting it out proper would be a lot of work > so I definitely don't expect you to fix everything as part of this patch. It > seems important to make sure ENABLE_ASSEMBLER is consistent, though, so > combined with Mike

[Desktop-packages] [Bug 908508]

2012-04-11 Thread SharkCZ
Can we get an update what's the status of this bug, please? Comment #92 looks optimistic. I'm asking whether we should attempt to build Xulrunner on Fedora s390 and ppc. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubunt

[Desktop-packages] [Bug 908508]

2012-03-15 Thread Mh+mozilla
(In reply to David Mandelin from comment #91) > JSC sets those flags in what we imported as assembler/wtf/Platform.h, which > seems reasonable. In fact, I see they set ENABLE_ASSEMBLER in there > depending on various conditions, which is maybe why the patch works on most > platforms already. Platf

[Desktop-packages] [Bug 908508]

2012-03-15 Thread Dmandelin
Mike, what exactly do you mean by Platform.h being or not being a public header? Do you mean being installed to an include/ dir, or do you mean getting included into jsapi.h? AFAICT it is neither at the moment, just trying to see what you're getting at. Landry, it's definitely a maze. Sorting it o

[Desktop-packages] [Bug 908508]

2012-03-15 Thread Landry-openbsd
(In reply to David Mandelin from comment #91) > (In reply to Mike Hommey [:glandium] from comment #90) > > Yes. That these things are in Makefile.in is a mistake anyways. > > JSC sets those flags in what we imported as assembler/wtf/Platform.h, which > seems reasonable. In fact, I see they set ENA

[Desktop-packages] [Bug 908508]

2012-03-15 Thread Landry-openbsd
Sidenote : https://tbpl.mozilla.org/?tree=Try&rev=88122a478851 with inclusion of jit/ExecutableAllocator.h in jscntxt.h is all green, so we're definitely on the right track. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in U

[Desktop-packages] [Bug 908508]

2012-03-15 Thread Dmandelin
(In reply to Landry Breuil from comment #89) > I've looked at try logs, and yes ENABLE_ASSEMBLER=1 is not set on the > commandline when building under shell/ with the patch. Ah, OK. I looked at it in my Linux VM, and I really thought I saw ENABLE_ASSEMBLER in the command line for js.o, but given t

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Mh+mozilla
(In reply to Landry Breuil from comment #88) > Righto.. but ENABLE_YARR_JIT is not known when you're creating js-config.h, > since it's in Makefile.in. and ENABLE_YARR_JIT is needed to know if we need > to define ENABLE_ASSEMBLER. So ENABLE_YARR_JIT definition would have to go > to configure too ?

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Spectre
I'm no expert in JS, but I think the problem you're having is that one of these ifdefs is causing an object to be marked wrong for garbage collection and it's violating an invariant. The GC depends on the property that there can be no black to grey edges (i.e., reachable to unknown), or the cycle c

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Mh+mozilla
(In reply to Landry Breuil from comment #85) > (In reply to David Mandelin from comment #82) > > Landry, following up on a hint from billm, I got your patch to work on Linux > > with this addition: > > > > diff -r e7bbcbb6c24a js/src/jscntxt.h > > --- a/js/src/jscntxt.h Tue Mar 13 17:42:33 20

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Spectre
-m = Methodjit -n = type infereNce -a = Always run in jit -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Landry-openbsd
I've looked at try logs, and yes ENABLE_ASSEMBLER=1 is not set on the commandline when building under shell/ with the patch. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Ti

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Landry-openbsd
(In reply to David Mandelin from comment #82) > Landry, following up on a hint from billm, I got your patch to work on Linux > with this addition: > > diff -r e7bbcbb6c24a js/src/jscntxt.h > --- a/js/src/jscntxt.hTue Mar 13 17:42:33 2012 -0700 > +++ b/js/src/jscntxt.hTue Mar 13 18:

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Landry-openbsd
Trying to find a common denominator in the failing 9 tests : some tests fail for all 9 combinaisons of jit_test.py arguments : tests/basic/bug708805.js, bug713226.js, bug716013.js, bug728609.js, bug729364.js some fail for only 7 combinaisons out of 9, and goes into 2 classes : the ones that fail

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Mh+mozilla
The best place is probably js-config.h.in, so that external apps building against the headers don't end up with the same problem. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/90850

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Spectre
He'll still need it for sparc64, though (and the PPC assembler is only for OS X ABI, and *BSD/ppc is SysV ABI). -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefo

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Dmandelin
Landry, following up on a hint from billm, I got your patch to work on Linux with this addition: diff -r e7bbcbb6c24a js/src/jscntxt.h --- a/js/src/jscntxt.h Tue Mar 13 17:42:33 2012 -0700 +++ b/js/src/jscntxt.h Tue Mar 13 18:32:46 2012 -0700 @@ -64,6 +64,7 @@ #include "js/HashTable.h" #includ

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Spectre
(er, unless someone(tm) adds the necessary ABI sauce to it, which is just a matter of doing it(tm)) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbir

[Desktop-packages] [Bug 908508]

2012-03-14 Thread Landry-openbsd
(In reply to Mike Hommey [:glandium] from comment #86) > (In reply to Landry Breuil from comment #85) > > (In reply to David Mandelin from comment #82) > > > Landry, following up on a hint from billm, I got your patch to work on > > > Linux > > > with this addition: > > > > > > diff -r e7bbcbb6c2

[Desktop-packages] [Bug 908508]

2012-03-13 Thread Landry-openbsd
Try build still fails the same on debug builds only. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre Stat

[Desktop-packages] [Bug 908508]

2012-03-13 Thread Landry-openbsd
Re-read the diff, and a bit out of ideas i've pushed a similar changeset with s/#if ENABLE_ASSEMBLER/#ifdef ENABLE_ASSEMBLER/, but i doubt it'll change anything. https://tbpl.mozilla.org/?tree=Try&rev=ff2bd33b8476 To me, JS_METHODJIT includes ENABLE_YARR_JIT, so that chunk in js/src/vm/RegExpObje

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Dao
http://hg.mozilla.org/integration/mozilla-inbound/rev/d68420c97e0e -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/y

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Spectre
Let's land this first, since it fixes arches that are actually broken. I'll rebase bug 731110 on top. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderb

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Landry-openbsd
The try builds on linux64 failed due to hg errors, i've asked the rebuild but the linux debug build shows the same failure. - what is the difference between debug and non debug builds in terms of JIT ? ENABLE_ASSEMBLER and ENABLE_YARR_JIT are set in both on linux, from what i can tell. - the pat

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Dvander
The failure in comment #72: Program received signal SIGSEGV, Segmentation fault. 0x081107fa in js::gc::CheckMarkedThing (trc=0x8577ca0, thing=0xf750bd78 "i") at /home/dvander/mozilla/mozilla-inbound/js/src/jsgcmark.cpp:81 81 JS_ASSERT_IF(trc->runtime->gcCurrentCompartment, IS_GC_MARKIN

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Landry-openbsd
(In reply to Mike Hommey [:glandium] from comment #71) > Well, if it's breaking linux debug builds, it means it's *not* only > shuffling ifdefs around. So you should start by checking that. It shuffles ENABLER_YARR_JIT, adds #if ENABLE_ASSEMBLER around execAlloc, ENABLE_ASSEMBLER is set on tier1 a

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Landry-openbsd
Just to make sure, i've pushed the offending diff to try with -b do -p linux,linux64 : https://tbpl.mozilla.org/?tree=Try&rev=d77a3095728e -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Mh+mozilla
Well, if it's breaking linux debug builds, it means it's *not* only shuffling ifdefs around. So you should start by checking that. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/9085

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Dmandelin
(In reply to Landry Breuil from comment #70) > So, what's needed to fix this ? Sorry, i have no idea why it changes > behaviour for linux debug builds, since it's only shuffling ifdefs around... > and the testsuite log isnt really verbose, besides saying there's a failure. You could try running on

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Landry-openbsd
So, what's needed to fix this ? Sorry, i have no idea why it changes behaviour for linux debug builds, since it's only shuffling ifdefs around... and the testsuite log isnt really verbose, besides saying there's a failure. -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Mak77
(In reply to Mike Hommey [:glandium] from comment #68) > Note that theoretically, this patch doesn't change anything on tier-1 > platforms. that was my assumption as well, but the backout fixed the problem. -- You received this bug notification because you are a member of Desktop Packages, which

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Mh+mozilla
(In reply to Marco Bonardo [:mak] from comment #67) > backed out as suspected for a bunch of jit tests failures in linux debug > builds > see > https://tbpl.mozilla.org/php/getParsedLog.php?id=9878244&tree=Mozilla-Inbound > https://tbpl.mozilla.org/php/getParsedLog.php?id=9878570&tree=Mozilla-Inbou

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Mak77
backed out as suspected for a bunch of jit tests failures in linux debug builds see https://tbpl.mozilla.org/php/getParsedLog.php?id=9878244&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=9878570&tree=Mozilla-Inbound while this looks like for other platforms, it was the most

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Landry-openbsd
Created attachment 603278 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported And here's a proper hg changeset, applied on top of m-c, running fine as "Mozilla/5.0 (X11; OpenBSD macppc; rv:13.0) Gecko/20120306 Firefox/13.0a1" I took the liberty of removing the now u

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Landry-openbsd
Set checkin-needed, carrying forward dmandelin's r+ on attachement 600506. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Landry-openbsd
patch #603183 reads good, applies fine on m-c. Doing a testbuild before setting checkin-needed, results in ~6h. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefo

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Mh+mozilla
Created attachment 603183 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported I refreshed the patch against current mozilla-inbound. Landry, can you check I didn't break anything? -- You received this bug notification because you are a member of Desktop Packages, w

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Landry-openbsd
Review ping ? :) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre Status in The Mozilla Firefox Browser:

[Desktop-packages] [Bug 908508]

2012-03-12 Thread Dmandelin
Comment on attachment 600506 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) Review of attachment 600506: - Stealing the review because Chris doesn't have time. Looks fine--just one litt

[Desktop-packages] [Bug 908508]

2012-02-27 Thread Christopher-leary
(In reply to Landry Breuil from comment #57) > Chris, can you review it ? i see no reason to wait for 661974, > and it would fix the build for exotic architectures. Sure, will try to get it done tomorrow! -- You received this bug notification because you are a member of Desktop Packages, which i

[Desktop-packages] [Bug 908508]

2012-02-27 Thread Landry-openbsd
(In reply to Landry Breuil from comment #55) > Created attachment 600506 > Use YARR interpreter instead of PCRE on platforms where YARR JIT is not > supported (m-c patch) > > That was it, with this new patch the build goes past js/. Changes from last > patch : > - update after landing of #700822,

[Desktop-packages] [Bug 908508]

2012-02-25 Thread Emmanuel Ch.
Sorry for the delay, I have gcc 4.5.3 on a gentoo ppc64 system. Patch on Comment 55 worked for me. Built successfully. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title:

[Desktop-packages] [Bug 908508]

2012-02-25 Thread Landry-openbsd
Created attachment 600506 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) That was it, with this new patch the build goes past js/. Changes from last patch : - update after landing of #700822, ie enclose use of execAlloc_ withing #if ENABLE_ASSEMBLE

[Desktop-packages] [Bug 908508]

2012-02-25 Thread Landry-openbsd
ok i think i figured it out.. the patch readded Assertions.cpp to CPPSRCS, which was gone from the ENABLE_YARR_JIT case in https://hg.mozilla.org/mozilla- central/diff/71d144fbd53e/js/src/Makefile.in. The breakage might be because mfbt/ is in the search path, and it's that mfbt/Assertions.cpp that

[Desktop-packages] [Bug 908508]

2012-02-25 Thread Mh+mozilla
These symbols are supposed to be in one OR the other, not in both. The relevant snippet in js/src/Makefile.in is: ifeq (,$(MOZ_GLUE_PROGRAM_LDFLAGS)) # When building standalone, we need to include mfbt sources, and to declare # "exported" mfbt symbols on its behalf when we use its headers. includ

[Desktop-packages] [Bug 908508]

2012-02-25 Thread Landry-openbsd
Most likely fallout of #717540, maybe because of the support (supposedly, yes) of __attribute__((weak)) in our gcc.. Emmanueel, what's your compiler ? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.la

[Desktop-packages] [Bug 908508]

2012-02-25 Thread Landry-openbsd
(In reply to Mike Hommey [:glandium] from comment #49) > > Yes, except that YarrSyntaxChecker.cpp is in CPPSRCS only in > > ENABLE_YARR_JIT case.. > > Both your patch and my older patch add YarrSyntaxChecker.cpp to CPPSRCS in > the non-ENABLE_YARR_JIT case Yep, but YarrSyntaxChecker.h is only i

[Desktop-packages] [Bug 908508]

2012-02-25 Thread Emmanuel Ch.
Just to clarify, I had included the patch in Comment 40 so I have not really knowledge of what happens there. Any idea why it complains about MozAssert and MozCrash? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu.

[Desktop-packages] [Bug 908508]

2012-02-24 Thread Mh+mozilla
> Yes, except that YarrSyntaxChecker.cpp is in CPPSRCS only in ENABLE_YARR_JIT case.. Both your patch and my older patch add YarrSyntaxChecker.cpp to CPPSRCS in the non-ENABLE_YARR_JIT case -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 908508]

2012-02-24 Thread Mh+mozilla
For checkSyntax, nothing needs to be done, really. Essentially, the #ifdef is wrong, the code is not tied to the YARR JIT, it's tied to YARR. So removing the #ifdef works. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubu

[Desktop-packages] [Bug 908508]

2012-02-24 Thread Landry-openbsd
Yes, except that YarrSyntaxChecker.cpp is in CPPSRCS only in ENABLE_YARR_JIT case.. i'll wrap up a patch removing that #ifdef, and adding that cpp file to CPPSRCS in the !ENABLE_YARR_JIT case to see if it helps. Patch has to be updated anyway since landing of #700822 -- You received this bug noti

[Desktop-packages] [Bug 908508]

2012-02-20 Thread Emmanuel Ch.
Hello, I had the same problem on Linux ppc64 with a recent hg spidermonkey checkout. To this matter, on a recent hg checkout, I tried the patch mentioned in Comment 40, but failed on jscntxt.cpp. I applied the changes needed by hand and created the following patch in order to make it able to bu

[Desktop-packages] [Bug 908508]

2012-02-17 Thread Landry-openbsd
Will that mean that !yarr-jit will become part of the 'regular testsuite', so that build breakage are detected on tbpl ? Ill monitor #661974, when you have something ready i'll try-compile it on ppc.. -- You received this bug notification because you are a member of Desktop Packages, which is sub

[Desktop-packages] [Bug 908508]

2012-02-17 Thread Christopher-leary
(In reply to Landry Breuil from comment #44) > Will that mean that !yarr-jit will become part of the 'regular testsuite', > so that build breakage are detected on tbpl ? Not build breakage, no, since we won't build with !YARR_JIT, but correctness testing (since we can disable the JIT at runtime an

[Desktop-packages] [Bug 908508]

2012-02-15 Thread Christopher-leary
(In reply to Landry Breuil from comment #41) > Apart checkSyntax, it should be okay. Chris, any idea what > to do about that, and would it be so wrong to return true, given that it > worksforme ? Hey Landry, sorry for the delay on this. We have to do something about checkSyntax. I need to create a

[Desktop-packages] [Bug 908508]

2012-02-15 Thread Landry-openbsd
And the build was successful, browsing maps.google.fr from my iBook G4 with http://buildbot.rhaalovely.net/builds/firefox-13.0a1.en- US.openbsd5.1-powerpc.tar.bz2. Apart checkSyntax, it should be okay. Chris, any idea what to do about that, and would it be so wrong to return true, given that it wo

[Desktop-packages] [Bug 908508]

2012-02-15 Thread Landry-openbsd
in bug #684559 comment 34, cameron kaiser talks about the possibility of 'unless simply trying to build it (+/- throwing away the result) is acceptable.' to check syntax on !yarr_jit platforms, how would it be achievable ? -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 908508]

2012-02-14 Thread Landry-openbsd
Comment on attachment 594798 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) Doesn't apply anymore since landing of bug #724748, since code was shuffled a bit. I'll try to come up with a new patch. Sigh. Can someone care a bit about that issue so that

[Desktop-packages] [Bug 908508]

2012-02-14 Thread Landry-openbsd
Created attachment 596748 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) Same patch, updated. Build results in a few hours (if anything else didn't broke on exotic archs..) in http://buildbot.rhaalovely.net/builders/mozilla-central-macppc/builds/54

[Desktop-packages] [Bug 908508]

2012-02-14 Thread Landry-openbsd
Created attachment 596771 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) Grr mishmashed patch.. here's a correct one that at least should build js/. Results in http://buildbot.rhaalovely.net/builders/mozilla-central-macppc/builds/55 -- You receive

[Desktop-packages] [Bug 908508]

2012-02-10 Thread Landry-openbsd
how are you trying to build it jit-free ? those codepaths are not really tested.. and armv7 falls in the case where ENABLE_ASSEMBLER should be set, which builds ExecutablePool/Allocator code.. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed

[Desktop-packages] [Bug 908508]

2012-02-10 Thread Acatel
I don't care if the JIT compiler is built. I'm just trying to escape de ENABLE_YARR_JIT path but I'm failing. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/

[Desktop-packages] [Bug 908508]

2012-02-09 Thread Acatel
Any update on this? I'm trying to build a JIT-free version a SM for armv7. The last failing piece is related to YARR-JIT. Landry, I can build without error with your patch but the link fail with : Undefined symbols for architecture armv7: "__ZN3JSC14ExecutablePoolD1Ev", referenced from:

[Desktop-packages] [Bug 908508]

2012-02-06 Thread Landry-openbsd
Created attachment 594798 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch) And here's a new updated patch after last commits to that area, which allows me to build m-c on sparc64 and ppc, i've run dromaeo & kraken tests on ppc for a bunch of hours wi

[Desktop-packages] [Bug 908508]

2012-02-04 Thread Landry-openbsd
Since landing of bug #688069, previous patch (#591376) doesn't apply anymore (regExpPrivateCode disappeared/was renamed ?). I have a bad feeling about fighting for a lost cause, and chasing a moving target i don't know the code nor how it works, and blindly adding #ifdefs while trying to 'backp

[Desktop-packages] [Bug 908508] Re: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre

2012-02-02 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/lucid-proposed/firefox -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre Status

[Desktop-packages] [Bug 908508] Re: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre

2012-02-02 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/natty-proposed/firefox ** Branch linked: lp:ubuntu/maverick-proposed/firefox ** Branch linked: lp:ubuntu/oneiric-proposed/firefox -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https:/

[Desktop-packages] [Bug 908508] Re: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre

2012-02-02 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/oneiric-proposed/thunderbird -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre

[Desktop-packages] [Bug 908508] Re: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre

2012-01-29 Thread Launchpad Bug Tracker
** Branch linked: lp:~mozillateam/firefox/firefox.oneiric ** Branch linked: lp:~mozillateam/firefox/firefox.natty ** Branch linked: lp:~mozillateam/firefox/firefox.lucid ** Branch linked: lp:~mozillateam/firefox/firefox.maverick ** Branch linked: lp:~mozillateam/thunderbird/thunderbird.oneiric

[Desktop-packages] [Bug 908508] Re: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre

2012-01-29 Thread Launchpad Bug Tracker
** Branch linked: lp:thunderbird/stable -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre Status in The Moz

  1   2   >