[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2020-07-09 Thread Jakub Vaněk
Thank you, I've tested the fix and it mostly works. However, a minor fixup is needed for flawless switching of this particular modem, see https://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=2&t=2915#p19606 -- You received this bug notification because you are a member of Desktop Package

[Desktop-packages] [Bug 1866926] Re: Device validation failing when connected to an usb hub

2020-07-04 Thread Jakub Vaněk
Hmmm, the Ubuntu version does depend on Tcl. I think a better solution would be to go with Jim (as Debian does: https://packages.debian.org/buster/usb-modeswitch) for both Focal and Groovy. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 1866926] Re: Device validation failing when connected to an usb hub

2020-07-04 Thread Jakub Vaněk
I'm starting to feel that trying to fix the C rewrite is futile. On line 392 of usb_modeswitch_dispatcher.c, the iface variable is overwritten. Unfortunately the value being assigned is not an interface number, it is rather a USB class number. Fixing this might help with some part of this, but it

[Desktop-packages] [Bug 1866926] Re: Device validation failing when connected to an usb hub

2020-07-04 Thread Jakub Vaněk
Hi all, I'm the one who accidentally introduced the bug when fixing https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/1676763. I'm sorry for causing the problem, I will try to find a fix that will work in both scenarios. Best regards, Jakub -- You received this bug notification bec

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
The two patches inside the debdiff fix these bugs: * First issue is that usb_modeswitch_dispatcher.c crashes when a device presented to it has no USB interface 0. This is caused by improper checking for a NULL pointer returned by a interface-lookup function. It is fixed by adding a null-check and

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
This is a debdiff for Bionic applicable to usb- modeswitch_2.5.2+repack0-2ubuntu1. I built this in pbuilder and it builds successfully, and I installed it, the patch works as intended. ** Patch added: "debdiff against usb-modeswitch_2.5.2+repack0-2ubuntu1" https://bugs.launchpad.net/ubuntu/+s

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
** Patch removed: "debian patch against usb-modeswitch_2.5.2+repack0-2ubuntu1" https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/1676763/+attachment/5316289/+files/bionic.patch -- You received this bug notification because you are a member of Desktop Packages, which is subscribed

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
** Information type changed from Public Security to Public -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to usb-modeswitch in Ubuntu. https://bugs.launchpad.net/bugs/1676763 Title: usb_modeswitch_dispatcher crashed with SIGSEGV in strrc

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
The patch for bionic should be applicable to focal as well (current development branch; currently reading https://wiki.ubuntu.com/StableReleaseUpdates ). -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to usb-modeswitch in Ubuntu. https://bu

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
** Patch added: "debian patch against usb-modeswitch_2.2.5+repack0-1ubuntu1" https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/1676763/+attachment/5316290/+files/xenial.patch -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
I am sorry for uploading the patches multiple times, I wanted them to be clean (i.e. patches ending with .patch, having consistent directory versions, etc) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to usb-modeswitch in Ubuntu. https://

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
** Patch removed: "debian patch against usb-modeswitch_2.5.2+repack0-2ubuntu1" https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/1676763/+attachment/5316287/+files/bionic.patch ** Patch added: "debian patch against usb-modeswitch_2.5.2+repack0-2ubuntu1" https://bugs.launchpad.n

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
** Patch added: "debian patch against usb-modeswitch_2.2.5+repack0-1ubuntu1" https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/1676763/+attachment/5316288/+files/xenial.patch -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
** Patch removed: "debian patch against usb-modeswitch_2.5.2+repack0-2ubuntu1" https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/1676763/+attachment/5316282/+files/bionic.patch ** Patch added: "debian patch against usb-modeswitch_2.5.2+repack0-2ubuntu1" https://bugs.launchpad.n

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
I'm sending patch for Xenial. ** Patch added: "debian patch against usb-modeswitch_2.2.5+repack0-1ubuntu1" https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/1676763/+attachment/5316286/+files/xenial.patch -- You received this bug notification because you are a member of Desktop P

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
Thanks! I have attached a patch for the Bionic release. ** Patch added: "debian patch against usb-modeswitch_2.5.2+repack0-2ubuntu1" https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/1676763/+attachment/5316282/+files/bionic.patch -- You received this bug notification because yo

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-29 Thread Jakub Vaněk
I have realized that these are two different issues. 1) Ubuntu's version of usb_modeswitch_dispatcher crashes when there is no interface 0. 2) All versions exit prematurely (non-Ubuntu versions exit gracefully) and do not switch the device. Therefore I'd include a fix only for (1) - to make the

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-25 Thread Jakub Vaněk
Upstream bugreport: http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=2&t=2915 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to usb-modeswitch in Ubuntu. https://bugs.launchpad.net/bugs/1676763 Title: usb_modeswitch_dispatche

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-25 Thread Jakub Vaněk
I have tried installing the package from Buster. That has resolved the crash - the program ended gracefully. However the underlying problem is still there - devices without interface 0 will not work. I think this is present in upstream as well. USB_ModeSwitch log from Wed Dec 25 16:35:30 CET 2019

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-25 Thread Jakub Vaněk
EDIT: the null-pointer bug only exists in Ubuntu, the interface error bug may exist in upstream as well. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to usb-modeswitch in Ubuntu. https://bugs.launchpad.net/bugs/1676763 Title: usb_modes

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-25 Thread Jakub Vaněk
Hmmm, it seems that this bug exists *only* in Ubuntu and not in Debian. Ubuntu source package contains a patch that rewrites the usb_modeswitch_dispatcher program from Tcl to C. While there must have been good reasons to do this, there is at least one more bug in the rewritten version. On line 422

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-25 Thread Jakub Vaněk
I think that upgrading the modem firmware (I have Sierra Wireless EM7305) might help, but that does not fix the underlying bug / broken assumptions. ** Tags added: bionic -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to usb-modeswitch in

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-25 Thread Jakub Vaněk
Ah, it starts to make sense. usb_modeswitch_dispatcher is called correctly, but it cannot find interface 0 on the device to be switched. However, dmesg contains warning about the same thing: [2.369824] usb 1-11: new high-speed USB device number 5 using xhci_hcd [2.520482] usb 1-11: config

[Desktop-packages] [Bug 1726229] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in main()

2019-12-25 Thread Jakub Vaněk
*** This bug is a duplicate of bug 1676763 *** https://bugs.launchpad.net/bugs/1676763 I suspect that this bug is a duplicate of #1676763. ** This bug has been marked a duplicate of bug 1676763 usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr() -- You received this bug notificat

[Desktop-packages] [Bug 1676763] Re: usb_modeswitch_dispatcher crashed with SIGSEGV in strrchr()

2019-12-25 Thread Jakub Vaněk
Very similar crash happens to me on Bionic as well. So far it seems to me that usb_modeswitch_dispatcher is called incorrectly and therefore it crashes when it eventually encounters a NULL pointer. -- You received this bug notification because you are a member of Desktop Packages, which is subscr

[Desktop-packages] [Bug 1542022] Re: gvfsd-dav crashed with SIGSEGV in strlen()

2017-05-17 Thread Jakub Vaněk
** Information type changed from Private to Public -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gvfs in Ubuntu. https://bugs.launchpad.net/bugs/1542022 Title: gvfsd-dav crashed with SIGSEGV in strlen() Status in gvfs package in Ubu