[Desktop-packages] [Bug 214366]

2014-02-20 Thread Irving
Comment on attachment 8377817 patch v5 Review of attachment 8377817: - (In reply to n...@parkwaycc.co.uk from comment #124) > (In reply to aceman from comment #123) > > (In reply to comment #122) > > > (From update of attachment 8374

[Desktop-packages] [Bug 214366]

2014-02-13 Thread Irving
Comment on attachment 8374439 WIP patch 4 Review of attachment 8374439: - ::: mail/locales/en-US/chrome/messenger/messenger.properties @@ +58,5 @@ > sendingUnsent=Sending Unsent Messages > > folderExists=A folder with that name a

[Desktop-packages] [Bug 214366]

2014-02-11 Thread Irving
Comment on attachment 8371072 WIP patch 3 Review of attachment 8371072: - Nice test. ::: mailnews/local/src/nsLocalMailFolder.cpp @@ +1723,5 @@ > return NS_MSG_ERROR_COPY_FOLDER_ABORTED; > } >} > + > + nsAutoStrin

[Desktop-packages] [Bug 214366]

2014-02-06 Thread Irving
Comment on attachment 8370331 WIP patch 2 Review of attachment 8370331: - I'm OK with this approach. I'd like to see test cases for both a single folder and a nested folder - for example: make folder A move A to trash make new A mov

[Desktop-packages] [Bug 214366]

2014-02-06 Thread Irving
(In reply to :aceman from comment #89) > > We don't need to test all those combinations for every message store type, > > but we should at least test the copyFolder(...aNewName) parameter works once > > on each store type. > Store type as in mbox and maildir? Do we actually have tests differentiat

[Desktop-packages] [Bug 261595]

2013-09-08 Thread Irving
This might be worth slipping in to the closed tree, to make sure it shows up in the next successful nightly. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/261595 Title: Thunderbi

[Desktop-packages] [Bug 261595]

2013-08-08 Thread Irving
Comment on attachment 756486 Write updated popstate in tempfile first, then move over Review of attachment 756486: - Thanks so much for the patch; sorry it took so long for me to review it. I'm OK with either landing this patch as i

[Desktop-packages] [Bug 214366]

2013-04-02 Thread Irving
I agree with David's remark in comment 70, that we should not rename the folder before copying - we should just copy it directly into the new name. I don't think we need to do anything complicated to deal with duplicate names; appending a number is probably enough. I don't have any insight into wh

[Desktop-packages] [Bug 1074260]

2013-03-12 Thread Irving
Yes, you can send it to me - is it OK if I also share it with Atul, if he has more time to work on it? Just click on my name in the Bugzilla comment and you'll get the right address. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunder

[Desktop-packages] [Bug 1074260]

2012-12-05 Thread Irving
*** Bug 805830 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/1074260 Title: Thunderbird heavy IMAP traffic downloading messages S

[Desktop-packages] [Bug 1074260]

2012-11-15 Thread Irving
(In reply to Florian Effenberger from comment #79) > Do I assume right that the fix is not included in 17.0b3? Tried it, and > still has that bug. Have you repaired the folder? Right click on the folder, select "Properties...", in the "General Information" pane click "Repair Folder". Thunderbird s

[Desktop-packages] [Bug 1074260]

2012-11-15 Thread Irving
Aurora: https://hg.mozilla.org/releases/comm-aurora/rev/5a84996bc6cb Beta: https://hg.mozilla.org/releases/comm-beta/rev/9e078e25d475 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/1

[Desktop-packages] [Bug 1074260]

2012-11-15 Thread Irving
It would also help us a lot if you could run from the command line with IMAP and related logging turned on; set the environment variable NSPR_LOG_MODULES=imap:5,ImapAutoSync:5,msgdb:5,timestamp,sync before starting Thunderbird, and capture all the output to the console (stdout/stderr for you Linu

[Desktop-packages] [Bug 1074260]

2012-11-15 Thread Irving
https://hg.mozilla.org/comm-central/rev/3ecc92fdbac2 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/1074260 Title: Thunderbird heavy IMAP traffic downloading messages Status in M

[Desktop-packages] [Bug 1074260]

2012-11-15 Thread Irving
The fix is in the latest Nightly builds at http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm- central/. If we can get some confirmation that this improves things for people, and doesn't cause any other issues, we'll try to pull it into the last TB 17 Beta build early next week.

[Desktop-packages] [Bug 1074260]

2012-11-09 Thread Irving
Using Kent's glodaquilla extension and turning on the "onDisk" column is very helpful to see whether messages are considered to be properly downloaded for offline storage -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubun

[Desktop-packages] [Bug 1074260]

2012-11-09 Thread Irving
Connor, are you testing against Zarafa or gmail (or both, or other)? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/1074260 Title: Thunderbird heavy IMAP traffic downloading messa

[Desktop-packages] [Bug 1074260]

2012-11-09 Thread Irving
Paul, the closing output is normal from a debug build (it's turned off in final builds). I suspect you're now hitting another open issue - can you check the following bugs and see if you fit any of them? Bug 891334, Bug 795590, bug 796989, bug 793792 If so, get in touch with me or comment on the

[Desktop-packages] [Bug 1074260]

2012-11-08 Thread Irving
There are now debug "try" builds available with this patch at http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try- builds/ir...@mozilla.com-fcd5c6c5168e/ If a few of you who have reported this issue could please download and test these builds it would be a big help to us. -- You received this

[Desktop-packages] [Bug 1074260]

2012-11-08 Thread Irving
Created attachment 679311 Update message size in database on every full message download This undoes a behaviour change introduced in bug 740453, where we changed from updating the message database's size field (with a sometimes incorrect value) on every offline message download, to only updating

[Desktop-packages] [Bug 1074260]

2012-11-03 Thread Irving
Disabling download of MIME parts on demand may work around this issue - could some of you try setting the advanced preference mail.imap.mime_parts_on_demand to false, restart Thunderbird, and see if the problem goes away? -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 1074260]

2012-11-03 Thread Irving
Thanks for all your triage work, everybody. The information from Glodaquilla is very helpful. I can reproduce this in my development environment and I'm working on a fix; I'll reach out to you if I need any additional information. -- You received this bug notification because you are a member of

[Desktop-packages] [Bug 1068921]

2012-10-26 Thread Irving
Trunk: https://hg.mozilla.org/comm-central/rev/e41fcf967c2b Aurora: https://hg.mozilla.org/releases/comm-aurora/rev/dec20675b05e Beta: https://hg.mozilla.org/releases/comm-beta/rev/e89e3afc6144 Release: https://hg.mozilla.org/releases/comm-release/rev/cce1d52502cc -- You received this bug notific

[Desktop-packages] [Bug 1052306]

2012-10-25 Thread Irving
Comment on attachment 664374 possible fix Review of attachment 664374: - Looks OK to me; there's a lot of code that changes behaviour if m_imapMailFolderSink is null so we'll need to keep an eye on trunk in case this moves the crash

[Desktop-packages] [Bug 1068921]

2012-10-25 Thread Irving
I'm not comfortable with this approach; the message size we get (which is actually the size of one text part of the message, accidentally set when downloading parts of a MIME multipart message separately) is not guaranteed to be larger or smaller than the number of line breaks in the entire message

[Desktop-packages] [Bug 1068921]

2012-10-25 Thread Irving
Created attachment 675465 Test message with many inline images When I set the checkbox for maximum message size to store offline, with a limit of 50 kbytes, this message gets downloaded very inefficiently - each image attachment is requested from gmail separately, but for each inline image display

[Desktop-packages] [Bug 1068921]

2012-10-25 Thread Irving
Created attachment 675468 call DiscardNewMessage properly, only update size when downloading full message This includes my previous patch and also keeps track of when we're downloading an entire message, and only updates the message size in the DB on entire message downloads. This patch seems to f

[Desktop-packages] [Bug 1068921]

2012-10-23 Thread Irving
Created attachment 674524 WIP: Call DiscardNewMessage() with non-null stream to avoid early exit This is part 2 of the fix, when we detect a mismatch between the expected size of a message and the actual size we try to take the message back out of the local store. Because of some interactions with

[Desktop-packages] [Bug 1068921]

2012-10-23 Thread Irving
Is somebody with the bug willing to test whether it's related to the offline message size limit? Open the Mail Server properties for a folder showing this problem (right click on the mail server, select "Settings...", select the "Synchronization and Storage" settings, and check whether you have "Do

[Desktop-packages] [Bug 1068921]

2012-10-23 Thread Irving
I've reproduced what I think is this issue on OS X against gmail's IMAP server. The problem comes in two parts, and so far I think I have a fix for part 1. I'll put up a WIP patch. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbi

[Desktop-packages] [Bug 885525]

2012-10-04 Thread Irving
My preference for the options would be 1) Mark message as deleted 2) Move to the server's Trash folder 3) Move to this folder: 4) Remove immediately ... with the wording cleaned up by UI review -- You received this bug notification because you are a member of Desktop Packages, which is subscri

[Desktop-packages] [Bug 220991]

2012-07-05 Thread Irving
*** This bug has been marked as a duplicate of bug 92111 *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/220991 Title: Thunderbird corrupts attachments from IMAP exchange serve

[Desktop-packages] [Bug 220991]

2012-07-05 Thread Irving
This was fixed by bug 92111; should we dupe this to that bug to close it, or resolve this bug separately? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/220991 Title: Thunderbird

[Desktop-packages] [Bug 830049] Re: gnome-language-selector crashed with SystemError in required_download(): E:I wasn't able to locate a file for the openoffice.org-common package.

2011-08-22 Thread Irving Duran
** Visibility changed to: Public -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to language-selector in Ubuntu. https://bugs.launchpad.net/bugs/830049 Title: gnome-language-selector crashed with SystemError in required_download(): E:I

[Desktop-packages] [Bug 830064] Re: software-center crashed while trying to install abode-flashplugin source on ubuntu 11.10

2011-08-22 Thread Irving Duran
** Visibility changed to: Public -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to software-center in Ubuntu. https://bugs.launchpad.net/bugs/830064 Title: software-center crashed while trying to install abode-flashplugin source on ubu