[Desktop-packages] [Bug 1917191]

2021-03-05 Thread Gabriele Svelto
Ugh, this bug is affecting Linux users real badly on 86. Do we have a way to reach out to distro maintainers to try and help them roll out a local fix for their 86 builds? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 1849615]

2019-12-19 Thread Gabriele Svelto
(In reply to Ryan VanderMeulen [:RyanVM] from comment #13) > Looks like this grafts cleanly to ESR68 - did you want to nominate it for > uplift? Yes, let's do it. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https:

[Desktop-packages] [Bug 1849615]

2019-12-19 Thread Gabriele Svelto
Comment on attachment 9104623 Bug 1590984 - Use poll() instead of select() in WebRTC code r=drno ### ESR Uplift Approval Request * **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: This fixes a crash that can easily occur when using WebRTC. * **User impact if decl

[Desktop-packages] [Bug 1849615]

2019-12-19 Thread Gabriele Svelto
There's quite a few crashes coming from ESR68 on Debian. The patch is not large and low-risk, maybe we could uplift it. I'll see if it applies cleanly there. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.

[Desktop-packages] [Bug 1849615]

2019-12-19 Thread Gabriele Svelto
No testing is needed, thanks Catalin. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1849615 Title: WebRTC-related crashes Status in Mozilla Firefox: Fix Released Status in firefox

[Desktop-packages] [Bug 1849615]

2019-10-29 Thread Gabriele Svelto
Taking this as I've got a WIP patch. It just needs some good testing. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1849615 Title: WebRTC-related crashes Status in Mozilla Firefox:

[Desktop-packages] [Bug 1849615]

2019-10-29 Thread Gabriele Svelto
Created attachment 9104623 Bug 1590984 - Use poll() instead of select() in WebRTC code r=drno The use of select() was leading to crashes when the file descriptor value was larger than FD_SETSIZE. Recent versions of glibc have checks in the FD_CLR(), FD_SET() and FD_ISSET() macros that will abort()

[Desktop-packages] [Bug 1849615]

2019-10-26 Thread Gabriele Svelto
(In reply to Dan Minor [:dminor] from comment #3) > Hi Gabriele, this code is our local modification to webrtc.org that we have > never merged upstream. As such, feel free to rewrite it to use poll() if that > will fix things. I'm not the original author, I just happened to do the last > upstrea

[Desktop-packages] [Bug 1849615] Re: WebRTC-related crashes

2019-10-24 Thread Gabriele Svelto
Nevermind, this isn't WebRTC-specific and not even Ubuntu-specific since I could find Debian instances of it. It's caused by select() being used instead of more modern methods that don't have limits on the file descriptor values you pass to them. Sorry for the noise. -- You received this bug noti

[Desktop-packages] [Bug 1849615] Re: WebRTC-related crashes

2019-10-24 Thread Gabriele Svelto
I did some further digging and this isn't a WebRTC-specific issue though it tends to crash WebRTC code more often than other code. See this for another similar crash in code we don't control (and which might also be using select() and thus triggering the safety check): https://crash-stats.mozilla

[Desktop-packages] [Bug 1849615] [NEW] WebRTC-related crashes

2019-10-24 Thread Gabriele Svelto
Public bug reported: In Mozilla we've detected a spike of crashes in the Ubuntu-packaged version of Firefox 69.0.x. All the crashes are happening in the WebRTC code and specifically libc's FD_SET, FD_CLR and FD_ISSET range-checking safety is causing an abort. Is it possible that Firefox is being b

[Desktop-packages] [Bug 1849615] Re: WebRTC-related crashes

2019-10-24 Thread Gabriele Svelto
Here's the relevant bug on our tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=1590984 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1849615 Title: WebRTC-related crashes Stat

[Desktop-packages] [Bug 1845205] Re: Cannot submit crash reports from firefox' "this tab crashed" page

2019-10-08 Thread Gabriele Svelto
Interesting, that shouldn't happen. The minidump-analyzer executable greatly improves our crash telemetry but it's not strictly needed for crash reporting. I'll file a bug on our side to fix that issue. -- You received this bug notification because you are a member of Desktop Packages, which is s

[Desktop-packages] [Bug 1845205] Re: Cannot submit crash reports from firefox' "this tab crashed" page

2019-10-07 Thread Gabriele Svelto
Yes, manual submission via about:crashes works fine. It's just the tab crash reporter that doesn't show up as it should. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1845205 Title:

[Desktop-packages] [Bug 1845205] [NEW] Cannot submit crash reports from firefox' "this tab crashed" page

2019-09-24 Thread Gabriele Svelto
Public bug reported: Steps to reproduce: - Launch firefox - Enter "about:crashcontent" in the URL bar - Upon hitting return, the tab should crash and display the "This tab just crashed" page - Ensure that the checkmark to send the crash report is ticked - Add a comment (anything will do, a non-e