Bug#604010: x11-common: xsession should use $SHELL and not sh directly

2011-02-17 Thread Vincent Lefevre
On 2011-02-17 16:39:52 +0100, Michel Briand wrote: > I don't think $SHELL is only there to run simple commands. IIRC the > $SHELL variable is set after the value in /etc/passwd (or whatever > account mgt system) and represent the preferred shell and what we can > refer as the "login shell". > > I

Bug#604010: x11-common: xsession should use $SHELL and not sh directly

2011-02-17 Thread Michel Briand
Vincent Lefevre - Tue, 15 Feb 2011 12:17:25 +0100 >On 2011-02-12 12:58:46 +0100, Cyril Brulebois wrote: >> Hi Michel, >> >> Michel Briand (19/11/2010): >> > 50x11-common_determine-startup SHOULD not use "sh $STARTUPFILE" >> > but "$SHELL $STARTUPFILE" >> >> I've just replaced that with: >> +

Bug#604010: x11-common: xsession should use $SHELL and not sh directly

2011-02-15 Thread Vincent Lefevre
On 2011-02-12 12:58:46 +0100, Cyril Brulebois wrote: > Hi Michel, > > Michel Briand (19/11/2010): > > 50x11-common_determine-startup SHOULD not use "sh $STARTUPFILE" > > but "$SHELL $STARTUPFILE" > > I've just replaced that with: > + shell=${SHELL:-sh} > + STARTUP="$shell $STAR

Bug#604010: x11-common: xsession should use $SHELL and not sh directly

2011-02-12 Thread Cyril Brulebois
Michel Briand (12/02/2011): > Yes. It works. Thank you. Thanks for confirming. Will be in 1:7.6+3. > Sure. But your modification makes the trick bulletproof: a lot of > users won't think about the shebang and the x flag, isn't it ? A lot of users just use Gnome or whatever. :) KiBi. signatur

Bug#604010: x11-common: xsession should use $SHELL and not sh directly

2011-02-12 Thread Michel Briand
Cyril Brulebois - Sat, 12 Feb 2011 12:58:46 +0100 >Hi Michel, > >Michel Briand (19/11/2010): >> 50x11-common_determine-startup SHOULD not use "sh $STARTUPFILE" >> but "$SHELL $STARTUPFILE" > >I've just replaced that with: >+ shell=${SHELL:-sh} >+ STARTUP="$shell $STARTUPFILE"

Bug#604010: x11-common: xsession should use $SHELL and not sh directly

2011-02-12 Thread Cyril Brulebois
Hi Michel, Michel Briand (19/11/2010): > 50x11-common_determine-startup SHOULD not use "sh $STARTUPFILE" > but "$SHELL $STARTUPFILE" I've just replaced that with: + shell=${SHELL:-sh} + STARTUP="$shell $STARTUPFILE" which should do what you want. Anyway, why don't you make yo

Bug#604010: x11-common: xsession should use $SHELL and not sh directly

2010-11-19 Thread Michel Briand
Package: x11-common Version: 1:7.5+7 Severity: normal I'm used to bash since ages. Debian recently moved to /bin/dash -> /bin/sh to speed up system scripts. I use many bashisms in my .xsession. I've configured /bin/bash as my prefered shell. 50x11-common_determine-startup SHOULD not use "sh $ST