Re: RFS: ruby-rotp

2015-06-20 Thread Cédric Boutillier
Hi Balasankar, On Sat, Jun 20, 2015 at 11:11:13AM +0530, Balasankar C wrote: > Hi, > I've made the corrections you pointed out and pushed to the repo. Uploaded! thanks. Cédric signature.asc Description: Digital signature

Re: RFS: ruby-rotp

2015-06-19 Thread Balasankar C
Hi, I've made the corrections you pointed out and pushed to the repo. -- Regards Balasankar C http://balasankarc.in -- To UNSUBSCRIBE, email to debian-ruby-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/5

Re: RFS: ruby-rotp

2015-06-19 Thread Cédric Boutillier
Hi! On Fri, Jun 19, 2015 at 09:12:01PM +0530, Balasankar C wrote: > Hi Cedric, > Can you check now? I am running yardocs and using sed (people still > use that, right?) to remove privacy-breaching stuff from the readme. > About repacking info in d/copyright, I think I'll go with the one I > used,

Re: RFS: ruby-rotp

2015-06-19 Thread Balasankar C
Hi Cedric, Can you check now? I am running yardocs and using sed (people still use that, right?) to remove privacy-breaching stuff from the readme. About repacking info in d/copyright, I think I'll go with the one I used, at least till Files-Excluded is added to official copyright format. -- Rega

Re: RFS: ruby-rotp

2015-06-16 Thread Cédric Boutillier
On Tue, Jun 16, 2015 at 08:11:45PM +0530, Balasankar C wrote: > Hi Cedric, > Thanks for the detailed review. I have some doubts though. > On ചൊവ്വ 16 ജൂണ്‍ 2015 12:06 വൈകു, Cédric Boutillier wrote: > > > > A few comments: - you may want to remove the LOAD_PATH modification > > in bin/rotp > Done

Re: RFS: ruby-rotp

2015-06-16 Thread Balasankar C
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Cedric, Thanks for the detailed review. I have some doubts though. On ചൊവ്വ 16 ജൂണ്‍ 2015 12:06 വൈകു, Cédric Boutillier wrote: > > A few comments: - you may want to remove the LOAD_PATH modification > in bin/rotp Done. This is done because, rot

Re: RFS: ruby-rotp

2015-06-15 Thread Cédric Boutillier
On Tue, Jun 16, 2015 at 11:20:46AM +0530, Balasankar C wrote: > On 2015-06-16 10:18, Cédric Boutillier wrote: > >I am the one to be sorry. I completely misread your email. Because of > >the context of a previous email about rex, I thought you renamed the tool > >in bin/ to ruby-rotp to avoid collis

Re: RFS: ruby-rotp

2015-06-15 Thread Balasankar C
On 2015-06-16 10:18, Cédric Boutillier wrote: I am the one to be sorry. I completely misread your email. Because of the context of a previous email about rex, I thought you renamed the tool in bin/ to ruby-rotp to avoid collisions. My bad. Sorry again for the confusion my message could have cau

Re: RFS: ruby-rotp

2015-06-15 Thread Cédric Boutillier
On Tue, Jun 16, 2015 at 07:24:18AM +0530, Balasankar C wrote: > On 16 June 2015 2:20:24 am IST, "Cédric Boutillier" wrote: > >On Sun, Jun 14, 2015 at 08:12:03PM +0530, Balasankar C wrote: > >> Hi, > >> I've prepared the packaging of the gem 'rotp' which is a runtime > >> dependency in the dependen

Re: RFS: ruby-rotp

2015-06-15 Thread Balasankar C
On 16 June 2015 2:20:24 am IST, "Cédric Boutillier" wrote: >On Sun, Jun 14, 2015 at 08:12:03PM +0530, Balasankar C wrote: >> Hi, >> I've prepared the packaging of the gem 'rotp' which is a runtime >> dependency in the dependency chain of GitLab. It is lintian-happy. >> Since it requires RSpec 3, I

Re: RFS: ruby-rotp

2015-06-15 Thread Cédric Boutillier
On Sun, Jun 14, 2015 at 08:12:03PM +0530, Balasankar C wrote: > Hi, > I've prepared the packaging of the gem 'rotp' which is a runtime > dependency in the dependency chain of GitLab. It is lintian-happy. > Since it requires RSpec 3, I have targeted it for experimental. It > builds fine in chroot (w