Re: RFS: ruby-bunny gem2deb migration completed

2012-01-20 Thread Gunnar Wolf
Praveen A dijo [Mon, Jan 16, 2012 at 08:20:03PM +0530]: > > Because it needs an amqp server to be running. Since it was running in > > my system it passed all the tests. Now when I ran it after stopping > > amqp-server all tests failed :( > > > > Form your log it is clear that amqp server was not s

Re: RFS: ruby-bunny gem2deb migration completed

2012-01-20 Thread Gunnar Wolf
Praveen A dijo [Mon, Jan 16, 2012 at 07:35:57PM +0530]: > > I think adding them as examples would be better than not providing any > > documentation at all. I will update the package. > > I have created a new revision with this change (there is also a typo > correction). Please upload the new revi

Re: RFS: ruby-bunny gem2deb migration completed

2012-01-20 Thread Gunnar Wolf
Praveen A dijo [Mon, Jan 16, 2012 at 02:03:16PM +0530]: > updated copyright file with all copyright terms for each file, please > check and upload. ruby-sigar uploaded. > I really wish this was already included in devscripts/licensecheck > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=472199

Re: RFS: ruby-bunny gem2deb migration completed

2012-01-16 Thread Praveen A
2012/1/15 Praveen A : > 2012/1/14 Gunnar Wolf : >> I'm adding two files you skipped to debian/copyright: >> ext/amqp-0.8.json and ext/amqp-0.9.1.json, by LShift Ltd, Cohesive >> Financial Technologies LLC and Rabbit Technologies Ltd., under the >> same Expat license. But besides that, almost all te

Re: RFS: ruby-bunny gem2deb migration completed

2012-01-16 Thread Praveen A
2012/1/15 Praveen A : > 2012/1/14 Gunnar Wolf : >> As for ruby-dust, the package is in good shape, and I am uploading it >> now. I just have a suggestion, but you can leave it for a -2 version: >> The package ships basically no documentation. The README says, "See >> the tests for more examples", b

Re: RFS: ruby-bunny gem2deb migration completed

2012-01-16 Thread Praveen A
2012/1/15 Praveen A : > 2012/1/14 Gunnar Wolf : >> As for ruby-sigar: >> >> - debian/ruby-sigar.docs has the boilerplate indication that a README >>  was found. Right, the README adds very little - Please decide: >>  Either you include the file as part of the documentation, or remove >>  the (usele

Re: RFS: ruby-bunny gem2deb migration completed

2012-01-14 Thread Praveen A
Hi Gunnar, Thanks for the review. Comments inline. 2012/1/14 Gunnar Wolf : > Praveen A dijo [Sat, Jan 14, 2012 at 09:56:02PM +0530]: >> Hi, >> >> I migrated libbunny-ruby to gem2deb based packaging and it is ready >> for upload in the git repo. It builds in a clean chroot, runs all >> tests succe