Re: RFS: cucumber 1.2.1-1

2012-06-25 Thread Vincent Fourmond
Hello, On Mon, Jun 25, 2012 at 10:44 AM, Cédric Boutillier wrote: >>   * why do you include a copy of jquery.js in the package ? I fail to >> see the point, if it is available from libjs-jquery. If you have to >> have it available at build time, build-depend on libjs-jquery and make >> appropri

Re: RFS: cucumber 1.2.1-1

2012-06-25 Thread Cédric Boutillier
Hi Vincent, Thanks for the review. On Sun, Jun 24, 2012 at 12:13:08AM +0200, Vincent Fourmond wrote: > * first, you say you dropped the suggests on ruby-prawn > ruby-nokogiri, but the latter still is referenced. BTW, why removing > the suggests at all if they provide additional functionality

Re: RFS: cucumber 1.2.1-1

2012-06-23 Thread Vincent Fourmond
Hello, On Fri, Jun 22, 2012 at 1:09 AM, Cédric Boutillier wrote: > I pushed to the repo a new version of cucumber. The package builds fine > in a clean environment and is lintian clean. Here is the entry of the > changelog: > > cucumber (1.2.1-1) unstable; urgency=low > >  * New upstream versio