Bug#754143: Fix the tests to not pollute the data directory

2014-07-09 Thread Christophe Siraut
Hi, Please review the attached patch. Cheers, Christophe >From 2fa4bbb478f6c2164caae90b898e5efef5a9a9e3 Mon Sep 17 00:00:00 2001 From: Christophe Siraut Date: Wed, 9 Jul 2014 13:56:31 +0200 Subject: [PATCH] Fix the tests to not pollute the data directory --- distro_tracker/project/settings/tes

Processed: Re: Bug#754143: Fix the tests to not pollute the data directory

2014-07-09 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > tags 754143 + patch Bug #754143 [tracker.debian.org] Fix the tests to not pollute the data directory Added tag(s) patch. > thanks Stopping processing here. Please contact me if you need assistance. -- 754143: http://bugs.debian.org/cgi-bin/bugre

Bug#754143: Fix the tests to not pollute the data directory

2014-07-09 Thread Raphael Hertzog
Hi Christophe, On Wed, 09 Jul 2014, Christophe Siraut wrote: > Please review the attached patch. Thanks for the patch but I don't believe that you're following the correct approach here. First, tests should work and behave correctly even without the settings in project/settings/test.py. This fil

Bug#754143: Fix the tests to not pollute the data directory

2014-07-09 Thread Christophe Siraut
> I'm not sure what's the best approach but I see two clean solutions: > > - something global implemented as a derivative class of TestCase that > does the required directory creation and settings change in self.setUp > and drops the directory with a function recorded with self.addCleanup See