Re: review for python-ssdpy

2022-10-04 Thread Ben Westover
On 10/4/22 8:50 AM, Jeroen Ploemen wrote: Thanks, I didn't catch that since I use sbuild instead of pbuilder. I have set the environment variable CI = true which should disable those tests. Unfortunately, it doesn't. The change suggested below does make 'CI=true' take effect, but that still le

Re: review for python-ssdpy

2022-10-04 Thread Jeroen Ploemen
On Mon, 3 Oct 2022 11:56:30 -0400 Ben Westover wrote: > Thanks, I didn't catch that since I use sbuild instead of pbuilder. > I have set the environment variable CI = true which should disable > those tests. Unfortunately, it doesn't. The change suggested below does make 'CI=true' take effect,

Re: review for python-ssdpy

2022-10-03 Thread Ben Westover
Hello, On 10/3/22 08:12, Jeroen Ploemen wrote: * control: missing build-dep on python3-all? Needed to run the testsuite against all supported Python version rather than just the default one. Thanks, added. * watch: regex "(\d\.\d.\d)" is overly specific, could easily miss upstream v

review for python-ssdpy

2022-10-03 Thread Jeroen Ploemen
Hi Ben, * control: missing build-dep on python3-all? Needed to run the testsuite against all supported Python version rather than just the default one. * watch: regex "(\d\.\d.\d)" is overly specific, could easily miss upstream versions such as a hypothetical "1.5" or "1.4.10". Package ftb