Re: a review of your bumblebee-status package

2022-06-08 Thread Antoine Beaupré
On 2022-06-07 18:46:37, Ben Westover wrote: > Hello, > > I've read more into versioneer, and it turns out with the way it works > you can't simply remove versioneer.py from the source, much less > _version.py. Therefore, I'm excluding _version.py in d/copyright, then > replacing it with the much

Re: Versioneer [was Re: a review of your bumblebee-status package]

2022-06-07 Thread Paul Wise
On Tue, 2022-06-07 at 16:12 +0200, Timo Röhling wrote: > Versioneer is meant to simplify version tracking for the developer; > it supports a number of authoritative sources such as "git > describe" to determine the current version number. There are two > modes of operation: > > - in developer mod

Re: a review of your bumblebee-status package

2022-06-07 Thread Ben Westover
Hello, I've read more into versioneer, and it turns out with the way it works you can't simply remove versioneer.py from the source, much less _version.py. Therefore, I'm excluding _version.py in d/copyright, then replacing it with the much smaller PyPI version in d/patches, and not touching

Re: a review of your bumblebee-status package

2022-06-07 Thread Julian Gilbey
On Tue, Jun 07, 2022 at 03:59:22PM +0100, Julian Gilbey wrote: > > > As far as I understand it, this file is used by the author of the > > > program, not end users. I don't understand it well, though, because I > > > haven't put much time into researching what versioneer even does. > > > If my hu

Re: a review of your bumblebee-status package

2022-06-07 Thread Julian Gilbey
On Tue, Jun 07, 2022 at 09:47:14AM -0400, Antoine Beaupré wrote: > >>> _version.py is not a copy of versioneer, it's *generated* by versioneer. > >>> However, there is versioneer.py in the root directory, which is. I'll > >>> exclude that from the source and repack. > >> > >> hmm... how about that

Re: a review of your bumblebee-status package

2022-06-07 Thread Julian Gilbey
On Tue, Jun 07, 2022 at 10:51:08AM -0400, Antoine Beaupré wrote: > It seems to me that generated files shouldn't be shipped as part of the > source we distributed to users. Those files should be (re)generated at > build time. Ah, I understand you better now. Debian is full of generated files dist

Re: a review of your bumblebee-status package

2022-06-07 Thread Antoine Beaupré
On 2022-06-07 15:44:28, Julian Gilbey wrote: > On Tue, Jun 07, 2022 at 09:47:33AM -0400, Antoine Beaupré wrote: >> On 2022-06-07 07:11:15, Julian Gilbey wrote: >> > [...] >> > As far as I understand, versioneer (or the _version.py generated by >> > it) uses a whole bunch of heuristics to determine

Re: a review of your bumblebee-status package

2022-06-07 Thread Julian Gilbey
On Tue, Jun 07, 2022 at 09:47:33AM -0400, Antoine Beaupré wrote: > On 2022-06-07 07:11:15, Julian Gilbey wrote: > > [...] > > As far as I understand, versioneer (or the _version.py generated by > > it) uses a whole bunch of heuristics to determine the version number > > of the package, for example

Versioneer [was Re: a review of your bumblebee-status package]

2022-06-07 Thread Timo Röhling
Hi everyone, * Ben Westover [2022-06-06 22:42]: As far as I understand it, this file is used by the author of the program, not end users. I don't understand it well, though, because I haven't put much time into researching what versioneer even does. Versioneer is meant to simplify version tra

Re: a review of your bumblebee-status package

2022-06-07 Thread Antoine Beaupré
On 2022-06-06 23:42:19, Ben Westover wrote: > Here's another note: > > On 6/6/22 10:49 AM, Antoine Beaupré wrote: >> * i'm really not sure I like that C binary to fetch the keyboard >>layout... surely there must be a more pythonic way of doing this? i >>guess there's another layout-xkb mod

Re: a review of your bumblebee-status package

2022-06-07 Thread Antoine Beaupré
On 2022-06-07 07:11:15, Julian Gilbey wrote: > Hi Ben, > > On Mon, Jun 06, 2022 at 10:42:53PM -0400, Ben Westover wrote: >> > > _version.py is not a copy of versioneer, it's *generated* by versioneer. >> > > However, there is versioneer.py in the root directory, which is. I'll >> > > exclude that f

Re: a review of your bumblebee-status package

2022-06-07 Thread Antoine Beaupré
On 2022-06-06 22:42:53, Ben Westover wrote: > Hello Antoine, > I am aware of this failure and have reported it upstream. For now, I'll disable the offending test. >>> >>> After doing that, I discovered that almost all of the tests are faulty >>> (at least on Python 3.10), so I've disabled

Re: a review of your bumblebee-status package

2022-06-06 Thread Andrey Rahmatullin
On Mon, Jun 06, 2022 at 10:42:53PM -0400, Ben Westover wrote: > > Does the package *work* at all in 3.10? We might not want to silence > > real errors here... > > Upstream says 3.4-3.9 is supported, but I don't know if that's because 3.10 > doesn't work or because they haven't bothered to add it.

Re: a review of your bumblebee-status package

2022-06-06 Thread Julian Gilbey
Hi Ben, On Mon, Jun 06, 2022 at 10:42:53PM -0400, Ben Westover wrote: > > > _version.py is not a copy of versioneer, it's *generated* by versioneer. > > > However, there is versioneer.py in the root directory, which is. I'll > > > exclude that from the source and repack. > > > > hmm... how about

Re: a review of your bumblebee-status package

2022-06-06 Thread Ben Westover
Here's another note: On 6/6/22 10:49 AM, Antoine Beaupré wrote: > * i'm really not sure I like that C binary to fetch the keyboard >layout... surely there must be a more pythonic way of doing this? i >guess there's another layout-xkb module that does the right thing, >but it seems odd

Re: a review of your bumblebee-status package

2022-06-06 Thread Ben Westover
Hello Antoine, I am aware of this failure and have reported it upstream. For now, I'll disable the offending test. After doing that, I discovered that almost all of the tests are faulty (at least on Python 3.10), so I've disabled tests altogether for now. Does the package *work* at all in 3.

Re: a review of your bumblebee-status package

2022-06-06 Thread Antoine Beaupré
On 2022-06-06 21:10:31, Ben Westover wrote: > Hello again, > Some corrections to my previous message: > >> As for how it's installed, I believe that's handled by the upstream setup.py: >>     data_files=[ >>     ("share/bumblebee-status/themes", glob.glob("themes/*.json")), >>     ("shar

Re: a review of your bumblebee-status package

2022-06-06 Thread Ben Westover
Hello again, Some corrections to my previous message: As for how it's installed, I believe that's handled by the upstream setup.py:     data_files=[     ("share/bumblebee-status/themes", glob.glob("themes/*.json")),     ("share/bumblebee-status/themes/icons", glob.glob("themes/icons/

Re: a review of your bumblebee-status package

2022-06-06 Thread Ben Westover
Bonjour Antoine, I already discussed this topic with you in IRC, but I'm documenting the details here for the sake of the mailing list. * i wonder if bumblebee-status/_version.py belongs there. it's a copy of the python3-versioneer package that's already in the archive... could you