Re: Request For a Review: python-mpd2/0.4.1-1 [ITP]

2012-03-21 Thread Geoffroy Youri Berret
Hi Simon, Le 21/03/2012 13:13, Simon McVittie a écrit : > On 20/03/12 23:16, Fernando Lemos wrote: > If the fork is just python-mpd with a few patches (as he states in the > upstream bug report), one option for moving forward is to review those > patches, check that they are as correct as they can

Re: Request For a Review: python-mpd2/0.4.1-1 [ITP]

2012-03-21 Thread Geoffroy Youri Berret
Hi, First, thank for the review Fernando :) I did forget to mention I recently adopt python-mpd, #612909 [0]. I also have to clarify that I only post an ITP for python-mpd2. This thread is only a request for *review* (not a RFS), I do not intend to ask for a sponsored upload in the near future

Re: Request For a Review: python-mpd2/0.4.1-1 [ITP]

2012-03-21 Thread Simon McVittie
On 20/03/12 23:16, Fernando Lemos wrote: > Forks that simply suffix "2" are a really poor idea. Yes, this. > * Is the python-mpd upstream unresponsive? It looks like Alexander > will stop actively maintaining python-mpd soon, but he doesn't support > the fork for a number of valid reasons that ha

Re: Request For a Review: python-mpd2/0.4.1-1 [ITP]

2012-03-20 Thread Fernando Lemos
Hi, On Tue, Mar 20, 2012 at 3:26 PM, Geoffroy Youri Berret wrote: > Le 20/03/2012 17:00, Jakub Wilk a écrit : >> Your Replaces is versioned but Conflicts is not. This is awkward. >> What has changed in python-mpd 0.3.0 that Replaces is not needed >> anymore? >> >> Is the conflict with python-mpd

Re: Request For a Review: python-mpd2/0.4.1-1 [ITP]

2012-03-20 Thread Scott Kitterman
On Tuesday, March 20, 2012 07:26:29 PM Geoffroy Youri Berret wrote: > > Is Python 3.1 really not supported? I couldn't find any information > > about this in upstream source. If it's really not, then you need a > > version constraint for the build-dependency. > > Right, this is a mistake. > I shou

Re: Request For a Review: python-mpd2/0.4.1-1 [ITP]

2012-03-20 Thread Geoffroy Youri Berret
Hi, Thanks for the review Jakub :) Le 20/03/2012 17:00, Jakub Wilk a écrit : > * Geoffroy Youri Berret , 2012-03-20, 15:50: >> http://mentors.debian.net/debian/pool/main/p/python-mpd2/python-mpd2_0.4.0-1.dsc I did paste the wrong link :/ http://mentors.debian.net/debian/pool/main/p/python-mpd2/p

Re: Request For a Review: python-mpd2/0.4.1-1 [ITP]

2012-03-20 Thread Jakub Wilk
* Geoffroy Youri Berret , 2012-03-20, 15:50: http://mentors.debian.net/debian/pool/main/p/python-mpd2/python-mpd2_0.4.0-1.dsc You wrote "debhelper (>= 9.0.0)" but debhelper doesn't use such versioning scheme anymore. I'd use plain "debhelper (>= 9)". python-all is needed in the clean tar