Re: RFS: Pyspread 0.2.6-1

2014-03-11 Thread Vincent Cheng
On Sat, Mar 8, 2014 at 4:57 AM, Andreas Noteng wrote: > On 07. mars 2014 02:52, Vincent Cheng wrote: >> >> If there aren't any non-DFSG-compliant files in upstream's tarball >> (and I see nothing that would suggest that this file in particular is >> non-DFSG-compliant), please do not repack upstre

Re: RFS: Pyspread 0.2.6-1

2014-03-08 Thread Andreas Noteng
On 07. mars 2014 02:52, Vincent Cheng wrote: If there aren't any non-DFSG-compliant files in upstream's tarball (and I see nothing that would suggest that this file in particular is non-DFSG-compliant), please do not repack upstream's tarball; it's simply not necessary at all. You can simply remo

Re: RFS: Pyspread 0.2.6-1

2014-03-06 Thread Vincent Cheng
On Mon, Mar 3, 2014 at 11:01 AM, Andreas Noteng wrote: > On 17. feb. 2014 21:57, Andreas Noteng wrote: >> >> Requesting a review and upload of Pyspread 0.2.6-1 available in the papt >> repo. >> Package is lintian clean, but I'm unsure if I did the DEP-8 implementation >> correctly or if it's at al

Re: RFS: Pyspread 0.2.6-1

2014-03-03 Thread Andreas Noteng
On 17. feb. 2014 21:57, Andreas Noteng wrote: Requesting a review and upload of Pyspread 0.2.6-1 available in the papt repo. Package is lintian clean, but I'm unsure if I did the DEP-8 implementation correctly or if it's at all possible. Running the tests manually works just fine but with adt-r

Re: RFS: Pyspread 0.2.6-1

2014-02-25 Thread Andreas Noteng
On 25. feb. 2014 10:53, Vincent Cheng wrote: With regards to pyspread...given the discussion above, I don't think ttf-mscorefonts-installer even belongs in suggests? End users are usually the only ones that care about suggested packages, and they're not the ones who are going to be creating or ru

Re: RFS: Pyspread 0.2.6-1

2014-02-25 Thread Vincent Cheng
On Fri, Feb 21, 2014 at 6:27 AM, Barry Warsaw wrote: > On Feb 21, 2014, at 01:59 PM, Dmitry Shachnev wrote: > >>On Wed, Feb 19, 2014 at 7:45 PM, Barry Warsaw wrote: >>> They don't run automatically during package build for either pbuilder or >>> sbuild afaik, although that would be really nice. >

Re: RFS: Pyspread 0.2.6-1

2014-02-21 Thread Barry Warsaw
On Feb 21, 2014, at 01:59 PM, Dmitry Shachnev wrote: >On Wed, Feb 19, 2014 at 7:45 PM, Barry Warsaw wrote: >> They don't run automatically during package build for either pbuilder or >> sbuild afaik, although that would be really nice. > >No. Autopkgtests are designed to test *installed* packages

Re: RFS: Pyspread 0.2.6-1

2014-02-21 Thread Dmitry Shachnev
Hi, On Wed, Feb 19, 2014 at 7:45 PM, Barry Warsaw wrote: > They don't run automatically during package build for either pbuilder or > sbuild afaik, although that would be really nice. No. Autopkgtests are designed to test *installed* packages, which is just not possible to do at build time (i.e.

Re: RFS: Pyspread 0.2.6-1

2014-02-19 Thread Dimitri John Ledkov
On 19 February 2014 15:45, Barry Warsaw wrote: > On Feb 18, 2014, at 09:10 PM, Vincent Cheng wrote: > >>I don't really know how autopkgtests work, but if they're run >>automatically during the build process like dh_auto_test, then that >>would cause your package to FTBFS. Can you modify the tests

Re: RFS: Pyspread 0.2.6-1

2014-02-19 Thread Barry Warsaw
On Feb 18, 2014, at 09:10 PM, Vincent Cheng wrote: >I don't really know how autopkgtests work, but if they're run >automatically during the build process like dh_auto_test, then that >would cause your package to FTBFS. Can you modify the tests so that >they work with other fonts, or disable the of

Re: RFS: Pyspread 0.2.6-1

2014-02-18 Thread Paul Wise
On Tue, Feb 18, 2014 at 7:48 PM, Andreas Noteng wrote: > Pyspread works just fine without ttf-mscorefonts-installer, so I guess > suggests would be a better choice anyway. The tests will fail without the > package though. Is it OK to include ttf-mscorefonts-installer as a test > dependency in debi

Re: RFS: Pyspread 0.2.6-1

2014-02-18 Thread Vincent Cheng
On Tue, Feb 18, 2014 at 3:48 AM, Andreas Noteng wrote: > On 17. feb. 2014 23:26, Vincent Cheng wrote: >> >> ...A package in main must not depend or recommend a non-main package >> (in this case, ttf-mscorefonts-installer, which is in contrib). Refer >> to Policy 2.2.1. > > Thanks. I knew depend wa

Re: RFS: Pyspread 0.2.6-1

2014-02-18 Thread Andreas Noteng
On 17. feb. 2014 23:26, Vincent Cheng wrote: ...A package in main must not depend or recommend a non-main package (in this case, ttf-mscorefonts-installer, which is in contrib). Refer to Policy 2.2.1. Thanks. I knew depend was not OK but believed recommends was. But, according to 2.2.1 suggests

Re: RFS: Pyspread 0.2.6-1

2014-02-17 Thread Vincent Cheng
On Mon, Feb 17, 2014 at 12:57 PM, Andreas Noteng wrote: > Requesting a review and upload of Pyspread 0.2.6-1 available in the papt > repo. > Package is lintian clean, but I'm unsure if I did the DEP-8 implementation > correctly or if it's at all possible. Running the tests manually works just > fi