Re: RFR: python-secretstorage

2012-06-26 Thread Dmitry Shachnev
Fixed, thanks for your review! -- Dmitry Shachnev On Mon, Jun 25, 2012 at 10:30 PM, Jakub Wilk wrote: > * Dmitry Shachnev , 2012-06-22, 11:47: > >> I am looking for a review of my package "python-secretstorage". > > DM-Upload-Allowed is supposed to be added by the sponsor, not by the DM. > > Lic

Re: RFR: python-secretstorage

2012-06-25 Thread Jakub Wilk
* Dmitry Shachnev , 2012-06-22, 11:47: I am looking for a review of my package "python-secretstorage". DM-Upload-Allowed is supposed to be added by the sponsor, not by the DM. Licence field in DEP-5 copyright file should use the same formatting rules as the Description field in debian/control

Re: RFR: python-secretstorage

2012-06-22 Thread Thomas Kluyver
On 22 June 2012 12:37, Simon McVittie wrote: > FYI this shouldn't be necessary on Linux if you're either under X or > running dbus-daemon manually, but it's still needed on kFreeBSD and > probably Hurd, even if you run dbus-daemon manually. The tests failed during an archive rebuild - that line w

Re: RFR: python-secretstorage

2012-06-22 Thread Simon McVittie
On 22/06/12 11:27, Thomas Kluyver wrote: > I recently did a wrapper for the dbus desktop notifications API > 5 # This is needed on buildd so that dbus can use ~/.dbus > 6 export HOME = $(CURDIR) FYI this shouldn't be necessary on Linux if you're either under X or running dbus-daemon manua

Re: RFR: python-secretstorage

2012-06-22 Thread Dmitry Shachnev
I was following your discussions about that, thanks! In my case it's more difficult: I need a running gnome-keyring-daemon with a configured default keyring. I'll try playing with xvfb later (when I have more time, and when I get async functions working). -- Dmitry Shachnev On Fri, Jun 22, 2012

Re: RFR: python-secretstorage

2012-06-22 Thread Thomas Kluyver
On 22 June 2012 08:47, Dmitry Shachnev wrote: > There is a small test script in the tarball (I plan to add "real" > unit-tests in the next releases), but it requires dbus and > gnome-keyring daemons running, so I don't think it's possible to run > it at the build time. I recently did a wrapper fo