Re: DEP-5: Files field and filename patterns

2010-09-13 Thread Lars Wirzenius
On ma, 2010-09-13 at 23:22 +0900, Charles Plessy wrote: > Le Mon, Sep 13, 2010 at 02:47:13PM +0100, Lars Wirzenius a écrit : > > > > That took more than a couple of days, but I've now merged the changes > > and pushed them out to the bzr trunk. > > Hi Lars, and bzr experts, > > I do not know wha

Re: DEP-5: Files field and filename patterns

2010-09-13 Thread Charles Plessy
Le Mon, Sep 13, 2010 at 02:47:13PM +0100, Lars Wirzenius a écrit : > > That took more than a couple of days, but I've now merged the changes > and pushed them out to the bzr trunk. Hi Lars, and bzr experts, I do not know what happened, but the dep bzr repository is not visible anymore through th

Re: DEP-5: Files field and filename patterns

2010-09-13 Thread Lars Wirzenius
On ti, 2010-09-07 at 06:24 +0100, Lars Wirzenius wrote: > Nobody has commented on this in any way, so I assume I am still perfect > and everything I say is flawless. I am attaching a proposed patch to > rewrite the filename pattern section. Unless there are objections within > a couple of days, I w

Re: DEP-5: Files field and filename patterns

2010-09-06 Thread Lars Wirzenius
On la, 2010-08-28 at 19:51 +1200, Lars Wirzenius wrote: > To make this go forward, I suggest that we adopt Charles's suggestion of > very simple globbing, since that's going to be compatible with more > powerful syntaxes if we want to adopt those later. Further, I suggest we > not treat the slash c

Re: DEP-5: Files field and filename patterns

2010-08-28 Thread Lars Wirzenius
On to, 2010-08-26 at 08:43 +1200, Lars Wirzenius wrote: > The Files field needs to specify patterns on filenames. We need to > specify how to do that. Here is my understanding of the current situation: * There is no particular consensus on filename patterns. * Charles suggests a very simple glob

Re: DEP-5: Files field and filename patterns

2010-08-26 Thread Lars Wirzenius
On to, 2010-08-26 at 17:31 +0200, gregor herrmann wrote: > On Thu, 26 Aug 2010 17:19:21 +0200, Jonas Smedegaard wrote: > > I discovered at some point that all entries need a trailing ./ - > > e.g. debian/control is not valid - it needs to be expressed > > ./debian/control > > Oops, that means that

Re: DEP-5: Files field and filename patterns

2010-08-26 Thread Russ Allbery
gregor herrmann writes: > On Thu, 26 Aug 2010 17:19:21 +0200, Jonas Smedegaard wrote: >> I discovered at some point that all entries need a trailing ./ - >> e.g. debian/control is not valid - it needs to be expressed >> ./debian/control > Oops, that means that probably (almost) all debian/copyri

Re: DEP-5: Files field and filename patterns

2010-08-26 Thread Russ Allbery
gregor herrmann writes: > When I look at gitignore(5) I find in the example: > # ignore objects and archives, anywhere in the tree. > *.[oa] > I don't think the "anywhere in the tree" part is desirable for > debian/copyright. If you want to express the license of the build system, an "anyw

Re: DEP-5: Files field and filename patterns

2010-08-26 Thread gregor herrmann
On Thu, 26 Aug 2010 17:19:21 +0200, Jonas Smedegaard wrote: > >I've fact I've written shell-style patterns free-handedly so far and > >hoped that they would also be valid for `find' :) > Did you actually test your expressions with "find -path"? No, that's what I meant with "hoped" :) > I discov

Re: DEP-5: Files field and filename patterns

2010-08-26 Thread Jonas Smedegaard
On Thu, Aug 26, 2010 at 04:59:24PM +0200, gregor herrmann wrote: On Thu, 26 Aug 2010 08:39:54 +0900, Charles Plessy wrote: > * Are find -name/-path globs a better idea than .gitignore? > * Are shell-style globs the right idea? Should we use Perl regular > expressions on the entire pathname inst

Re: DEP-5: Files field and filename patterns

2010-08-26 Thread gregor herrmann
On Thu, 26 Aug 2010 08:39:54 +0900, Charles Plessy wrote: > > * Are find -name/-path globs a better idea than .gitignore? > > * Are shell-style globs the right idea? Should we use Perl regular > > expressions on the entire pathname instead? > I think that we can, and should, keep the rest of the

Re: DEP-5: Files field and filename patterns

2010-08-25 Thread Lars Wirzenius
On to, 2010-08-26 at 08:39 +0900, Charles Plessy wrote: > Adding an exclusion syntax with ‘!’ has some use, but it would be to the > expense of being able to paste the field's value, and between the two I prefer > being able to paste. I, on the other hand, would prefer to have exclusion syntax, to

Re: DEP-5: Files field and filename patterns

2010-08-25 Thread Charles Plessy
Le Thu, Aug 26, 2010 at 08:43:41AM +1200, Lars Wirzenius a écrit : > > Some issues I would like to raise: > > * Is comma-separation appropriate? I'd prefer space-separation myself. > What do those who write parsers think? > > * Are find -name/-path globs a better idea than .gitignore? > > * .gi

DEP-5: Files field and filename patterns

2010-08-25 Thread Lars Wirzenius
The Files field needs to specify patterns on filenames. We need to specify how to do that. The spec draft currently has this text (plus some examples): ### Files Format The **`Files`** field contains a list of comma-separated patterns Files: f