Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Michel Dänzer
On Wed, 2004-11-03 at 18:18 -0500, Albert Cahalan wrote: > On Wed, 2004-11-03 at 17:24, Benjamin Herrenschmidt wrote: > > > Please point to the equally-optimized alternative > > > that works on all platforms. > > > > If there is none, then rip off the kernel implementation or lobby glibc > > to pr

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Albert Cahalan
On Wed, 2004-11-03 at 18:30, Christoph Hellwig wrote: > > What crap? You're the one who implied that these were > > somehow kernel headers. They're not. They come with > > the glibc-headers package. > > > > It really doesn't matter how this is fixed. It could be > > fixed in the glibc-headers pack

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Christoph Hellwig
> What crap? You're the one who implied that these were > somehow kernel headers. They're not. They come with > the glibc-headers package. > > It really doesn't matter how this is fixed. It could be > fixed in the glibc-headers package. Alternately, the > kernel source could be made more friendly

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Albert Cahalan
On Wed, 2004-11-03 at 17:24, Benjamin Herrenschmidt wrote: > > Please point to the equally-optimized alternative > > that works on all platforms. > > If there is none, then rip off the kernel implementation or lobby glibc > to provide one, or make a "libunaligned.so" and distribute it etc... > >

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Christoph Hellwig
> Stuff breaks, needlessly. I'd go so far as to say that > the Linux API has been broken on ppc. this is not a public API. An inline can't be a kernel API, everything that can be considered a kernel API is behind the syscall barrier.

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Christoph Hellwig
On Wed, Nov 03, 2004 at 09:56:18AM +0100, Christoph Ewering wrote: > Hello List, hello Klaus, hello Benjamin! > > At the moment I am fighting with an error on ppc when I want to compile > the new vdr-1.3.14 from Klaus Schmidinger. > > vdr uses unaligned.h and it stops compiling with an error ab

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Benjamin Herrenschmidt
> -- > Tab > > --- unaligned.h.orig 2004-11-03 18:37:24 +0100 > +++ unaligned.h 2004-11-03 18:37:29 +0100 > @@ -1,4 +1,3 @@ > -#ifdef __KERNEL__ > #ifndef __PPC_UNALIGNED_H > #define __PPC_UNALIGNED_H > > @@ -15,4 +14,3 @@ > #define put_unaligned(val, ptr) ((void)( *(ptr) = (val) ))

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Benjamin Herrenschmidt
> Please point to the equally-optimized alternative > that works on all platforms. If there is none, then rip off the kernel implementation or lobby glibc to provide one, or make a "libunaligned.so" and distribute it etc... but to NOT rely on the kernel header, that is bogus. > > At least on ar

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Benjamin Herrenschmidt
On Wed, 2004-11-03 at 09:56 +0100, Christoph Ewering wrote: > Hello List, hello Klaus, hello Benjamin! > > At the moment I am fighting with an error on ppc when I want to compile > the new vdr-1.3.14 from Klaus Schmidinger. > > vdr uses unaligned.h and it stops compiling with an error about >

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Vincent Hanquez
On Wed, Nov 03, 2004 at 08:17:56AM -0500, Albert Cahalan wrote: > If __ARMEB__ is not compiler-defined, something is > broken. I didn't know __ARMEB__ was set by compiler, I though it was kernel configuration stuff. anyway, that make the problem on ppc then. > Next time, start with i386. If Linu

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Albert Cahalan
On Wed, 2004-11-03 at 04:23, Vincent Hanquez wrote: > On Wed, Nov 03, 2004 at 09:56:18AM +0100, Christoph Ewering wrote: > > ppc. The asm-ppc/unaligned.h has two lines more - at the begining of > > unaligned.h "#ifdef __KERNEL__" and at the end "#endif /* KERNEL */". > > So I "greped" around in

Re: incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Vincent Hanquez
On Wed, Nov 03, 2004 at 09:56:18AM +0100, Christoph Ewering wrote: > Hello List, hello Klaus, hello Benjamin! > > At the moment I am fighting with an error on ppc when I want to compile > the new vdr-1.3.14 from Klaus Schmidinger. > > vdr uses unaligned.h and it stops compiling with an error ab

incompatible unaligned.h between x86 and ppc - kernel-hackers verify please

2004-11-03 Thread Christoph Ewering
Hello List, hello Klaus, hello Benjamin! At the moment I am fighting with an error on ppc when I want to compile the new vdr-1.3.14 from Klaus Schmidinger. vdr uses unaligned.h and it stops compiling with an error about "get_unaligned not declared" on ppc. I tracked this down with the help