Re: Sensors in adt746x

2004-10-31 Thread Colin Leroy
On 28 Oct 2004 at 15h10, Colin Leroy wrote: Hi, I sent this to Andrew Morton. This is the same as the last one, with a removed "if (var > 6)" which had not to be there. -- Colin "That's the difference between me and the rest of the world! Happiness isn't good enough for me! I demand euph

Re: Sensors in adt746x

2004-10-28 Thread Colin Leroy
On 28 Oct 2004 at 22h10, Colin Leroy wrote: Hi, > Thanks for your feedback. You're right, I missed these two points... Here's > an updated patch that should behave more logically (ie, starting when temp > == lim and stopping when temp < lim - 2), and removing the override case that > isn't neede

Re: Sensors in adt746x

2004-10-28 Thread Colin Leroy
On 28 Oct 2004 at 18h10, Georg C. Kaindl wrote: Hi, > But when watching the behaviour of the fan speed stepping code I noticed that > it happens quite often that when reducing the fan speed it will get set to > values < fan_speed because of (var > -2). I don't know wether this is > intended b

Re: Sensors in adt746x

2004-10-28 Thread Georg C. Kaindl
hi, I've tried your patch, but I can't comment on the changes syncing the fans because my powerbook just has one. But when watching the behaviour of the fan speed stepping code I noticed that it happens quite often that when reducing the fan speed it will get set to values < fan_speed because

Re: Sensors in adt746x

2004-10-28 Thread Colin Leroy
On 28 Oct 2004 at 15h10, Colin Leroy wrote: Hi, > Ok, looks like second sensor (temps[1]) is CPU on all ibooks and > powerbooks g4... whereas third sensor (temps[2]) is rather irrelevant > on powerbooks. Can you try this patch on a PB? it's against latest BK snapshot. You can apply these ones