Re: [PATCH] convert powermac ide blink to new led infrastructure

2006-04-30 Thread Benjamin Herrenschmidt
On Fri, 2006-04-28 at 17:15 +0200, Johannes Berg wrote: > [resent slightly different patch that adds a comment over the original > version] > > This patch removes the old pmac ide led blink code and > adds generic LED subsystem support for the LED. > > Ben: I removed the retry code that was prese

Re: [PATCH] convert powermac ide blink to new led infrastructure

2006-04-29 Thread Johannes Berg
On Fri, 2006-04-28 at 17:15 +0200, Johannes Berg wrote: > > +config ADB_PMU_LED > + bool "Support for the Power/iBook front LED" > + depends on LEDS_CLASS && ADB_PMU come to think of it, that should probably be depends on ADB_PMU select LEDS_CLASS since we should imho co

Re: [PATCH] convert powermac ide blink to new led infrastructure

2006-04-28 Thread Yves-Alexis Perez
On Fri, 2006-04-28 at 17:15 +0200, Johannes Berg wrote: > This patch removes the old pmac ide led blink code and > adds generic LED subsystem support for the LED. it works great here. does somebody know if it's it would be possible to have different brightness values assigned to the led (values

Re: [PATCH] convert powermac ide blink to new led infrastructure

2006-04-28 Thread Johannes Berg
[resent slightly different patch that adds a comment over the original version] This patch removes the old pmac ide led blink code and adds generic LED subsystem support for the LED. Ben: I removed the retry code that was present in the original. I guess LEDs aren't really too important but if it