Re: [linux-usb-devel] [PATCH] Re-power USB ports on wakeup

2005-03-16 Thread Jack Malmostoso
Ciao David Brownell, nel tuo messaggio dicevi: > This patch is self-evidently incorrect: So you suggest not to apply it? I mean, it can damage the hardware, or is it just "unclean"? Thank you. -- On Oct 5 1991, 8.53 AM; Linus Benedict Torvalds said: >I can (well, almost) hear you asking yourse

Re: [linux-usb-devel] [PATCH] Re-power USB ports on wakeup

2005-03-16 Thread Michael Schmitz
> > Seems something gets reset upon the first replugging after wakeup. Any > > idea what that might be? > > Not really. If i had an idea, I'd try to find a proper patch :) Maybe David or BenH have a hint or two. Michael -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "u

Re: [linux-usb-devel] [PATCH] Re-power USB ports on wakeup

2005-03-16 Thread Michael Schmitz
> > Doesn't work for me ... the device attached to the port is still > > powered down after wakeup. > > Yes, me too, but at least it's seen if you reconnect it. For me at > least ? Right, that works. I left the mouse connected ... Funny enough, now that I repeat the test it works even with the mou

Re: [linux-usb-devel] [PATCH] Re-power USB ports on wakeup

2005-03-16 Thread Colin Leroy
On 16 Mar 2005 at 15h03, Michael Schmitz wrote: Hi, > Seems something gets reset upon the first replugging after wakeup. Any > idea what that might be? Not really. If i had an idea, I'd try to find a proper patch :) > Besides, I didn't apply that patch on top of your first one, rather > used p

Re: [linux-usb-devel] [PATCH] Re-power USB ports on wakeup

2005-03-16 Thread Michael Schmitz
> Another idea. Is it harmful to "re-power" already powered ports? For > example like this: > > Signed-off-by: Colin Leroy <[EMAIL PROTECTED]> > --- a/drivers/usb/host/ehci-hcd.c 2005-03-15 17:28:52.0 +0100 > +++ b/drivers/usb/host/ehci-hcd.c 2005-03-16 14:44:06.0 +0100 > @@

Re: [linux-usb-devel] [PATCH] Re-power USB ports on wakeup

2005-03-16 Thread Colin Leroy
On 16 Mar 2005 at 15h03, Michael Schmitz wrote: Hi, > Doesn't work for me ... the device attached to the port is still > powered down after wakeup. Yes, me too, but at least it's seen if you reconnect it. For me at least ? -- Colin -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subj

Re: [linux-usb-devel] [PATCH] Re-power USB ports on wakeup

2005-03-16 Thread Colin Leroy
On 15 Mar 2005 at 17h03, David Brownell wrote: Hi, > This patch is self-evidently incorrect: by definition, a suspended > port maintains VBUS power. Otherwise the device connected to the > port will get disconnected, rather than suspended ... and it won't > be able to issue wakeup events. All

Re: [linux-usb-devel] [PATCH] Re-power USB ports on wakeup

2005-03-15 Thread David Brownell
On Tuesday 15 March 2005 8:34 am, Colin Leroy wrote: > Hi list, > > Most of us have problems with USB unresponsive after one out of two > wakeups. This patch fixes it for me; it looks like the port status > isn't automatically updated (to ~PORT_POWER) when sleeping... > > So this patch just unpow