Re: [PATCH linux-next v3 05/14] crash: clean up kdump related config items

2024-08-23 Thread Dave Vasilevsky
On 2024-08-23 07:58, Dave Vasilevsky wrote: > On 2024-08-23 03:16, John Paul Adrian Glaubitz wrote: >> It should be disabled on m68k and sh by default as well. > > Sure, I can change that. What's the reasoning, so I can explain in my commit > message? Oh I don't think m68k even has ARCH_SUPPORTS

Re: [PATCH linux-next v3 05/14] crash: clean up kdump related config items

2024-08-23 Thread Dave Vasilevsky
On 2024-08-23 03:16, John Paul Adrian Glaubitz wrote: > It should be disabled on m68k and sh by default as well. Sure, I can change that. What's the reasoning, so I can explain in my commit message? -Dave

Re: [PATCH linux-next v3 05/14] crash: clean up kdump related config items

2024-08-23 Thread John Paul Adrian Glaubitz
On Thu, 2024-08-22 at 20:41 -0400, Dave Vasilevsky wrote: > From d6e5fe3a45f46f1aa01914648c443291d956de9e Mon Sep 17 00:00:00 2001 > From: Dave Vasilevsky > Date: Thu, 22 Aug 2024 20:13:46 -0400 > Subject: [PATCH] powerpc: Default to CRASH_DUMP=n when Open Firmware boot is > likely > MIME-Version

Re: [PATCH linux-next v3 05/14] crash: clean up kdump related config items

2024-08-22 Thread Dave Vasilevsky
On 2024-08-22 20:04, Baoquan He wrote: > If so, below patch possiblly can fix it. Can you help check if it's OK? That removes the possibility of enabling CRASH_DUMP on PPC_BOOK3S_32, even when booting via other mechanisms. Maybe it would be best to just make it not-default? Please take a look at

Re: [PATCH linux-next v3 05/14] crash: clean up kdump related config items

2024-08-22 Thread John Paul Adrian Glaubitz
Hi Baoquan, On Thu, 2024-08-22 at 17:17 +0800, Baoquan He wrote: > > The change to enable CONFIG_CRASH_DUMP by default apparently broke the boot > > on 32-bit Power Macintosh systems which fail after GRUB with: > > > > "Error: You can't boot a kdump kernel from OF!" > > > > We may have to tu

Re: [PATCH linux-next v3 05/14] crash: clean up kdump related config items

2024-08-22 Thread John Paul Adrian Glaubitz
Hi Baoquan, On Wed, 2024-01-24 at 13:12 +0800, Baoquan He wrote: > By splitting CRASH_RESERVE and VMCORE_INFO out from CRASH_CORE, cleaning > up the dependency of FA_DMUMP on CRASH_DUMP, and moving crash codes from > kexec_core.c to crash_core.c, now we can rearrange CRASH_DUMP to > depend on KEXE