Re: [PATCH] Latest patch to therm_adt7467

2004-01-27 Thread Colin Leroy
I commentd out this line (I have an 7460 chipset) and everything works great (fan starts at 60 and stops at 57). I am missing something? + th->limits[i] = default_limits7467[i] - limit_decrease; You'll probably have the machine poweroff at about 62/63°. Anyway, the latest patch is no more this

Re: [PATCH] Latest patch to therm_adt7467

2004-01-27 Thread Federico Gamio
I have a question, in the following part of the patch code, you set the limits, and you take care if you have 7460 or 7467. My question is, is correct the last asignation (below write)? I think you have to make an "if" (like a couples of lines before) to set the correct values for 7467 or 7460, if

Re: [PATCH] Latest patch to therm_adt7467

2004-01-24 Thread Benjamin Herrenschmidt
> PowerBook5,1 : not in file > PowerBook5,2 : starts at 45°C > PowerBook5,3 : starts at 45°C > PowerBook6,1 : not in file > PowerBook6,2 : starts at 51°C > PowerBook6,3 : not in file > > I took the lowest values, some are higher for different sensors, but I don't > know > which is which... Not

Re: [PATCH] Latest patch to therm_adt7467

2004-01-24 Thread Benjamin Herrenschmidt
On Sat, 2004-01-24 at 23:04, Colin Leroy wrote: > On 24 Jan 2004 at 23h01, Benjamin Herrenschmidt wrote: > > Hi, > > > I mean, deduce it from the source code ... > > oh, ok. Do you have an idea about which source package I should look at ? The limits for the various thermal states are in Apple

Re: [PATCH] Latest patch to therm_adt7467

2004-01-24 Thread Colin Leroy
On 24 Jan 2004 at 13h01, Colin Leroy wrote: Hi, > > I mean, deduce it from the source code ... > > oh, ok. Do you have an idea about which source package I should look at ? I already had found them, in AppleMacRISC2PE-142.2.3/Portable2003_PlatformMonitor.cpp. PowerBook5,1 : not in file Power

Re: [PATCH] Latest patch to therm_adt7467

2004-01-24 Thread Colin Leroy
On 24 Jan 2004 at 23h01, Benjamin Herrenschmidt wrote: Hi, > I mean, deduce it from the source code ... oh, ok. Do you have an idea about which source package I should look at ? -- Colin

Re: [PATCH] Latest patch to therm_adt7467

2004-01-24 Thread Benjamin Herrenschmidt
On Sat, 2004-01-24 at 22:39, Colin Leroy wrote: > On 24 Jan 2004 at 22h01, Benjamin Herrenschmidt wrote: > > Hi, > > > > Yuck. My iBook just powered off. Probably did not happen before because I > > > was > > > in colder environments... This new patch sets limits higher on iBook too, > > > and

Re: [PATCH] Latest patch to therm_adt7467

2004-01-24 Thread Colin Leroy
On 24 Jan 2004 at 22h01, Benjamin Herrenschmidt wrote: Hi, > > Yuck. My iBook just powered off. Probably did not happen before because I > > was > > in colder environments... This new patch sets limits higher on iBook too, > > and > > obsolotes the previous one. > > Can you figure out precis

Re: [PATCH] Latest patch to therm_adt7467

2004-01-24 Thread Benjamin Herrenschmidt
> Yuck. My iBook just powered off. Probably did not happen before because I was > in colder environments... This new patch sets limits higher on iBook too, and > obsolotes the previous one. Can you figure out precisely what Darwin is doing and reproduce the behaviour instead ? Ben.

Re: [PATCH] Latest patch to therm_adt7467

2004-01-24 Thread Colin Leroy
On 24 Jan 2004 at 10h01, Colin Leroy wrote: Hi, > . limits are set quite high on the ADT7460 chip, but the fan starts much > below these limits (in order to avoid poweroffs). Yuck. My iBook just powered off. Probably did not happen before because I was in colder environments... This new patc

[PATCH] Latest patch to therm_adt7467

2004-01-24 Thread Colin Leroy
Hi, Ok, here's the latest patch for therm_adt7467, based on the feedback provided by our generous testers :-) What is done now: . fan_speed defaults to 128 (for both chips), allowing the fan to start more quietly. The chip is still put back to automatic mode when we rmmod the module. . limi