Re: Fix multiple compiler warnings when building with gcc-12

2023-01-17 Thread Tyrel Datwyler
On 1/5/23 13:07, John Paul Adrian Glaubitz wrote: > Hi Tyrel! > > On 1/5/23 21:58, Tyrel Datwyler wrote: >> On 12/26/22 01:54, John Paul Adrian Glaubitz wrote: >>> This patch series fixes a number of warnings when building powerpc-utils >>> with gcc-12 or new

Re: Fix multiple compiler warnings when building with gcc-12

2023-01-05 Thread Tyrel Datwyler
On 12/26/22 01:54, John Paul Adrian Glaubitz wrote: > This patch series fixes a number of warnings when building powerpc-utils > with gcc-12 or newer. Since the project builds with "-Werror" by default, > these warnings will cause the build to fail. > > With these patches applied, all warnings are

Re: Fix multiple compiler warnings when building with gcc-12

2023-01-04 Thread Tyrel Datwyler
On 12/26/22 01:54, John Paul Adrian Glaubitz wrote: > This patch series fixes a number of warnings when building powerpc-utils > with gcc-12 or newer. Since the project builds with "-Werror" by default, > these warnings will cause the build to fail. > > With these patches applied, all warnings are

Re: Fix multiple compiler warnings when building with gcc-12

2023-01-04 Thread Tyrel Datwyler
On 1/4/23 08:52, Nathan Lynch wrote: > John Paul Adrian Glaubitz writes: > >> Ping. Any chance we can get these small fixes merged for the next >> branch? > > Tyrel, I think these all look good. Thanks Adrian. > > We should really remove the -Werror from the default build flags, and > instead u

Re: [PATCH] ofpathname: Add missing substring extraction of devpart in l2of_vd()

2021-05-21 Thread Tyrel Datwyler
On 4/18/21 1:05 AM, John Paul Adrian Glaubitz wrote: > l2of_vd() contains the necessary bits to append the partition number > to the resulting OFPATH, but it does not actually extract the partition > number from the logical device path in the first place. This adds the > missing substring extractio

Re: [PATCH, v2] ofpathname: Move definition of SYS_PATH from l2of_vs() to l2of_scsi()

2021-03-29 Thread Tyrel Datwyler
On 2/8/21 4:10 PM, John Paul Adrian Glaubitz wrote: > SYS_PATH, which is required to calculate the plug ID of a SCSI/SATA > host in l2of_scsi(), is actually never set in this function but in > l2of_vd() where it is not used at all. Thus, move the definition of > SYS_PATH from l2of_vd() to l2of_scsi

Re: [PATCH 1/3] ofpathname: Add partition support to l2of_ide() and l2of_scsi()

2020-06-23 Thread Tyrel Datwyler
On 6/22/20 10:43 PM, John Paul Adrian Glaubitz wrote: > Hi! > > On 6/23/20 3:32 AM, Tyrel Datwyler wrote: >> Heads up this may be problematic for pseries lpars. The current behavior is >> that >> regardless of the scsi partition the logical device always translates to

Re: [PATCH 1/3] ofpathname: Add partition support to l2of_ide() and l2of_scsi()

2020-06-22 Thread Tyrel Datwyler
On 4/19/20 2:35 AM, John Paul Adrian Glaubitz wrote: > Currently, only l2of_nvme() supports handling of partitions which > will print the partition number at the end of an OF path. However, > this feature is also useful for IDE and SCSI targets as well and > mandatory for Macintosh systems. > > Si

Re: [PATCH 3/3] ofpathname: Add support for Mac-compatible OF pathnames

2020-06-09 Thread Tyrel Datwyler
On 4/19/20 2:35 AM, John Paul Adrian Glaubitz wrote: > On Macintosh systems, OpenFirmware path follow a slightly > different syntax as compared to other OF systems. In particular, > the disk ID is not preceeded by the string "disk" and - on > SATA systems - the path does not contain the BUS ID as >

Re: Ping: Re: [PATCH]: Add support for Apple Power Mac

2020-06-08 Thread Tyrel Datwyler
On 6/5/20 7:15 AM, Nathan Lynch wrote: > John Paul Adrian Glaubitz writes: >> Hi! >> >> On 5/17/20 12:33 PM, John Paul Adrian Glaubitz wrote: >>> On 4/19/20 11:35 AM, John Paul Adrian Glaubitz wrote: The following three patches are required to get ofpathname to return proper OF paths on