Re: Environment variables, debian/rules and dpkg-buildpackage

2009-05-04 Thread Manoj Srivastava
On Mon, May 04 2009, Guillem Jover wrote: > I'll try to summarize the discussion (althought it might be biased to > my preferred option) and some facts, so that we can get to a conclusion: +1 I agree with almost everything said in this email. manoj -- What use is your matted ha

Re: Environment variables, debian/rules and dpkg-buildpackage

2009-05-04 Thread Andrew McMillan
On Mon, 2009-05-04 at 07:35 +0200, Guillem Jover wrote: > > On Fri, 2009-03-13 at 21:04:30 +0100, Raphael Hertzog wrote: > > we have an unfortunate situation where the practice in dpkg-buildpackage > > and the policy do not match fully. ... > So I think for next dpkg upload we should make dpkg-

Re: Environment variables, debian/rules and dpkg-buildpackage

2009-05-04 Thread Bernd Zeimetz
Guillem Jover wrote: > [ BCCed debian-dpkg for the proposed dpkg changes. ] > * Lots of packages (roughly around 4k) do not honour env vars for build > flags, as they follow the examples from policy (or dh-make and similar) > and thus are setting them unconditionally, which env vars do not >

Re: Environment variables, debian/rules and dpkg-buildpackage

2009-05-04 Thread Raphael Hertzog
On Mon, 04 May 2009, Guillem Jover wrote: > env var should not be set either, and we should work on getting a > dpkg-vendor instead, before people try to start using the variable. FYI, I already started this. > start fixing packages to include that makefile. The files could look > something like:

Re: Environment variables, debian/rules and dpkg-buildpackage

2009-05-04 Thread Manoj Srivastava
On Mon, May 04 2009, Raphael Hertzog wrote: > On Mon, 04 May 2009, Guillem Jover wrote: >> ,-- debian/rules >> -include /usr/share/dpkg/build-options.mk >> >> # package overrides >> FOO := pkg >> `-- > > Probably without the leading "-", otherwise we have a risk to not have > any sane default at

Bug#206684: missed one legacy sentence...

2009-05-04 Thread Russ Allbery
Holger Levsen writes: > it seems we missed on legacy advice in the fix #206684: > > See > http://www.debian.org/doc/debian-policy/ch-binary.html#s-maintscripts > and there the last but one paragraph of 3.9.1, which #206684 does not > suggest to change: > > --quote- > If a package has a vital

Bug#206684: missed one legacy sentence...

2009-05-04 Thread Holger Levsen
Hi Russ, On Montag, 4. Mai 2009, Russ Allbery wrote: > How about: > it should display this in the config or postinst script and prompt > the user for acknowledgement. See . Great! > We don't require that the program use debconf, only that it use > something that complies with the Debian

Re: Environment variables, debian/rules and dpkg-buildpackage

2009-05-04 Thread Peter Eisentraut
On Monday 04 May 2009 08:35:18 Guillem Jover wrote: I like this proposal. A small nit: > ,-- /usr/share/dpkg/build-options.mk > # distro defaults > FOO := distro Please be sure to use FOO = bar instead of ":=", unless you have determined that you really wanted ":=". In most cases it won't m