Bug#988010: RFS: td-system-tools/2.0.0-1 [ITP] -- System

2024-10-11 Thread Phil Wyett
Control: tags -1 -moreinfo Control: tags -1 +confirmed Thomas, Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improv

Bug#1084915: RFS: python-nextdns/3.3.0-1 [ITP] -- Python wrapper for NextDNS API

2024-10-11 Thread Jeroen Ploemen
Control: tags -1 moreinfo On Fri, 11 Oct 2024 10:03:44 +0530 Sourav Bhattacharya wrote: > I am looking for a sponsor for my package python-nextdns: hi again Sourav, nice to see the improvements made since yesterday's review. Couple of issues remaining before I can upload the package: * contro

Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting

2024-10-11 Thread Joost van Baal-Ilić
Package: sponsorship-requests Severity: normal Hi, My PGP key expired, I've extended it and uploaded the extended key to hkp://keyring.debian.org . However, it seems this change did not yet trickle down to our incoming machinery. I would be grateful if anybody could sponsor my latest work on my

Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting

2024-10-11 Thread Phil Wyett
Control: tags -1 +moreinfo Hi Joost, MAny thanks for your contribution to Debian. I will not perform full review at this time, the package fails to build, see output below. dpkg-source -b . dpkg-source: info: using source format '3.0 (quilt)' dpkg-source: info: verifying ./caspar_20240818.ori

Bug#1084915: RFS: python-nextdns/3.3.0-1 [ITP] -- Python wrapper for NextDNS API

2024-10-11 Thread souravbhattacharya
Hello Jeroen, I am aware of the issue related to the CI failure. Tests runs fine on my pc, also the nextdns module is imported without any errors when tested locally.  The error is most likely due to the absence of tenacity in the host itself. Let me know your thoughts on it. Thanks, Sourav

Re: Bug#1084915: RFS: python-nextdns/3.3.0-1 [ITP] -- Python wrapper for NextDNS API

2024-10-11 Thread Andrey Rakhmatullin
On Fri, Oct 11, 2024 at 02:36:54PM +0200, souravbhattacha...@tutamail.com wrote: > I am aware of the issue related to the CI failure. Tests runs fine on my > pc, Then you aren't testing in a minimal environment. > The error is most likely due to the absence of tenacity in the > host itself. Sure

Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting

2024-10-11 Thread Joost van Baal-Ilić
Hi again, Now dget -x http://mdcc.cx/tmp/caspar/caspar_20240818-2.dsc should get you a fixed caspar source package. The file caspar_20240818-2_source.changes refers to both -2 and the upstream .orig.tar.xz sources: i ran "debuild -S -sa". Could you please have a look at this? Thanks again,

Bug#1084915: RFS: python-nextdns/3.3.0-1 [ITP] -- Python wrapper for NextDNS API

2024-10-11 Thread Soren Stoutner
On Friday, October 11, 2024 8:27:48 AM MST souravbhattacha...@tutamail.com wrote: > #!/usr/bin/make -f > export PYBUILD_NAME=python > > %: > dh $@ --buildsystem=pybuild Typically it should be: #!/usr/bin/make -f export PYBUILD_NAME=nextdns %: dh $@ --buildsystem=pybuild My understanding is th

Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting

2024-10-11 Thread Joost van Baal-Ilić
Hi Phil, Thanks a lot for this review. I know how to fix the problem, will do another release soonish. Bye, Joost On Fri, Oct 11, 2024 at 11:48:00AM +0100, Phil Wyett wrote: > Control: tags -1 +moreinfo > > Hi Joost, > > MAny thanks for your contribution to Debian. > > I will not perform

Bug#1084800: RFS for nxt-python (Was: Re: Bug#1080316: RFS: nxt-firmware/1.29.7-1 -- Improved firmware for LEGO Mindstorms NXT bricks)

2024-10-11 Thread Nicolas Schodet
* Soren Stoutner [2024-10-09 20:57]: > I believe a bunch of these were answered by Jeroen, but I will answer them as > well in care you still have any questions. > > About bugs #885467, #937175 and #773201: they were closed when the > > package was removed, should I re-open them before the uploa

Bug#1084915: RFS: python-nextdns/3.3.0-1 [ITP] -- Python wrapper for NextDNS API

2024-10-11 Thread souravbhattacharya
Greetings Jeroen, Please ignore my previous reply. I have applied a patch to setup.py and now the pipeline runs without fail. I'll file a bug or a pull request for the same as well. I thought it was a pipeline configuration mistake because there were no issues testing the package locally, of co

Bug#1084915: RFS: python-nextdns/3.3.0-1 [ITP] -- Python wrapper for NextDNS API

2024-10-11 Thread souravbhattacharya
Sorry a small typo in the code. I meant "Are you saying it should be: --- #!/usr/bin/make -f export PYBUILD_NAME=nextdns %: dh $@ --buildsystem=pybuild ---   instead of: --- #!/usr/bin/make -f export PYBUILD_NAME=python-nextdns %: dh $@ --buildsystem=pybuild ---" Regards, Sourav Oct 11,

Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting

2024-10-11 Thread Joost van Baal-Ilić
Hi Phil e.a., On Fri, Oct 11, 2024 at 03:57:10PM +0100, Phil Wyett wrote: > On Fri, 2024-10-11 at 16:30 +0200, Joost van Baal-Ilić wrote: > > > > Now > > > > dget -x http://mdcc.cx/tmp/caspar/caspar_20240818-2.dsc > > > > should get you a fixed caspar source package. The file > > caspar_2024

Bug#1084800: RFS for nxt-python (Was: Re: Bug#1080316: RFS: nxt-firmware/1.29.7-1 -- Improved firmware for LEGO Mindstorms NXT bricks)

2024-10-11 Thread Soren Stoutner
Nicolas, On Friday, October 11, 2024 6:04:09 AM MST Nicolas Schodet wrote: > > > About lintian report, I would like to have some advice on how to handle > > > it rather than going directly with an override: > > > > > > I: nxt-python source: built-using-field-on-arch-all-package (in section > > >

Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting

2024-10-11 Thread Phil Wyett
Joost, Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debia

Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting

2024-10-11 Thread Joost van Baal-Ilić
Hi again Phil, tl;dr: fixed some stuff, will publish a new caspar/20240818-1 likely today. On Sat, Oct 12, 2024 at 08:01:24AM +0200, Joost van Baal-Ilić wrote: > > Thanks a lot for this awesome analysis. I'll prepare another > caspar/20240818-1, likely today. (It'll likely feature some linti

Bug#1084915: RFS: python-nextdns/3.3.0-1 [ITP] -- Python wrapper for NextDNS API

2024-10-11 Thread souravbhattacharya
Control: tags -1 - moreinfo Update: I have updated PYBUILD_NAME to nextdns as suggested by Soren and Jeroen. Thank you for your reviews and suggestions. Regards, Sourav Oct 11, 2024, 22:27 by so...@debian.org: > > On Friday, October 11, 2024 8:27:48 AM MST souravbhattacha...@tutamail.com > w

Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting

2024-10-11 Thread Joost van Baal-Ilić
Hi again Phil, Thanks a lot for this awesome analysis. I'll prepare another caspar/20240818-1, likely today. (It'll likely feature some lintian overrides, next to some "real" fixes.) BTW, you do not check on the results of "make clean", do you? There was some discussion a couple of months ago

Bug#1084920: RFS: caspar/20240818-1 -- Makefile snippets for centralized configuration management and typesetting

2024-10-11 Thread Phil Wyett
On Fri, 2024-10-11 at 16:30 +0200, Joost van Baal-Ilić wrote: > Hi again, > > Now > > dget -x http://mdcc.cx/tmp/caspar/caspar_20240818-2.dsc > > should get you a fixed caspar source package. The file > caspar_20240818-2_source.changes refers to both -2 and the upstream > .orig.tar.xz sources