Bug#706361: closed by Dmitry Smirnov (Re: Bug#706361: gti review)

2013-05-26 Thread Felix Crux
On Fri, May 24 11:15, Debian Bug Tracking System wrote: > ... snip ... > From: Dmitry Smirnov > To: 706361-d...@bugs.debian.org > Subject: Re: Bug#706361: gti review > ... snip ... > Well done Felix, I just uploaded it with one minor correction to short > package description

Bug#706361: gti review

2013-05-24 Thread Felix Crux
Thanks again for another round of review! I think I've addressed all the comments now, and have uploaded a new version. Note that the version number changed again, since upstream merged the patch that I forwarded. The package is now available from http://mentors.debian.net/debian/pool/main/g/gti

Bug#706361: gti review

2013-05-23 Thread Dmitry Smirnov
Hello Felix, Thank you for your corrections. We're almost there, but I hope that few more pedantic issues could be fixed... :) > I take it it is not customary to provide overrides for "pedantic" > warnings? You can do it and on some occasions I overridden some pedantic warnings to acknowledge t

Re: Bug#706361: gti review

2013-05-13 Thread Felix Crux
Hello, Thank you very much for the detailed review of the package. I've taken some time to address your feedback, as well as share some improvements upstream. You can get the latest version of the package with dget -x http://mentors.debian.net/debian/pool/main/g/gti/gti_1.1.0-1.dsc (note the ve

Re: Bug#706361: gti review

2013-05-01 Thread Dmitry Smirnov
On Wed, 1 May 2013 18:42:19 Charles Plessy wrote: > to be comprehensive, there are also the Software Package Data Exchange > project and the Open Source Initiative which both agree on a reference > MIT license: > > http://opensource.org/licenses/MIT > http://spdx.org/licenses/MIT > > So i

Bug#706361: gti review

2013-05-01 Thread Charles Plessy
Le Wed, May 01, 2013 at 05:37:50PM +1000, Dmitry Smirnov a écrit : > > ## debian/copyright > > License name "MIT" is incorrect even though upstream may refer to this > license as such. "MIT" is considered ambiguous by the Free Software > Foundation. copyright-format-1.0 specification recommends t

Bug#706361: gti review

2013-05-01 Thread Dmitry Smirnov
Dear Felix, Thanks for packaging this funny software. :) Isn't the animation is a little too fast? I can hardly recognise the animated car and it's certainly moves faster than animated train in `sl`. I had a look at your package and I'd like to share some suggestions with you: There is unnecess