Hi,
thanks for your contribution, this should be in unstable by tonight.
cheers,
Hugo
--
Hugo Lefeuvre (hle)|www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C
signature.asc
Description
once ftpmasters have accepted the package.
cheers,
Hugo
--
Hugo Lefeuvre (hle)|www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C
signature.asc
Description: PGP signature
/debian-devel-announce/2019/07/msg2.html
Seems like I overlooked this. I'll prepare a small source only upload this
week so we get these changes into testing. If you want to add some more
changes from your side, just commit them on Salsa, I'll take a look at
them.
cheers,
Hugo
--
so I went along and uploaded it.
I'm not using it myself, so if you could test it a bit more in the next
days, that would be great. If there are other issues to fix I will have
time to take care of it during DebConf.
Thanks for your work.
cheers,
Hugo
--
Hi Juhani,
Thanks for working on this. I'll review your changes and upload asap.
cheers,
Hugo
--
Hugo Lefeuvre (hle)|www.owl.eu.com
RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C
signatur
ave to increase the
version as usual and mention "Upload to unstable." in the changelog.
> * Is there a procedure to join (or apply for joining) the
> pkg-security-team? I did not find any information regarding that
> online.
I am not admin, but I think Gianfranco can add you
> - $(INSTALL) -m 555 -o bin -g bin arpwatch $(DESTDIR)$(BINDEST)
> + $(INSTALL) -Dm 555 -o bin -g bin arpwatch $(DESTDIR)$(BINDEST)
>
>
> this should work too (as said above) and is less invasive :)
Oh right, thanks :)
--
Hugo Lefeuvre (hle)|
uot; && $(INSTALL) -m 555 -o bin -g bin arpwatch
$(DESTDIR)$(BINDEST)
$(INSTALL) -m 555 -o bin -g bin arpsnmp $(DESTDIR)$(BINDEST)
install-man: force
Cheers,
Hugo
[0] https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#rules
--
Hugo Lefeuvre (hle)|
r).
Indeed, this is kind of useless if they don't appear in the binary/users
don't see it.
> The spelling mistake in debian/changelog is from an old entry. Should I
> rewrite the changelog.Debian history to fix that spelling mistake?
I wouldn't do it.
> Thanks also for inclu
8859-1
ethercodes.dat:785: Intruments ==> Instruments
ethercodes.dat:838: Aircaft ==> Aircraft
ethercodes.dat:1180: Engeneering ==> Engineering
ethercodes.dat:2083: Internation ==> International
ethercodes.dat:7447: MANAGMENT ==> MANAGEMENT
Otherwise, the package looks good. I did not review everything yet,
I'll take a second look later. :)
Cheers,
Hugo
--
Hugo Lefeuvre (hle)|www.owl.eu.com
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
signature.asc
Description: PGP signature
might also decide to upload it.
Of course, don't hesitate to ping me if you need some quick review, I'm
not far away. :-)
Regards,
Hugo
[0] https://pkg-go.alioth.debian.org/
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 0
expected
> problems. If you don't think that is beneficial I can remove it.
Anyway, I'm nitpicking. Let it if you want.
I've made a new review of your package and I've found a last problem
in your d/copyright file: The Expat license paragraph is malformed.
I've
pyright
field of d/copyright, like so:
Files: debian/*
Copyright: 2015 Stephen Gelman
License: Expat
Thanks !
Regards,
Hugo
[0] http://backports.debian.org/Contribute/
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 A
some spelling errors in the source code. You
should consider fixing them:
./lfs/transfer_queue.go:81: occured ==> occurred
./lfs/transfer_queue.go:154: transfered ==> transferred
./vendor/_nuts/github.com/spf13/cobra/README.md:65: libary ==> library
./vendor/_nuts/github.com/ogier/pflag/
ort.cgi?bug=791380
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
signature.asc
Description: Digital signature
.1:
- Deleted the paragraph about 'info qtop' which was useless.
* d/patches/name.patch:
- Added Top.desktop to the patch.
* d/copyright:
- Changed upstream license from GPL-2 to GPL-2+.
Regards,
Hugo
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.o
an
errors/warnings clear and compiles fine on my computer. :)
The package is available at the same adress.[0]
Regards,
Hugo
[0] https://mentors.debian.net/package/qtop
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
sig
Hi,
I'm actually speaking with the Upstream to find a good name for this
package. It will maybe change again.
Regards,
Hugo
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
signature.asc
Description: Digital signature
bian.net/package/qtop
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
signature.asc
Description: Digital signature
sponsorship, but the name of the package was
buggy. I've also made a patch to change the name of the software from
'Top' to 'qtop'.
qtop (2.2.3-2) unstable; urgency=low
* debian/patches/name.patch:
- Changes the name of the binary from Top to qtop.
I'll fill a new RFS for the qtop package.
Regards,
Hugo
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
signature.asc
Description: Digital signature
It should be done now. The new name of the binary is qtop.
I've uploaded the package on mentos.debian.org.[0]
Regards,
Hugo
[0] https://mentors.debian.net/package/qtop
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524
did sound like a good suggestion.
I'll do the changes in the evening. ;)
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
signature.asc
Description: Digital signature
t, if you think it's buggy, I'll change it. Naturally, I can also try
to speak with the Upstream to change the name of the source program but
I think it will be... very long. :)
Regards,
Hugo
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533
e.
top (2.2.3-1) unstable; urgency=low
* Initial release (Closes: #731881)
-- Hugo Lefeuvre Sun, 18 May 2014 17:23:10 +0200
Regards,
Hugo
--
Hugo Lefeuvre (hugo6390)|www.hugo6390.org
4096/ ACB7 B67F 197F 9B32 1533 431C AC90 AC3E C524 065E
25 matches
Mail list logo
