Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-31 Thread Andreas Tille
On Tue, Mar 31, 2015 at 01:05:01PM +0200, Roland Fehrenbacher wrote: > > just pushed 2.1.8-1. Just uploaded. Please note that I deleted your tag debian/2.1.8-1 since it was pointing to "UNRELEASED" and have set it to the upload to experimental. Thanks for your work on this Andreas. --

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-31 Thread Roland Fehrenbacher
> "A" == Andreas Tille writes: Hi Andreas, Charles, A> On Sun, Mar 29, 2015 at 09:46:06AM +0900, Charles Plessy wrote: >> Le Sun, Mar 29, 2015 at 12:12:23AM +0100, Andreas Tille a écrit : >> > >> > I personally would consider a 2.1.8 backport to all relevant >> > releases

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-28 Thread Andreas Tille
On Sun, Mar 29, 2015 at 09:46:06AM +0900, Charles Plessy wrote: > Le Sun, Mar 29, 2015 at 12:12:23AM +0100, Andreas Tille a écrit : > > > > I personally would consider a 2.1.8 backport to all relevant releases > > more usefull than spending time on old versions? Am I missing something? > > Hi An

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-28 Thread Charles Plessy
Le Sun, Mar 29, 2015 at 12:12:23AM +0100, Andreas Tille a écrit : > > I personally would consider a 2.1.8 backport to all relevant releases > more usefull than spending time on old versions? Am I missing something? Hi Andreas, in that case we need to decide whether removing version 2.1.4 from W

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-28 Thread Andreas Tille
On Sat, Mar 28, 2015 at 07:19:18PM +0100, Roland Fehrenbacher wrote: > C> Actually, I have been a bit confusing: I did not mean uploading > C> version 2.1.7-2 to Wheezy, but to apply the patches to 2.1.4-1 as > C> a Stable update if it makes sense. > > Ah, OK. There would be 2 problems

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-28 Thread Roland Fehrenbacher
> "A" == Andreas Tille writes: Hi Andreas, A> Hi Roland, On Fri, Mar 27, 2015 at 11:01:29AM +0100, Roland A> Fehrenbacher wrote: C> commit 5788cecbb05a4394c3fed722c47bdba5c20432ef Author: C> tbooth-guest Date: Tue Feb 25 13:43:34 C> 2014 + >> C> Fixed package

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-28 Thread Roland Fehrenbacher
> "C" == Charles Plessy writes: C> Le Fri, Mar 27, 2015 at 02:10:38PM +0100, Andreas Tille a écrit : >> On Fri, Mar 27, 2015 at 11:01:29AM +0100, Roland Fehrenbacher >> wrote: >> >> > C> Do you think it would be possible to backport the change >> > C> for Wheez

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-27 Thread Charles Plessy
Le Fri, Mar 27, 2015 at 02:10:38PM +0100, Andreas Tille a écrit : > On Fri, Mar 27, 2015 at 11:01:29AM +0100, Roland Fehrenbacher wrote: > > > C> Do you think it would be possible to backport the change for > > C> Wheezy as well ? > > > > I guess so. We have already built the package for

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-27 Thread Andreas Tille
Hi Roland, On Fri, Mar 27, 2015 at 11:01:29AM +0100, Roland Fehrenbacher wrote: > C> commit 5788cecbb05a4394c3fed722c47bdba5c20432ef Author: > C> tbooth-guest Date: Tue Feb 25 13:43:34 > C> 2014 + > > C> Fixed package not cleaning 100% after build. > > this is a perf

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-27 Thread Roland Fehrenbacher
> "C" == Charles Plessy writes: Hi Charles, C> Le Thu, Mar 26, 2015 at 05:15:36PM +0100, Andreas Tille a écrit : >> On Thu, Mar 26, 2015 at 05:14:24PM +0100, Andreas Tille wrote: >> > > The above article describes the patch needed to prevent the >> > > flaw. Upstream incorpor

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-27 Thread Andreas Tille
Hi Charles, On Fri, Mar 27, 2015 at 08:55:14AM +0900, Charles Plessy wrote: > > I'll tag #781259 as serious. > > Hi Roland, > > to get the fix in Jessie at this point of the Freeze, it has to be limited the > strict necessary changes. > > I recommend to temporarly revert the following commits:

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-26 Thread Charles Plessy
Le Thu, Mar 26, 2015 at 05:15:36PM +0100, Andreas Tille a écrit : > On Thu, Mar 26, 2015 at 05:14:24PM +0100, Andreas Tille wrote: > > > The above article describes the patch needed to prevent the > > > flaw. Upstream incorporated the fix in version 2.1.8. In my opinion this > > > bug is release cr

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-26 Thread Roland Fehrenbacher
> "A" == Andreas Tille writes: A> Hi Roland, On Thu, Mar 26, 2015 at 04:04:23PM +0100, Roland A> Fehrenbacher wrote: >> as described in detail at >> http://darlinglab.org/blog/2015/03/23/not-so-fast-fasttree.html >> fasttree 2.1.7 has a a serious issue for many genomic

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-26 Thread Andreas Tille
On Thu, Mar 26, 2015 at 05:14:24PM +0100, Andreas Tille wrote: > > The above article describes the patch needed to prevent the > > flaw. Upstream incorporated the fix in version 2.1.8. In my opinion this > > bug is release critical and should be fixed before the release of > > jessie. > > Please f

Re: fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-26 Thread Andreas Tille
Hi Roland, On Thu, Mar 26, 2015 at 04:04:23PM +0100, Roland Fehrenbacher wrote: > as described in detail at > http://darlinglab.org/blog/2015/03/23/not-so-fast-fasttree.html > fasttree 2.1.7 has a a serious issue for many genomic epidemiology > studies which can lead to completely wrong conclusion

fasttree: hard-coded limit on branch length precision leads to erroneous results

2015-03-26 Thread Roland Fehrenbacher
Hi, as described in detail at http://darlinglab.org/blog/2015/03/23/not-so-fast-fasttree.html fasttree 2.1.7 has a a serious issue for many genomic epidemiology studies which can lead to completely wrong conclusions about research results in biomedicine. The current version of fasttree in jessie (