Hi Andreas,
Andreas Tille, on 2020-04-15 08:57:07 +0200:
> On Tue, Apr 14, 2020 at 10:30:03PM +0200, Étienne Mollier wrote:
> >
> > I do agree to keep the discussion transparent, no worries. ;)
> > Often, I want to edit the header after having sent the message.
>
> Fine. In future I'll answer
Hi Étienne,
On Tue, Apr 14, 2020 at 10:30:03PM +0200, Étienne Mollier wrote:
>
> I do agree to keep the discussion transparent, no worries. ;)
> Often, I want to edit the header after having sent the message.
Fine. In future I'll answer to debian-med list *only* as per list
policy. Please dro
Andreas Tille, on 2020-04-14 09:55:34 +0200:
> Hi Étienne,
>
> thanks a lot for your work on this package. As usual I'm CCing my
> answer to the list to make sure others can learn from our discussion as
> well.
Hi Andreas,
I do agree to keep the discussion transparent, no worries. ;)
Often, I
Hi Étienne,
thanks a lot for your work on this package. As usual I'm CCing my
answer to the list to make sure others can learn from our discussion as
well.
On Sat, Apr 11, 2020 at 08:57:06PM +0200, Étienne Mollier wrote:
>
> and thanks for time you take reviewing this too.
I'd love to repeat:
On 2020-04-13 11:16, Étienne Mollier wrote:
> Thanks for your feedback, I pushed a commit splitting example
> data in their own prinseq-lite-examples package, and did a few
> checks to at least make sure it builds, is lintian clean,
> installs, and `sh run-unit-test`s properly.
Looks good!
Best,
mer...@debian.org, on 2020-04-13 07:50:18 +0300:
> Hi Étienne,
>
Hi Andrius,
> On 2020-04-12 11:02, Étienne Mollier wrote:
> > Would it be worth putting example data in a side package, say
> > for instance "prinseq-lite-example" ? Genuine testing is not
> > yet in place anyway.
>
> This sounds
Hi Étienne,
On 2020-04-12 11:02, Étienne Mollier wrote:
> Would it be worth putting example data in a side package, say
> for instance "prinseq-lite-example" ? Genuine testing is not
> yet in place anyway.
This sounds better to me than having examples always shipped together
with the main binary
mer...@debian.org, on 2020-04-12 07:44:10 +0300:
> Hi Andreas,
>
> On 2020-04-11 19:37, Andreas Tille wrote:
> > When following the Debian Med scheme to make the autopkgtest user
> > runnable you need to install the example data into the binary package
> > as example.
>
> Is this necessary? Autop
Hi Andrius,
mer...@debian.org, on 2020-04-12 07:38:42 +0300:
> On 2020-04-10 18:54, Étienne Mollier wrote:
> > https://salsa.debian.org/med-team/prinseq-lite
>
> It seems you haven't pushed GIT tags ('git push --tags'), have you?
> Without them 'gbp buildpackage' fails for me.
They were inde
Hi Andreas,
On 2020-04-11 19:37, Andreas Tille wrote:
> When following the Debian Med scheme to make the autopkgtest user
> runnable you need to install the example data into the binary package
> as example.
Is this necessary? Autopkgtest runner always has the source package at
hand (actually, it
On 2020-04-11 17:47, Étienne Mollier wrote:
> I had a look at the Antoni's implementation, and applied similar
> approach, to sort the "no extension" vs ".pl" issue. I pushed
> the change on Salsa. This settles the question apparently.
It seems that now both extension and no-extension executable
Hi Étienne,
On 2020-04-10 18:54, Étienne Mollier wrote:
> https://salsa.debian.org/med-team/prinseq-lite
It seems you haven't pushed GIT tags ('git push --tags'), have you?
Without them 'gbp buildpackage' fails for me.
Best,
Andrius
signature.asc
Description: OpenPGP digital signature
Putting back the mailing list in the loop. Sorry for the
duplicate Andreas.
Andreas Tille, on 2020-04-11 18:37:27 +0200:
> Hi Étienne,
>
> thanks a lot for your work on this package.
Hi Andreas,
and thanks for time you take reviewing this too.
> On Sat, Apr 11, 2020 at 04:47:18PM +0200, Étien
Hi Étienne,
thanks a lot for your work on this package.
On Sat, Apr 11, 2020 at 04:47:18PM +0200, Étienne Mollier wrote:
> Andreas Tille, on 2020-04-11 16:09:10 +0200:
> > BTW, when having .pl files a typical pitfall is if you have a manpage
> > named manpage.pl.1. This is considerd a manpage wr
Andreas Tille, on 2020-04-11 16:09:10 +0200:
> BTW, when having .pl files a typical pitfall is if you have a manpage
> named manpage.pl.1. This is considerd a manpage written in Polish
> language. You can checkout this example
>
> https://salsa.debian.org/med-team/sprai/-/blob/master/debian/
On Sat, Apr 11, 2020 at 12:31:28PM +0200, Étienne Mollier wrote:
>
> Yes you are right, I was a bit concerned by Charles statement on
> compatibility with upstream[1], especially since virusseeker
> mentionned it /with/ the extension in its documentation[2]. On
> the other hand I do understand th
Étienne Mollier, on 2020-04-11 12:31:28 +0200:
> Speaking of manual pages and lintian, a warning about an
> unbreakable line in prinseq-lite.1 remains, but I'm not sure how
> to fix it without risking to change the meaning of the
> description: the line references a sequence of characters
> looking
Hi Andrius,
mer...@debian.org, on 2020-04-11 08:22:11 +0300:
> I have a couple of comments:
>
> 1. In Debian it is usual to strip programming language extensions from
> file names (.pl in this case). I see lintian already complains about
> that. I suggest stripping them off in debian/rules. The r
Hi Étienne,
On 2020-04-10 18:54, Étienne Mollier wrote:
> For the record, in addition to the ITP #956384, there is a
> repository open for prinseq-lite on Salsa:
>
> https://salsa.debian.org/med-team/prinseq-lite
Great job!
I have a couple of comments:
1. In Debian it is usual to strip pr
Good day,
For the record, in addition to the ITP #956384, there is a
repository open for prinseq-lite on Salsa:
https://salsa.debian.org/med-team/prinseq-lite
I'm still playing around inside debian/ to learn how things are
put together.
Kind Regards,
--
Étienne Mollier
Fingerprint: 5
mer...@debian.org, on 2020-04-10 12:15:57 +0300:
> On 2020-04-10 11:46, Étienne Mollier wrote:
> > You're right, assuming the side script is unneeded, this part
> > may as well wait for after the hackathon.
>
> You may drop a TO DO note concerning the side script in debian/TODO
> file. This way ot
Hi Étienne,
On 2020-04-10 11:46, Étienne Mollier wrote:
> You're right, assuming the side script is unneeded, this part
> may as well wait for after the hackathon.
You may drop a TO DO note concerning the side script in debian/TODO
file. This way other people may get to know that it is missing an
Andreas Tille, on 2020-04-09 23:06:38 +0200:
> Hi,
>
> On Thu, Apr 09, 2020 at 04:59:28PM +0300, Andrius Merkys wrote:
> > ...
>
> I fully subscribe all what Andrius said. :-)
>
> > Such request to cite is not legally binding. Although it's nice to put the
> > citation in debian/upstream/metadat
mer...@debian.org, on 2020-04-10 07:04:35 +0300:
> Hi Étienne,
>
> On 2020-04-09 17:16, Étienne Mollier wrote:
> > I was trying prinseq-lite with the example files they provided,
> > and while prinseq-lite.pl seemed to do its job, there is a side
> > script prinseq-graph.pl which calls Statistics:
Hi Étienne,
On 2020-04-09 17:16, Étienne Mollier wrote:
> I was trying prinseq-lite with the example files they provided,
> and while prinseq-lite.pl seemed to do its job, there is a side
> script prinseq-graph.pl which calls Statistics::PCA[1], except
> it does not seem to be part of Debian eithe
Hi,
On Thu, Apr 09, 2020 at 04:59:28PM +0300, Andrius Merkys wrote:
> ...
I fully subscribe all what Andrius said. :-)
> Such request to cite is not legally binding. Although it's nice to put the
> citation in debian/upstream/metadata :)
To give an example why it is a good idea to provide citat
Andrius Merkys, on 2020-04-09 16:59:28 +0300:
> Hi Étienne,
Hi Andrius,
Thank you for your advices!
> On Thu, 9 Apr 2020, 15:59 Étienne Mollier,
> wrote:
>
> > The two prinseq packages are provided into two different and
> > independent tarballs, so that might be two different source
> > packa
Hi Étienne,
On Thu, 9 Apr 2020, 15:59 Étienne Mollier,
wrote:
> The two prinseq packages are provided into two different and
> independent tarballs, so that might be two different source
> packages perhaps. I don't know if the web version would be
> interesting as well, but I thought it would b
28 matches
Mail list logo
