Re: Request for a sponsored upload of fast5-research

2020-08-05 Thread Andreas Tille
Hi Nilesh, On Wed, Aug 05, 2020 at 02:25:27AM +0530, Nilesh Patra wrote: > Looks good to me. I've done these: > 1. Added Autopkgtests > 2. Change archs to all instead of any Very nice. > 3. Run wrap-and-sort for aesthetic styling - just so that it looks sorted. In the end I don't mind a lot - t

Re: Request for a sponsored upload of fast5-research

2020-08-04 Thread Nilesh Patra
Worth mentioning that the changes have all been made as suggested. Do > let me know if anything else remains outstanding > Looks good to me. I've done these: 1. Added Autopkgtests 2. Change archs to all instead of any 3. Run wrap-and-sort for aesthetic styling - just so that it looks sorted. Enou

Re: Request for a sponsored upload of fast5-research

2020-08-04 Thread Shayan Doust
Hello Nilesh, > I dug in a bit - it looks like that there's an issue with typecasting in > the code. Upstream can shed more light on this, > it makes sense to open an issue IMO. > Also, I've pushed in the above mentioned 'fix' (?) and a couple of other > minor changes, please $git pull :) Many t

Re: Request for a sponsored upload of fast5-research

2020-08-04 Thread Nilesh Patra
On Tue, 4 Aug 2020 at 18:20, Shayan Doust wrote: > Hello Andreas, > > Thanks for the nitpicking! > > I've had a moment of inactivity with this package, so I forgot why the > patch was there. I now remember the patch I put there simply disables an > erroneous assertion: > > AssertionError: Tuples

Re: Request for a sponsored upload of fast5-research

2020-08-04 Thread Shayan Doust
Hello Andreas, Thanks for the nitpicking! I've had a moment of inactivity with this package, so I forgot why the patch was there. I now remember the patch I put there simply disables an erroneous assertion: AssertionError: Tuples differ: (303, 2) != (303, 2, void(b'\x00\x00\x00\x00')) I

Re: Request for a sponsored upload of fast5-research

2020-08-04 Thread Andreas Tille
Hi Shayan, On Mon, Aug 03, 2020 at 03:30:43PM +0100, Shayan Doust wrote: > I believe fast5-research[1] is ready for a sponsored upload. Do let me > know if anything needs altering. Thanks a lot for your continuous work on COVID-19 relevant packages. I have some minor up to nitpicking changes com