Re: [RFS] tortoize

2020-12-07 Thread Maarten L. Hekkelman
Hi Andreas, Op 06-12-2020 om 17:34 schreef Andreas Tille: Would you mind explaining why it Test-Depends libcifpp-dev ? That's because the -dev package contains the example files that are used by the autopkgtest. Saves space on disk. regards, -maarten

Re: [RFS] tortoize

2020-12-06 Thread Andreas Tille
Hi Maarten, On Sun, Dec 06, 2020 at 07:55:05AM +0100, Maarten L. Hekkelman wrote: > Op 27-11-2020 om 18:00 schreef Andreas Tille: > > > This package is now ready to be uploaded as well. > > Nearly. :-) I have fixed debian/upstream/metadata. > Ha, you missed another error: one I made in cif-tools

Re: [RFS] tortoize

2020-12-06 Thread Maarten L. Hekkelman
Hi, Op 27-11-2020 om 18:00 schreef Andreas Tille: This package is now ready to be uploaded as well. Nearly. :-) I have fixed debian/upstream/metadata. Ha, you missed another error: one I made in cif-tools as well, I had the default base path for the vcs- links in the control file instead of

Re: [RFS] tortoize

2020-11-27 Thread Maarten L. Hekkelman
Hi Tony, Thanks for the explanation, there's one thing though, I configured sbuild to run lintian. The package created by sbuild is really clean. Now there was a problem in the original tar ball. It contained links in the config/m4 directory, I stupidly checked those in in git and they ended

Re: [RFS] tortoize

2020-11-27 Thread Maarten L. Hekkelman
Op 27-11-2020 om 08:50 schreef Maarten L. Hekkelman: However, I ended up with a package that builds fine when using sbuild, but fails when using gbp buildpackage. The package created with gbp has a lintian error telling me: gbp:info: Running Postbuild hook E: tortoize source: source-contains

Re: [RFS] tortoize

2020-11-27 Thread Andreas Tille
On Fri, Nov 27, 2020 at 02:45:45PM +0100, Maarten L. Hekkelman wrote: > > Found the error, the original tar ball contained links for the files > generated by autoreconf in config/m4. Good. > This package is now ready to be uploaded as well. Nearly. :-) I have fixed debian/upstream/metadata.

Re: [RFS] tortoize

2020-11-27 Thread tony mancill
On Fri, Nov 27, 2020 at 08:50:59AM +0100, Maarten L. Hekkelman wrote: > However, I ended up with a package that builds fine when using sbuild, but > fails when using gbp buildpackage. The package created with gbp has a > lintian error telling me: > ... > > ... > Why is that? What's the difference

Re: [RFS] tortoize

2020-11-27 Thread Maarten L. Hekkelman
Hi Andreas, Op 26-11-2020 om 21:55 schreef Andreas Tille: BTW, it seems to be the same example file in libcifpp. I'd consider it a good idea to have this file only once and set dependencies appropriately. This file is very common, I use it in all my PDB related packages. I agree that sticking

Re: [RFS] tortoize

2020-11-26 Thread Andreas Tille
Hi Maarten, On Thu, Nov 26, 2020 at 08:03:18PM +0100, Maarten L. Hekkelman wrote: > Thanks for taking the time to look at tortoize. > > Op 26-11-2020 om 11:16 schreef Andreas Tille: > > I changed the autopkgtest a bit. Please stick to the common name for > > the test script run-unit-test as its

Re: [RFS] tortoize

2020-11-26 Thread Andreas Tille
Hi Maarten, thanks a lot for your contribution. On Wed, Nov 25, 2020 at 11:34:55AM +0100, Maarten L. Hekkelman wrote: > I just checked in code for tortoize, an application to calculate > ramachandran z-scores. > > Tortoize validates protein structure models by checking the > Ramachandran plot an