Re: [Advent bug squashing] fixed in #1018506 in python-gtfparse

2022-12-04 Thread Étienne Mollier
Mohd Bilal, on 2022-12-04: > On 12/4/22 20:39, Étienne Mollier wrote: > [...] > > > > In such configuration, assert would test whether $1 is true, > > and print $2 if it is not. I believe you might have wanted to > > conver to: > > > > assert $1 == $2 > > Oh. I did a direct substitution of

Re: [Advent bug squashing] fixed in #1018506 in python-gtfparse

2022-12-04 Thread Mohd Bilal
On 12/4/22 20:39, Étienne Mollier wrote: [...] In such configuration, assert would test whether $1 is true, and print $2 if it is not. I believe you might have wanted to conver to: assert $1 == $2 Oh. I did a direct substitution of `eq_(*)` with `assert` thinking that they do the sa

Re: [Advent bug squashing] fixed in #1018506 in python-gtfparse

2022-12-04 Thread Étienne Mollier
Hi Bilal, Mohd Bilal, on 2022-12-04: > I just updated python-gftparse[1] to a new upstream version and added a > patch to make the switch from nose->pytest (Bug #1018506). > > Can somebody review + sponsor an upload please ? I've strolled through the patch and I'm concerned by the translation of