Re: [Help] New version of htslib does not build [EXT]

2022-10-12 Thread James Bonfield
On Wed, Oct 12, 2022 at 03:24:17PM +0530, Nilesh Patra wrote: > > Does it have the ability to > > specify a whitelist of known symbols, which can be written once and > > then you're only notified when something new appears? > > Yes, that is the way it happens. We add in this symbols file because t

Re: [Help] New version of htslib does not build [EXT]

2022-10-12 Thread Nilesh Patra
Hi James, On Wed, Oct 12, 2022 at 09:47:04AM +0100, James Bonfield wrote: > On Wed, Oct 12, 2022 at 01:30:40AM +0530, Nilesh Patra wrote: > > On Thu, Oct 06, 2022 at 01:59:23AM +, John Marshall wrote: > > > If you omitted these internal symbols, there would be no problem. I > > > believe upst

Re: [Help] New version of htslib does not build [EXT]

2022-10-12 Thread James Bonfield
Hello, On Wed, Oct 12, 2022 at 01:30:40AM +0530, Nilesh Patra wrote: > On Thu, Oct 06, 2022 at 01:59:23AM +, John Marshall wrote: > > If you omitted these internal symbols, there would be no problem. I believe > > upstream's attitude would be that these particular symbols are not declared >

Re: [Help] New version of htslib does not build

2022-10-11 Thread Nilesh Patra
Hi, On Thu, Oct 06, 2022 at 01:59:23AM +, John Marshall wrote: > On 4 Oct 2022, at 15:31, Nilesh Patra wrote: > > The thing that was causing failures on !amd64 was that there were amd64 > > specific symbols in debian/libhtscodecs2.symbols that were not matching on > > those archs due to avx

Re: [Help] New version of htslib does not build

2022-10-08 Thread Andreas Tille
Hi Étienne, Am Sat, Oct 08, 2022 at 10:07:52AM +0200 schrieb Étienne Mollier: > I spent some time reviewing the state of htscodecs in debian, > and came up with little changes to bring back simd support > without breaking builds or causing cpu baseline violations. > Regarding the symbols file, I m

Re: [Help] New version of htslib does not build

2022-10-08 Thread Étienne Mollier
Hi all, Andreas Tille, on 2022-10-06: > Am Thu, Oct 06, 2022 at 01:59:23AM + schrieb John Marshall: > > On 4 Oct 2022, at 15:31, Nilesh Patra wrote: > > > The thing that was causing failures on !amd64 was that there were amd64 > > > specific symbols in debian/libhtscodecs2.symbols that were

Re: [Help] New version of htslib does not build

2022-10-06 Thread Andreas Tille
Hi John, thanks again for your contribution to the hts discussion. Its really welcome as always! Am Thu, Oct 06, 2022 at 01:59:23AM + schrieb John Marshall: > On 4 Oct 2022, at 15:31, Nilesh Patra wrote: > > The thing that was causing failures on !amd64 was that there were amd64 > > specif

Re: [Help] New version of htslib does not build

2022-10-05 Thread John Marshall
On 4 Oct 2022, at 15:31, Nilesh Patra wrote: > The thing that was causing failures on !amd64 was that there were amd64 > specific symbols in debian/libhtscodecs2.symbols that were not matching on > those archs due to avx2/avx512 specific ABI being exported there. So something specific to the De

Re: [Help] New version of htslib does not build

2022-10-04 Thread Nilesh Patra
Hi, I am on a VAC right now but happened to see this. On Tue, Oct 04, 2022 at 01:38:49PM +, John Marshall wrote: > On 1 Oct 2022, at 07:21, Nilesh Patra wrote: > > I have fixed a bunch of things with htscodecs and htslib, both > > of which were not building on !amd64. Hopefully it is > > fin

Re: [Help] New version of htslib does not build

2022-10-04 Thread John Marshall
On 1 Oct 2022, at 07:21, Nilesh Patra wrote: > I have fixed a bunch of things with htscodecs and htslib, both > of which were not building on !amd64. Hopefully it is > fine now. If htscodecs or htslib is failing to build on !amd64 due to a problem outside your Debian-specific build scripts, you

Re: [Help] New version of htslib does not build

2022-10-02 Thread Étienne Mollier
Hi all, Étienne Mollier, on 2022-10-01: > Nilesh Patra, on 2022-10-01: > > I have fixed a bunch of things with htscodecs and htslib, both > > of which were not building on !amd64. Hopefully it is > > fine now. > > > > But please fix pysam which is blocking htslib transition. I am > > _absolutely_

Re: [Help] New version of htslib does not build

2022-10-01 Thread Étienne Mollier
Hello everyone, Nilesh Patra, on 2022-10-01: > I have fixed a bunch of things with htscodecs and htslib, both > of which were not building on !amd64. Hopefully it is > fine now. > > But please fix pysam which is blocking htslib transition. I am > _absolutely_ out of time now. The autopkgtest fai

Re: [Help] New version of htslib does not build

2022-09-30 Thread Nilesh Patra
On Fri, Sep 30, 2022 at 09:52:55PM +0200, Andreas Tille wrote: > Am Fri, Sep 30, 2022 at 02:46:38PM + schrieb Nilesh Patra: > > > > I have just pushed a fix, which hopefully should fix this. You might want to > > re-upload. > > I can't do this before Tuesday. > > > BTW, I noticed that the S

Re: [Help] New version of htslib does not build

2022-09-30 Thread Andreas Tille
Am Fri, Sep 30, 2022 at 02:46:38PM + schrieb Nilesh Patra: > > I have just pushed a fix, which hopefully should fix this. You might want to > re-upload. I can't do this before Tuesday. > BTW, I noticed that the SOVERSION has "+ds" appended -- is that really > intended? > > ./usr/lib/x86_64

Re: [Help] New version of htslib does not build

2022-09-30 Thread Nilesh Patra
On 30.09.2022 20:00, Andreas Tille wrote: Hi, [...] Strangely enough the autopkgtest is failing[4] (which was not the case in my local build.) Could anybody have a look? I have just pushed a fix, which hopefully should fix this. You might want to re-upload. BTW, I noticed that the SOVERSI

Re: [Help] New version of htslib does not build

2022-09-30 Thread Andreas Tille
Hi, Am Fri, Sep 30, 2022 at 01:10:27PM + schrieb John Marshall: > Andreas Tille wrote: > > Interestingly the missing symbols are mentioned in some warnings higher up > > in the changelog! > > As per the build log, those warnings were: > > Selecting previously unselected package libhtscodecs

Re: [Help] New version of htslib does not build

2022-09-30 Thread John Marshall
Andreas Tille wrote: > Interestingly the missing symbols are mentioned in some warnings higher up in > the changelog! As per the build log, those warnings were: Selecting previously unselected package libhtscodecs2:amd64. Preparing to unpack .../44-libhtscodecs2_1.2.2-1_amd64.deb ... Unpacking l

Re: [Help] New version of htslib does not build

2022-09-29 Thread Aaron M. Ucko
Andreas Tille writes: > I tried to catch up with htslib since we are lagging behind two releases > (counted from experimental - its three release in unstable). > Unfortunately it does not build since the linker does not find some > symbols ... despite these are inside libhts.a when grepping the s

[Help] New version of htslib does not build

2022-09-29 Thread Andreas Tille
Hi, I tried to catch up with htslib since we are lagging behind two releases (counted from experimental - its three release in unstable). Unfortunately it does not build since the linker does not find some symbols ... despite these are inside libhts.a when grepping the strings output for it. Inte