Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-12-01 Thread Roberto C . Sánchez
On Thu, Dec 01, 2016 at 04:34:20PM +0100, Raphael Hertzog wrote: > On Tue, 29 Nov 2016, Antoine Beaupré wrote: > > I wonder if we should standardize something about this. > > > > I usually name security patches with the following scheme: > > debian/patches/CVE--(-commithash)?.patch > > I

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-12-01 Thread Antoine Beaupré
On 2016-12-01 10:34:20, Raphael Hertzog wrote: > On Tue, 29 Nov 2016, Antoine Beaupré wrote: >> I wonder if we should standardize something about this. >> >> I usually name security patches with the following scheme: >> debian/patches/CVE--(-commithash)?.patch > > I use CVE--(-patc

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-12-01 Thread Raphael Hertzog
On Tue, 29 Nov 2016, Antoine Beaupré wrote: > I wonder if we should standardize something about this. > > I usually name security patches with the following scheme: > debian/patches/CVE--(-commithash)?.patch I use CVE--(-patchnumber)?.patch as some issues require multiple patches

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-12-01 Thread Raphael Hertzog
On Thu, 01 Dec 2016, Ben Hutchings wrote: > Would it make sense to add a Bug header field to patches, e.g.: > Bug-CVE: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-- > or: > Bug-Debian-Security: > https://security-tracker.debian.org/tracker/CVE-- > ? I don't have any

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-30 Thread Ben Hutchings
On Tue, 2016-11-29 at 12:14 +0100, Raphael Hertzog wrote: > Hi, > > On Mon, 28 Nov 2016, Roberto C. Sánchez wrote: > > Quite right: > > http://people.debian.org/~roberto/imagemagick_6.7.7.10-5+deb7u7_6.7.7.10-5+deb7u8.diff > > Somme comments: > - since we have no git history, it's nice to indicat

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-29 Thread Antoine Beaupré
On 2016-11-29 06:14:10, Raphael Hertzog wrote: > Hi, > > On Mon, 28 Nov 2016, Roberto C. Sánchez wrote: >> Quite right: >> http://people.debian.org/~roberto/imagemagick_6.7.7.10-5+deb7u7_6.7.7.10-5+deb7u8.diff > > Somme comments: > - since we have no git history, it's nice to indicate in each patch

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-29 Thread Roberto C . Sánchez
On Tue, Nov 29, 2016 at 01:33:54PM +0100, Raphael Hertzog wrote: > On Tue, 29 Nov 2016, Roberto C. Sánchez wrote: > > Hi Raphael, > > > > On Tue, Nov 29, 2016 at 12:14:10PM +0100, Raphael Hertzog wrote: > > > Hi, > > > > > > On Mon, 28 Nov 2016, Roberto C. Sánchez wrote: > > > > Quite right: > >

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-29 Thread Raphael Hertzog
On Tue, 29 Nov 2016, Roberto C. Sánchez wrote: > Hi Raphael, > > On Tue, Nov 29, 2016 at 12:14:10PM +0100, Raphael Hertzog wrote: > > Hi, > > > > On Mon, 28 Nov 2016, Roberto C. Sánchez wrote: > > > Quite right: > > > http://people.debian.org/~roberto/imagemagick_6.7.7.10-5+deb7u7_6.7.7.10-5+deb7

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-29 Thread Roberto C . Sánchez
Hi Raphael, On Tue, Nov 29, 2016 at 12:14:10PM +0100, Raphael Hertzog wrote: > Hi, > > On Mon, 28 Nov 2016, Roberto C. Sánchez wrote: > > Quite right: > > http://people.debian.org/~roberto/imagemagick_6.7.7.10-5+deb7u7_6.7.7.10-5+deb7u8.diff > > Somme comments: > - since we have no git history,

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-29 Thread Raphael Hertzog
Hi, On Mon, 28 Nov 2016, Roberto C. Sánchez wrote: > Quite right: > http://people.debian.org/~roberto/imagemagick_6.7.7.10-5+deb7u7_6.7.7.10-5+deb7u8.diff Somme comments: - since we have no git history, it's nice to indicate in each patch what CVE it fixes (I like to name the patch according to

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-28 Thread Holger Levsen
On Mon, Nov 28, 2016 at 10:00:28PM +0100, Ola Lundqvist wrote: > Yes that practice is a good thing. It keeps the mailbox small. > I do not really understand why Holger complained. I may miss something > obvious of course. I was reading this over a very flaky network connection, which reminded me h

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-28 Thread Ola Lundqvist
Hi Roberto Yes that practice is a good thing. It keeps the mailbox small. I do not really understand why Holger complained. I may miss something obvious of course. If anyone have a good reason why we should attach large files to the list, then please let me know. // Ola On 28 November 2016 at 1

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-28 Thread Roberto C . Sánchez
On Mon, Nov 28, 2016 at 01:57:16PM +, Holger Levsen wrote: > On Mon, Nov 28, 2016 at 06:44:07AM -0500, Roberto C. Sánchez wrote: > > > If you're asking for code review posting a debdiff to the list might > > > help people to pick it up. > > Quite right: > > > > http://people.debian.org/~robert

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-28 Thread Holger Levsen
On Mon, Nov 28, 2016 at 06:44:07AM -0500, Roberto C. Sánchez wrote: > > If you're asking for code review posting a debdiff to the list might > > help people to pick it up. > Quite right: > > http://people.debian.org/~roberto/imagemagick_6.7.7.10-5+deb7u7_6.7.7.10-5+deb7u8.diff this is a link post

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-28 Thread Roberto C . Sánchez
Hi Guido, Thanks for the feedback. On Mon, Nov 28, 2016 at 08:13:26AM +0100, Guido Günther wrote: > Hi Roberto, > On Mon, Nov 28, 2016 at 01:02:38AM -0500, Roberto C. Sánchez wrote: > > Greetings all, > > > > I have prepared an update of ImageMagick that takes the work Ben > > Hutchings started

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-28 Thread Chris Lamb
Guido Günther wrote: > If you're asking for code review posting a debdiff to the list might > help people to pick it up. Naive diffoscope output of the two .dscs: https://gist.github.com/lamby/70610714ff448db0be955c888ffaff06/raw Regards, -- ,''`. : :' : Chris Lamb `.

Re: RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-27 Thread Guido Günther
Hi Roberto, On Mon, Nov 28, 2016 at 01:02:38AM -0500, Roberto C. Sánchez wrote: > Greetings all, > > I have prepared an update of ImageMagick that takes the work Ben > Hutchings started and incorporates patches for all remaining security > issues which have been fixed in jessie [0]. > > The natur

RFC - ImageMagick, proper testing, and handling issues without a CVE ID

2016-11-27 Thread Roberto C . Sánchez
Greetings all, I have prepared an update of ImageMagick that takes the work Ben Hutchings started and incorporates patches for all remaining security issues which have been fixed in jessie [0]. The nature of my request in this message is: 1. I would appreciate it if someone would take a look at