Bug#697017: An improved patch over Jonathan's

2015-04-17 Thread Pip Cet
On Tue, 1 Jan 2013 11:56:00 -0500 (EST) Stephen Powell wrote: > On Tue, 01 Jan 2013 10:18:06 -0500 (EST), Gabriel Klawitter wrote: > > Your patch will sort out cases like 08:02 but not the case where root > > equals 'facade', 'added' or 'dead01'. > > I'm using the root= parameter for giving the na

Bug#697017: An improved patch over Jonathan's

2013-01-01 Thread gabriel
Stephen Powell schrieb am Tue, Jan 01, 2013 at 11:56:00AM -0500: > >We accept the following variants: > > 1) device number in hexadecimal represents itself Hi Stephen, I haven't read that kernel source code before and therefore didn't know that the root parameter may be a hex numb

Bug#697017: An improved patch over Jonathan's

2013-01-01 Thread Stephen Powell
On Tue, 01 Jan 2013 10:18:06 -0500 (EST), Gabriel Klawitter wrote: > > sorry for the ambiguity. I did't mean cases like 0x and 0x but > the cases for which this function is being used. These are, as far as > I've understood your post correctly, the case where root equals > something like

Bug#697017: An improved patch over Jonathan's

2013-01-01 Thread Gabriel Klawitter
On 12/31/2012 10:08 PM, Stephen Powell wrote: > > Try the following at a shell prompt: > >a=$((0x)) >echo $a >a=$((0x)) >echo $a >a=$((0xcompute)) > > The first two assignment statements produce no errors, and the result > of the echo command is 65535 in both cases,

Bug#697017: An improved patch over Jonathan's

2012-12-31 Thread Stephen Powell
On Mon, 31 Dec 2012 12:24:44 -0500 (EST), Gabriel Klawitter wrote: > > thank you for the efforts to solve the problem. > > Maybe I missed something, but isn't the case that is to be sorted out > (for major/minors) the one that has a colon surrounded by digits (like > [0-9]*:[0-9]*) and the case w

Bug#697017: An improved patch over Jonathan's

2012-12-31 Thread Gabriel Klawitter
Hello, thank you for the efforts to solve the problem. Maybe I missed something, but isn't the case that is to be sorted out (for major/minors) the one that has a colon surrounded by digits (like [0-9]*:[0-9]*) and the case where the root string contains at most 4 hex digits? Why do not match

Bug#697017: An improved patch over Jonathan's

2012-12-31 Thread Stephen Powell
Jonathan, After further study of your patch, I did notice one flaw: the pattern "*[!A-Fa-f0-9]*" will not match the null string, as your comments suggest it will. And you have deleted the separate case which handles the null string. Here is an improved patch: http://users.wowway.com/~zlinuxm