Bug#695182: Write couple of 1GB files for OOM crash

2013-01-21 Thread Jonathan Nieder
paul.sz...@sydney.edu.au wrote: > I am coming back to the idea that this is some > signed-vs-unsigned or similar issue... though I could not find it yet! Thanks for your work, and good luck. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "uns

Bug#695182: Write couple of 1GB files for OOM crash

2013-01-21 Thread paul . szabo
Dear Jonathan, Thanks again for your help in writing "correct" and "acceptable" patches. I did change a few things, hopefully for the better. I decided not to "push" the drop-caches part of my patch; because it now seems to me that it is not the "essence" of the issue: it protects against OOM whe

Bug#695182: Write couple of 1GB files for OOM crash

2013-01-10 Thread Jonathan Nieder
paul.sz...@sydney.edu.au wrote: > Dear Jonathan, >> ... once you have a reproducible test I imagine the mm folks will >> already be very interested and they may be able to help ... > > But, I do already have a reproducible test! Write a few files, as per > the initial message in this http://bugs.d

Bug#695182: Write couple of 1GB files for OOM crash

2013-01-10 Thread paul . szabo
Dear Jonathan, > ... once you have a reproducible test I imagine the mm folks will > already be very interested and they may be able to help ... But, I do already have a reproducible test! Write a few files, as per the initial message in this http://bugs.debian.org/695182 ; I also have a patch/so

Bug#695182: Write couple of 1GB files for OOM crash

2013-01-09 Thread Jonathan Nieder
paul.sz...@sydney.edu.au wrote: > So, there is a bug still. I will try to make up some easily reproducible > test, and if can provoke OOM then look again into kernel code. Ok, thanks for the update. BTW, once you have a reproducible test I imagine the mm folks will already be very interested and

Bug#695182: Write couple of 1GB files for OOM crash

2013-01-09 Thread paul . szabo
I am slowly coming around to the idea of splitting my patch up into many parts, each addressing just one little issue, so there would be a couple of [PATCH]-es and some [RFC]-s, each profusely explained. Unfortunately did not yet have time to work on this; but want to do, hopefully soon. However..

Bug#695182: Write couple of 1GB files for OOM crash

2013-01-06 Thread Ben Hutchings
On Mon, 2013-01-07 at 14:03 +1100, paul.sz...@sydney.edu.au wrote: > Dear Jonathan, > > > Here's a quick review from a non-expert (i.e., me). ... > > Thanks! > > > ... When the patch > > seems ready to you, please send it inline in a message to > > linux...@kvack.org, cc-ing linux-ker...@vger.ke

Bug#695182: Write couple of 1GB files for OOM crash

2013-01-06 Thread Jonathan Nieder
paul.sz...@sydney.edu.au wrote: >>> +/* Easy call: do "echo 3 > /proc/sys/vm/drop_caches" */ >> >> I don't understand this comment. What does "Easy call" mean? >> >>> +void easy_drop_caches(void) [...] >> This should be declared in some appropriate header (e.g., >> include/linux/mm.h). > > I adde

Bug#695182: Write couple of 1GB files for OOM crash

2013-01-06 Thread paul . szabo
Dear Jonathan, > Here's a quick review from a non-expert (i.e., me). ... Thanks! > ... When the patch > seems ready to you, please send it inline in a message to > linux...@kvack.org, cc-ing linux-ker...@vger.kernel.org and Ben and me > (or this bug log) so we can track it. The mm folks will pr

Bug#695182: Write couple of 1GB files for OOM crash

2013-01-06 Thread Jonathan Nieder
Hi Paul, Paul Szabo wrote: > I changed the proposed patch accordingly, scripts/checkpatch.pl produces > just a few warnings. I had my patch in use for a while now, so I believe > it is suitably tested. Thanks much --- this is easier to read. Here's a quick review from a non-expert (i.e., me).