Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-27 Thread Minchan Kim
On Fri, Jan 25, 2013 at 08:53:24PM +1100, paul.sz...@sydney.edu.au wrote: > Dear Minchan, > > > So what's the effect for user? > > ... > > It seems you saw old kernel. > > ... > > Current kernel includes ... > > So I think we don't need this patch. > > As I understand now, my patch is "right" and

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-26 Thread paul . szabo
Dear Jonathan, >> If you can identify where it was fixed then your patch for older >> versions should go to stable with a reference to the upstream fix (see >> Documentation/stable_kernel_rules.txt). > > How about this patch? > > It was applied in mainline during the 3.3 merge window, so kernels >

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-26 Thread Theodore Ts'o
(In the teach a person to fish category...) If you know the file and line number where a bug/regression was introduced, the "git blame" command is a great tool for identifying the commit which changed a given line of code. Then use "git tag --contains " to see when a particular commit was introdu

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-25 Thread Jonathan Nieder
Hi Paul, Ben Hutchings wrote: > If you can identify where it was fixed then your patch for older > versions should go to stable with a reference to the upstream fix (see > Documentation/stable_kernel_rules.txt). How about this patch? It was applied in mainline during the 3.3 merge window, so ke

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-25 Thread Ben Hutchings
On Sat, 2013-01-26 at 14:07 +1100, paul.sz...@sydney.edu.au wrote: > Dear Ben, > > > ... the mm maintainers are probably much better placed ... > > Exactly. Now I wonder: are you one of them? Hah, no. Ben. -- Ben Hutchings Any smoothly functioning technology is indistinguishable from a rigged

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-25 Thread paul . szabo
Dear Ben, > ... the mm maintainers are probably much better placed ... Exactly. Now I wonder: are you one of them? Thanks, Paul Paul Szabo p...@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/ School of Mathematics and Statistics University of SydneyAustralia -- To UNSUBSCRIBE

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-25 Thread Jonathan Nieder
Hi Paul, paul.sz...@sydney.edu.au wrote: > Dear Ben, >> If you can identify where it was fixed then ... > > Sorry I cannot do that. I have no idea where kernel changelogs are kept. Here are some tools. # prerequisite: apt-get install git; # as root # to get the kernel history: git clon

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-25 Thread Ben Hutchings
On Sat, 2013-01-26 at 10:49 +1100, paul.sz...@sydney.edu.au wrote: > Dear Ben, > > > If you can identify where it was fixed then ... > > Sorry I cannot do that. I have no idea where kernel changelogs are kept. > > I am happy to do some work. Please do not call me lazy. The changelogs are in git

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-25 Thread paul . szabo
Dear Ben, > If you can identify where it was fixed then ... Sorry I cannot do that. I have no idea where kernel changelogs are kept. I am happy to do some work. Please do not call me lazy. Cheers, Paul Paul Szabo p...@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/ School of Mathemat

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-25 Thread Ben Hutchings
On Fri, 2013-01-25 at 20:53 +1100, paul.sz...@sydney.edu.au wrote: > Dear Minchan, > > > So what's the effect for user? > > ... > > It seems you saw old kernel. > > ... > > Current kernel includes ... > > So I think we don't need this patch. > > As I understand now, my patch is "right" and needed

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-25 Thread paul . szabo
Dear Minchan, > So what's the effect for user? > ... > It seems you saw old kernel. > ... > Current kernel includes ... > So I think we don't need this patch. As I understand now, my patch is "right" and needed for older kernels; for newer kernels, the issue has been fixed in equivalent ways; it

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-22 Thread paul . szabo
Dear Minchan, > So what's the effect for user? Sorry I have no idea. The kernel seems to work well without this patch; or in fact not so well, PAE crashing with spurious OOM. In my fruitless efforts of avoiding OOM by sensible choices of sysctl tunables, I noticed that maybe the treatment of min

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-22 Thread Minchan Kim
On Mon, Jan 21, 2013 at 02:15:49PM +1100, paul.sz...@sydney.edu.au wrote: > When calculating amount of dirtyable memory, min_free_kbytes should be > subtracted because it is not intended for dirty pages. So what's the effect for user? It would be better to include that in description if possible.

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-22 Thread Andrew Morton
On Mon, 21 Jan 2013 14:15:49 +1100 paul.sz...@sydney.edu.au wrote: > When calculating amount of dirtyable memory, min_free_kbytes should be > subtracted because it is not intended for dirty pages. Makes sense. > Using an "extern int" because that is the only interface to some such > sysctl value

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-21 Thread Rik van Riel
On 01/20/2013 10:15 PM, paul.sz...@sydney.edu.au wrote: When calculating amount of dirtyable memory, min_free_kbytes should be subtracted because it is not intended for dirty pages. Using an "extern int" because that is the only interface to some such sysctl values. (This patch does not solve t

Bug#695182: [PATCH] Subtract min_free_kbytes from dirtyable memory

2013-01-20 Thread paul . szabo
When calculating amount of dirtyable memory, min_free_kbytes should be subtracted because it is not intended for dirty pages. Using an "extern int" because that is the only interface to some such sysctl values. (This patch does not solve the PAE OOM issue.) Paul Szabo p...@maths.usyd.edu.au