Bug#564628: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)

2010-11-29 Thread hayeswang
Hi Romieu, Let me explain that not all of the phy settings are the ram code (or firmware). Some of them are the initialization sequence. Only the "Low pass filter & DLY_CAP fine tune from uC" is the firmware. And there is no firmware before RTL8111D. That is, except 8111DP, the chips which have fi

Bug#564628: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)

2010-11-29 Thread Stephen Hemminger
On Tue, 30 Nov 2010 00:33:34 +0100 Francois Romieu wrote: > hayeswang : > > Excuse me, I have some questions about the firmware patch. > > > > 1. I should convert the data into the binary files (.bin). Is it right? > > You may do it. > > Fwiw I have cooked something for it in the attached pat

Bug#564628: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)

2010-11-28 Thread hayeswang
Excuse me, I have some questions about the firmware patch. 1. I should convert the data into the binary files (.bin). Is it right? 2. Where should I update the firmware files? Is the path the linux-2.6/firmeware? However, according to linux-2.6/firmeware/README.AddingFirmware, I should up

Bug#564628: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)

2010-11-26 Thread Ben Hutchings
On Fri, 2010-11-26 at 23:49 +0100, Francois Romieu wrote: > Ben Hutchings : > > On Fri, 2010-11-26 at 19:54 +0800, Hayes Wang wrote: > > > Correct the binary code (Low pass filter & DLY_CAP fine tune from uC). > > > The incorrect ram code would make the nic working abnormally. > > [...] > > > > I

Bug#564628: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)

2010-11-26 Thread Francois Romieu
Ben Hutchings : > On Fri, 2010-11-26 at 19:54 +0800, Hayes Wang wrote: > > Correct the binary code (Low pass filter & DLY_CAP fine tune from uC). > > The incorrect ram code would make the nic working abnormally. > [...] > > I'm glad you finally acknowledge that this is code rather than simple > r

Bug#564628: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)

2010-11-26 Thread Ben Hutchings
On Fri, 2010-11-26 at 19:54 +0800, Hayes Wang wrote: > Correct the binary code (Low pass filter & DLY_CAP fine tune from uC). > The incorrect ram code would make the nic working abnormally. [...] I'm glad you finally acknowledge that this is code rather than simple register initialisation. Please