Re: [RFC] modpost: add option to allow external modules to avoid taint

2011-12-18 Thread Rusty Russell
On Fri, 16 Dec 2011 04:39:49 +, Ben Hutchings wrote: Non-text part: multipart/signed > On Fri, 2011-12-16 at 14:26 +1030, Rusty Russell wrote: > > On Wed, 14 Dec 2011 11:20:03 -0500, "John W. Linville" > > wrote: > > We really want to indicate "

Re: [RFC] modpost: add option to allow external modules to avoid taint

2011-12-15 Thread Rusty Russell
On Wed, 14 Dec 2011 11:20:03 -0500, "John W. Linville" wrote: > In some cases, it might be desirable to package a module from an > external source tree alongside the base kernel. In those cases, it > might also be desirable to not have those modules tainting the kernel. > > This patch provides

Re: [PATCH] lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging

2011-12-08 Thread Rusty Russell
On Wed, 07 Dec 2011 14:30:58 +, Ben Hutchings wrote: > We do want to allow lock debugging for GPL-compatible modules that are > not (yet) built in-tree. This was disabled as a side-effect of commit > 2449b8ba0745327c5fa49a8d9acffe03b2eded69 ('module,bug: Add > TAINT_OOT_MODULE flag for module

Re: [PATCH] module: Enable dynamic debugging regardless of taint

2011-10-31 Thread Rusty Russell
On Tue, 01 Nov 2011 03:59:33 +, Ben Hutchings wrote: > Dynamic debugging is currently disabled for tainted modules, except > for TAINT_CRAP. This prevents use of dynamic debugging for > out-of-tree modules now that they are also tainted. > > This condition was apparently intended to avoid a

Re: [PATCH 2/2] module: Re-enable dynamic debugging for GPL-compatible OOT modules

2011-10-31 Thread Rusty Russell
On Mon, 31 Oct 2011 13:44:17 +, Ben Hutchings wrote: Non-text part: multipart/signed > On Mon, 2011-10-31 at 12:29 +1030, Rusty Russell wrote: > > On Fri, 28 Oct 2011 04:38:14 +0100, Ben Hutchings > > wrote: > > > Dynamic debugging was enabled for GPL-compat

Re: [PATCH 2/2] module: Re-enable dynamic debugging for GPL-compatible OOT modules

2011-10-31 Thread Rusty Russell
On Fri, 28 Oct 2011 04:38:14 +0100, Ben Hutchings wrote: > Dynamic debugging was enabled for GPL-compatible out-of-tree modules > until my addition of TAINT_OOT_MODULE. It should continue to be > enabled now. Please just remove the test entirely. AFAICT there's nothing unique to dynamic debug w

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-31 Thread Rusty Russell
On Wed, 26 Oct 2011 21:55:28 -0400, Dave Jones wrote: > On Thu, Oct 27, 2011 at 11:41:37AM +1030, Rusty Russell wrote: > > > I think we need a "taint_string()" function, and instead of lockdep > > disabling itself it should note the taint string in its reports. >

Re: [PATCH 1/2] lockdep,rtmutex,bug: Show taint flags on error

2011-10-31 Thread Rusty Russell
the taint flags in all > lockdep and rtmutex-debug error messages. > > Signed-off-by: Ben Hutchings Acked-by: Rusty Russell -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.deb

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-26 Thread Rusty Russell
On Wed, 26 Oct 2011 09:08:34 -0400, Nick Bowler wrote: > On 2011-10-25 22:54 +0200, Greg KH wrote: > > On Tue, Oct 25, 2011 at 04:17:24PM -0400, Dave Jones wrote: > > > On Tue, Oct 25, 2011 at 10:04:55PM +0200, Greg Kroah-Hartman wrote: > > > > On Tue, Oct 25, 2011 at 12:51:42PM -0400, Nick Bowl

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-25 Thread Rusty Russell
On Tue, 25 Oct 2011 16:17:24 -0400, Dave Jones wrote: > commit 7816c45bf13255157c00fb8aca86cb64d825e878 > Author: Roland Vossen > Date: Thu Apr 7 11:20:58 2011 +0200 > > modules: Enabled dynamic debugging for staging modules ... > > Signed-off-by: Roland Vossen > Acked-by: Ja

Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

2011-10-24 Thread Rusty Russell
te: Mon, 24 Oct 2011 15:12:28 +0200 Use of the GPL or a compatible licence doesn't necessarily make the code any good. We already consider staging modules to be suspect, and this should also be true for out-of-tree modules which may receive very little review. Signed-off-by: Ben Hutchings R

Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd

2005-11-05 Thread Rusty Russell
On Sat, 2005-11-05 at 19:48 +0100, Pozsar Balazs wrote: > On Sat, Nov 05, 2005 at 06:31:04PM +0100, Kay Sievers wrote: > > I've got these messages several times on the experimental SUSE too, > > but can't reproduce it so far, even without Rusty's patch to modprobe > > they have disappeared. See her

Bug#333052: Bug#333522: possible problem cause: wait4(-1)

2005-10-31 Thread Rusty Russell
On Mon, 2005-10-31 at 19:53 +0100, Marco d'Itri wrote: > On Oct 29, Rusty Russell <[EMAIL PROTECTED]> wrote: > > > Please send complete log. > Here it is. I can reproduce the bug even with a script like: > > while read m; do > /sbin/modprobe.real $m &

Bug#333052: Bug#333522: possible problem cause: wait4(-1)

2005-10-28 Thread Rusty Russell
On Fri, 2005-10-28 at 15:08 +0200, Marco d'Itri wrote: > On Oct 28, Rusty Russell <[EMAIL PROTECTED]> wrote: > > > The latter is the simplest option. Please try this patch (it will be in > > the next release, too). If it seems to work, please ack. > No luck. Pl

Bug#333052: Bug#333522: possible problem cause: wait4(-1)

2005-10-28 Thread Rusty Russell
On Thu, 2005-10-27 at 10:10 +0200, Marco d'Itri wrote: > And then it fails for ehci-hcd too (which is not loaded at all). > Rusty, do you have other ideas for debugging? I have reread the bug reports, and meditated on this issue some more. This is a possibility I was aware of when I changed to cod

Bug#333522: possible problem cause: wait4(-1)

2005-10-18 Thread Rusty Russell
On Tue, 2005-10-18 at 15:38 +0200, Martin Wilck wrote: > Rusty Russell wrote: > > > Martin Wilck <[EMAIL PROTECTED]> wrote: > > > >>0. the module loading tool runs during boot with PID 1. > > > > I do not understand how this can hap

Bug#333522: possible problem cause: wait4(-1)

2005-10-17 Thread Rusty Russell
On Thu, 2005-10-13 at 23:07 +0200, Marco d'Itri wrote: > Any comments? Martin Wilck <[EMAIL PROTECTED]> wrote: > 0. the module loading tool runs during boot with PID 1. I do not understand how this can happen. request_module() cannot occur until usermodehelper_init() is called. This is only don

Bug#333052: insmod race?

2005-10-11 Thread Rusty Russell
On Sun, 2005-10-09 at 16:26 +0200, Kay Sievers wrote: > On Sun, Oct 09, 2005 at 10:56:15AM +0200, Marco d'Itri wrote: > > What do you think about this? It happens when udevd tries to load a > > dozen of modules at boot time. Is there a race in modules loading? > > It happens less frequently with ot

Bug#273191: no longer seems to support kernel command line variable values with spaces in their name

2004-09-28 Thread Rusty Russell
ind someone actually uses that odd "turn option into env var" stuff. Name: Restore quotes around environment variables Status: Tested on 2.6.9-rc2-bk13 Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> As noticed by Joey Hess (and thanks for Christoph for forwarding it): if we deci