Re: Bug#895619: plexus-compiler: use --release instead of -source/-target for jdk9+ when setting defaults

2018-07-02 Thread Emmanuel Bourg
Le 13/04/2018 à 17:14, Tiago Stürmer Daitx a écrit : > plexus-compiler currently will default -source and/or -target to 1.7 > whenever the following occours: > 1) whenever either has not being set > 2) whenever either has been set to 1.6 or earlier > > This patch modifies the detection logic in o

Re: Bug#895619: plexus-compiler: use --release instead of -source/-target for jdk9+ when setting defaults

2018-07-02 Thread Thorsten Glaser
On Mon, 2 Jul 2018, Emmanuel Bourg wrote: > revert the use of the --release option in Ant/Maven. That would mean the > packages built with OpenJDK 10/11 are unlikely to run with OpenJDK 8 > (the binary incompatibility in the ByteBuffer class affects quite a lot > of code). Ouch, that would hurt.

Re: Bug#895619: plexus-compiler: use --release instead of -source/-target for jdk9+ when setting defaults

2018-07-02 Thread Emmanuel Bourg
Le 02/07/2018 à 17:32, Thorsten Glaser a écrit : > Patch code that uses those internal APIs. This is what we do here™ > as well, ever since we could require Java 8 at the customers’ sites. > It’s been easy so far as most of the time it was just base64. Base64 is easy, but sun.misc.Unsafe is anoth

Re: Bug#895619: plexus-compiler: use --release instead of -source/-target for jdk9+ when setting defaults

2018-07-02 Thread Thorsten Glaser
On Mon, 2 Jul 2018, Emmanuel Bourg wrote: > Base64 is easy, but sun.misc.Unsafe is another story. It's widely used OIC. I haven’t run into that one yet. How do I reproduce this with Java 8, anyway? tglase@tglase:~ $ javac --release 1.8 javac: invalid flag: --release Usage: javac use -help for

Re: Bug#895619: plexus-compiler: use --release instead of -source/-target for jdk9+ when setting defaults

2018-07-02 Thread Emmanuel Bourg
Le 02/07/2018 à 17:52, Thorsten Glaser a écrit : > How do I reproduce this with Java 8, anyway? You can't, the --release option appeared in Java 9.

Re: Bug#895619: plexus-compiler: use --release instead of -source/-target for jdk9+ when setting defaults

2018-07-02 Thread Thorsten Glaser
On Mon, 2 Jul 2018, Emmanuel Bourg wrote: > Someone has a better idea? OK, since the last one was impracticable: Revert default-jdk to 8 until these all are fixed. (Since the internal APIs are, well, internal, they all ought to be fixed by their respective upstreams *anyway* AIUI.) Or, perhaps

Re: Bug#895619: plexus-compiler: use --release instead of -source/-target for jdk9+ when setting defaults

2018-07-02 Thread Sebastiaan Couwenberg
On 07/02/2018 05:26 PM, Emmanuel Bourg wrote: > Le 13/04/2018 à 17:14, Tiago Stürmer Daitx a écrit : > >> plexus-compiler currently will default -source and/or -target to 1.7 >> whenever the following occours: >> 1) whenever either has not being set >> 2) whenever either has been set to 1.6 or ear

Re: Bug#895619: plexus-compiler: use --release instead of -source/-target for jdk9+ when setting defaults

2018-07-02 Thread Vincent Privat
Hello, I would be in favor to drop the JOSM feature that uses the sun security packages but not all the team agrees with that see https://josm.openstreetmap.de/ticket/10033#comment:50 We'll check on our side what we can do. Cheers, Vincent Le lun. 2 juil. 2018 à 18:22, Sebastiaan Couwenberg a écr