Re: munin-java-plugins package - request for review

2009-11-27 Thread Tom Feiner
Hi Benjamin, > On Fri, Nov 27, 2009 at 12:09 AM, Benjamin Drung wrote: >> Am Donnerstag, den 26.11.2009, 23:58 +0200 schrieb Tom Feiner: >> I would recommend to change the order to "java6-runtime-headless | >> java5-runtime-headless", so that the default will be >> java6-runtime-headless. >> Rig

Re: munin-java-plugins package - request for review

2009-11-27 Thread Tom Feiner
> On Fri, Nov 27, 2009 at 12:07 AM, Niels Thykier wrote: >> >> I did not mean to suggest that you should remove your current java >> alternatives (default-jre-headless | java2-runtime-headless)[1]; only >> that you extended it to include java5 and java6 as well. Particularly >> all of the javaX-r

Re: munin-java-plugins package - request for review

2009-11-26 Thread Benjamin Drung
Am Donnerstag, den 26.11.2009, 23:58 +0200 schrieb Tom Feiner: > Hi Niels, > > Thank you very much for the review! > > You were right on all of the assumptions in your reply :) > > I've committed the following change based on your review. Which incorporates > all of your suggetions [1]. I would

Re: munin-java-plugins package - request for review

2009-11-26 Thread Niels Thykier
Hi Tom I did not mean to suggest that you should remove your current java alternatives (default-jre-headless | java2-runtime-headless)[1]; only that you extended it to include java5 and java6 as well. Particularly all of the javaX-runtime-headless packages are virtual, so you should keep default-j

Re: munin-java-plugins package - request for review

2009-11-26 Thread Tom Feiner
Hi Niels, Thank you very much for the review! You were right on all of the assumptions in your reply :) I've committed the following change based on your review. Which incorporates all of your suggetions [1]. Thanks a lot :) Tom Feiner [1] http://munin.projects.linpro.no/changeset/3114

Re: munin-java-plugins package - request for review

2009-11-26 Thread Niels Thykier
Tom Feiner wrote: > Hi, > > I hope I'm asking this is the right place. > Hi Yupe, this is the right place. BTW, I assumed that you were reachable via the Munin Maintainer List, since you did not ask to be explicitly CCed. > I'm working with the debian munin maintainers [1] to package the > upc

munin-java-plugins package - request for review

2009-11-25 Thread Tom Feiner
Hi, I hope I'm asking this is the right place. I'm working with the debian munin maintainers [1] to package the upcoming version of munin. Munin is a network monitoring system, which is extended by plugins to monitor different aspects of the OS and running applications. Recently, the upstream pr