Re: Review: imageviewer-image-viewer

2020-05-31 Thread Samyak Jain
Hi, Thank you for reviewing the package. On Sun, May 31, 2020 at 2:07 PM Emmanuel Bourg wrote: > Hi Samyak, > > I got a quick look and technically it's good. I'd suggest some cosmetic > changes: > - the empty debian/maven.cleanIgnoreRules and > debian/maven.publishedRules files can be removed >

Re: Review: imageviewer-image-viewer

2020-05-31 Thread Emmanuel Bourg
Hi Samyak, I got a quick look and technically it's good. I'd suggest some cosmetic changes: - the empty debian/maven.cleanIgnoreRules and debian/maven.publishedRules files can be removed - don't bother packaging the javadoc, it's just a waste of resources - the libjs-jquery dependency can be remov

Review: imageviewer-image-viewer

2020-05-29 Thread Samyak Jain
Hi, I have packaged libimageviewer-image-viewer-java which is acting as a dependency for a Gradle based Package. Since it is my first attempt to package a maven based java package. It will be great if someone can review it. The package builds fines. The package exists here[1]. Since I'm a Debian