Re: [PATCH 4/7] xfuncs: Handle missing non-POSIX termios constants

2017-10-07 Thread Kang-Che Sung
On Sun, Oct 8, 2017 at 1:53 AM, James Clarke wrote: > diff --git a/libbb/xfuncs.c b/libbb/xfuncs.c > index 9cbfb2836..95dac656a 100644 > --- a/libbb/xfuncs.c > +++ b/libbb/xfuncs.c > @@ -22,6 +22,16 @@ > */ > #include "libbb.h" > > +#ifndef IMAXBEL > +# define IMAXBEL 0 > +#endif > +#ifndef IUC

Re: [PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

2017-10-07 Thread Kang-Che Sung
On Sun, Oct 8, 2017 at 1:53 AM, James Clarke wrote: > Signed-off-by: James Clarke > --- > include/libbb.h | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/include/libbb.h b/include/libbb.h > index daccf154a..56f4f4cb3 100644 > --- a/include/libbb.h > +

Re: [PATCH 4/7] xfuncs: Handle missing non-POSIX termios constants

2017-10-08 Thread Kang-Che Sung
2017年10月8日 18:50，"James Clarke" 寫道： On 8 Oct 2017, at 02:34, Kang-Che Sung wrote: > On Sun, Oct 8, 2017 at 1:53 AM, James Clarke wrote: >> diff --git a/libbb/xfuncs.c b/libbb/xfuncs.c >> index 9cbfb2836..95dac656a 100644 >> --- a/libbb/xfuncs.c >> ++

Re: [PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

2017-10-08 Thread Kang-Che Sung
2017年10月8日 18:59，"James Clarke" 寫道： That's not actually true (any more); util-linux/fdisk_osf.c, whilst Linux-specific, does use MAXPATHLEN, and networking/traceroute.c uses MAXHOSTNAMELEN. These could be changed to use {PATH,HOST_NAME}_MAX, but it's highly likely that a future change will re-int