Re: kdiff3: FTBFS on hurd-i386 (for review)

2014-09-25 Thread Svante Signell
On Wed, 2014-09-24 at 19:11 +0200, Philipp A. Hartmann wrote: > Hi, > > On 24/09/14 18:11, Lancelot SIX wrote: Thank you both for your comments, and for teaching me C++ (I've never been fluent with it, learning new stuff every day). New patch attached. OK to submit? Index: kdiff3-0.9.98/src-QT4

Re: kdiff3: FTBFS on hurd-i386 (for review)

2014-09-25 Thread Pino Toscano
On 2014-09-24 19:11, Philipp A. Hartmann wrote: I would probably do it like this (untested): const char *path = QFile::encodeName(fi.absoluteFilePath()).constData(); QFile::encodeName returns a temporary QByteArray, and getting a pointer to its internal char* will cause it to be a

Re: kdiff3: FTBFS on hurd-i386 (for review)

2014-09-25 Thread Svante Signell
Hi Pino On Thu, 2014-09-25 at 10:08 +0200, Pino Toscano wrote: > On 2014-09-24 19:11, Philipp A. Hartmann wrote: > > I would probably do it like this (untested): > > > > const char *path = > > QFile::encodeName(fi.absoluteFilePath()).constData(); > > QFile::encodeName returns a tempor

Re: kdiff3: FTBFS on hurd-i386 (for review)

2014-09-25 Thread Pino Toscano
On 2014-09-25 14:05, Svante Signell wrote: Hi Pino On Thu, 2014-09-25 at 10:08 +0200, Pino Toscano wrote: On 2014-09-24 19:11, Philipp A. Hartmann wrote: > I would probably do it like this (untested): > > const char *path = > QFile::encodeName(fi.absoluteFilePath()).constData(); QF