Re: pong2 - PATH_MAX patch for review

2012-06-25 Thread Samuel Thibault
Barry deFreese, le Mon 25 Jun 2012 09:39:43 -0400, a écrit : > On 6/25/2012 8:39 AM, Samuel Thibault wrote: > > Barry deFreese, le Tue 19 Jun 2012 23:20:04 -0400, a écrit : > >> +#ifdef __linux__ > >> #include > >> +#endif > > > > Better check that it simply works on Linux with instead of > >

Re: pong2 - PATH_MAX patch for review

2012-06-25 Thread Barry deFreese
On 6/25/2012 8:39 AM, Samuel Thibault wrote: > Barry deFreese, le Tue 19 Jun 2012 23:20:04 -0400, a écrit : >> +#ifdef __linux__ >> #include >> +#endif > > Better check that it simply works on Linux with instead of > > > Samuel > Samuel, Do you mean something like: #ifdef _LIBC_LIMITS_H_

Re: pong2 - PATH_MAX patch for review

2012-06-25 Thread Samuel Thibault
Barry deFreese, le Tue 19 Jun 2012 23:20:04 -0400, a écrit : > +#ifdef __linux__ > #include > +#endif Better check that it simply works on Linux with instead of Samuel -- To UNSUBSCRIBE, email to debian-hurd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas

Re: pong2 - PATH_MAX patch for review

2012-06-20 Thread Cyril Roelandt
On 06/20/2012 02:37 PM, Barry deFreese wrote: Thanks but what are you doing there if you overrun the size of filename (not that they are handling it now either but PATH_MAX is fairly large). Well, it seems like this function does not return anything, so you can't use an error code. You coul

Re: pong2 - PATH_MAX patch for review

2012-06-20 Thread Barry deFreese
On 6/20/2012 8:13 AM, Cyril Roelandt wrote: > On 06/20/2012 05:20 AM, Barry deFreese wrote: >> Hi again, >> >> Here is a simple little patch to build pong2 (uses PATH_MAX). >> >> Let me know if this looks sane. >> > > > Why not do this : > > size = strlen(...) + 1; > filename = malloc(size); > #

Re: pong2 - PATH_MAX patch for review

2012-06-20 Thread Cyril Roelandt
On 06/20/2012 05:20 AM, Barry deFreese wrote: Hi again, Here is a simple little patch to build pong2 (uses PATH_MAX). Let me know if this looks sane. Why not do this : size = strlen(...) + 1; filename = malloc(size); #ifdef PATH_MAX if (size > PATH_MAX) handle_error(); #endif snprintf(

pong2 - PATH_MAX patch for review

2012-06-19 Thread Barry deFreese
Hi again, Here is a simple little patch to build pong2 (uses PATH_MAX). Let me know if this looks sane. Thanks! Barry deFreese --- pong2-0.1.3.orig/src/grapple/socket.h +++ pong2-0.1.3/src/grapple/socket.h @@ -27,7 +27,9 @@ #include #include +#ifdef __linux__ #include +#endif #ifnde