Re: libpst: FTBFS on hurd-i386 (for review)

2012-08-26 Thread Samuel Thibault
Svante Signell, le Sun 26 Aug 2012 15:31:04 +0200, a écrit : > On Sun, 2012-08-26 at 15:18 +0200, Samuel Thibault wrote: > > Svante Signell, le Sun 26 Aug 2012 15:08:35 +0200, a écrit : > > > > > -snprintf(pdf_name, sizeof(pdf_name), "dii%06d", > > > > > ++email_sequence); > > > > > +/* No

Re: libpst: FTBFS on hurd-i386 (for review)

2012-08-26 Thread Svante Signell
On Sun, 2012-08-26 at 15:18 +0200, Samuel Thibault wrote: > Svante Signell, le Sun 26 Aug 2012 15:08:35 +0200, a écrit : > > > > -snprintf(pdf_name, sizeof(pdf_name), "dii%06d", ++email_sequence); > > > > +/* Note; allocating the largest string length to pdf_name */ > > > > +int len = s

Re: libpst: FTBFS on hurd-i386 (for review)

2012-08-26 Thread Samuel Thibault
Svante Signell, le Sun 26 Aug 2012 15:08:35 +0200, a écrit : > > > -snprintf(pdf_name, sizeof(pdf_name), "dii%06d", ++email_sequence); > > > +/* Note; allocating the largest string length to pdf_name */ > > > +int len = strlen(output_directory) + 4 + 6 + 4; > > > > why 4 before 6 ? >

Re: libpst: FTBFS on hurd-i386 (for review)

2012-08-26 Thread Svante Signell
On Sun, 2012-08-26 at 14:28 +0200, Samuel Thibault wrote: > Svante Signell, le Sat 25 Aug 2012 19:19:02 +0200, a écrit : > > if (png_open) { > > png_open = false; > > -char fn[PATH_MAX]; > > -snprintf(fn, sizeof(fn), "page%d.png", ++page_sequence); > > +int len

Re: libpst: FTBFS on hurd-i386 (for review)

2012-08-26 Thread Samuel Thibault
Svante Signell, le Sat 25 Aug 2012 19:19:02 +0200, a écrit : > if (png_open) { > png_open = false; > -char fn[PATH_MAX]; > -snprintf(fn, sizeof(fn), "page%d.png", ++page_sequence); > +int len = 4 + 11 + 4; > +char *fn = (char*)pst_malloc(len + 1); > +

Re: libpst: FTBFS on hurd-i386 (for review)

2012-08-25 Thread Svante Signell
On Sun, 2012-07-29 at 05:23 +0200, Guillem Jover wrote: > Hi! > > On Wed, 2012-06-27 at 20:43:15 +0200, Svante Signell wrote: > > Source: libpst > > Version: 0.6.54-3 Version: 0.6.53-4 > > Severity: important > > Tags: patch > > User: debian-hurd@lists.debian.org > > Usertags: hurd > > > Hi, li

Re: libpst: FTBFS on hurd-i386 (for review)

2012-07-28 Thread Guillem Jover
Hi! On Wed, 2012-06-27 at 20:43:15 +0200, Svante Signell wrote: > Source: libpst > Version: 0.6.54-3 > Severity: important > Tags: patch > User: debian-hurd@lists.debian.org > Usertags: hurd > Hi, libpst does not build for GNU/Hurd due to PATH_MAX issues. Attached > are three small patches to ena

Re: libpst: FTBFS on hurd-i386 (for review)

2012-07-05 Thread Svante Signell
ping! On Wed, 2012-06-27 at 20:43 +0200, Svante Signell wrote: > Source: libpst > Version: 0.6.54-3 > Severity: important > Tags: patch > User: debian-hurd@lists.debian.org > Usertags: hurd > > Hi, libpst does not build for GNU/Hurd due to PATH_MAX issues. Attached > are three small patches to en

Re: libpst: FTBFS on hurd-i386 (for review)

2012-06-27 Thread Svante Signell
Source: libpst Version: 0.6.54-3 Severity: important Tags: patch User: debian-hurd@lists.debian.org Usertags: hurd Hi, libpst does not build for GNU/Hurd due to PATH_MAX issues. Attached are three small patches to enable a successful build. libpst.c.patch checks for the availability of get_current