Re: gearmand - PATH_MAX patch review

2012-06-18 Thread Philipp A. Hartmann
Pino, On 18/06/12 13:04, Pino Toscano wrote: > > Alle lunedì 18 giugno 2012, Philipp A. Hartmann ha scritto: > >> Alternative sketched below, untested of course. >> >> On 18/06/12 09:50, Samuel Thibault wrote: >>> Barry deFreese, le Mon 18 Jun 2012 00:20:17 -0400, a écrit : +#ifdef _GNU_SOU

Re: gearmand - PATH_MAX patch review

2012-06-18 Thread Pino Toscano
Hi, Alle lunedì 18 giugno 2012, Philipp A. Hartmann ha scritto: > it's C++, therefore we should probably use appropriate C++ features > instead of platform-specific things like strdupa(). Right. > Alternative sketched below, untested of course. > > On 18/06/12 09:50, Samuel Thibault wrote: > >

Re: gearmand - PATH_MAX patch review

2012-06-18 Thread Philipp A. Hartmann
Samuel, Barry, it's C++, therefore we should probably use appropriate C++ features instead of platform-specific things like strdupa(). Alternative sketched below, untested of course. On 18/06/12 09:50, Samuel Thibault wrote: > Barry deFreese, le Mon 18 Jun 2012 00:20:17 -0400, a écrit : >> +#ifd

Re: gearmand - PATH_MAX patch review

2012-06-18 Thread Samuel Thibault
Barry deFreese, le Mon 18 Jun 2012 00:20:17 -0400, a écrit : > +#ifdef _GNU_SOURCE _GNU_SOURCE is not something you can test. It's the application which is supposed to define it. Test __GLIBC__ instead > +char *getcwd_buf= get_current_dir_name(); > +#else > char buf[PATH_MAX]; >

gearmand - PATH_MAX patch review

2012-06-17 Thread Barry deFreese
Howdy, Attached is a patch for gearmand to fix an FTBFS on PATH_MAX. Could you please take a look and if it looks sane I will submit to Debian. Thanks! Barry Index: gearmand-0.32/libtest/server.cc === --- gearmand-0.32.orig/libte