Re: Check for getcwd(NULL, 0) Was: Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-17 Thread Svante Signell
> On Wed, 2012-10-17 at 16:15 +0200, Guillem Jover wrote: > AC_DEFINE([HAVE_GNU_GETCWD], [1], > [Define to 1 if you have support for 'getcwd(NULL, 0)' GNU > extension]) BTW, why calling it a GNU extension, not GLIBC or LIBC. >From the man page: As an extension to the POSIX

Re: Check for getcwd(NULL, 0) Was: Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-17 Thread Svante Signell
On Wed, 2012-10-17 at 16:15 +0200, Guillem Jover wrote: > On Wed, 2012-10-17 at 14:15:47 +0200, Svante Signell wrote: > > On Wed, 2012-10-17 at 11:51 +0200, Pino Toscano wrote: > > > > > If you assume getcwd is available, this check is pointless; if you > > > don't, then you need to skip the check

Re: Check for getcwd(NULL, 0) Was: Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-17 Thread Guillem Jover
On Wed, 2012-10-17 at 14:15:47 +0200, Svante Signell wrote: > On Wed, 2012-10-17 at 11:51 +0200, Pino Toscano wrote: > > > If you assume getcwd is available, this check is pointless; if you > > don't, then you need to skip the check below is getcwd has not been > > found. > > New version: (has to

Re: Check for getcwd(NULL, 0) Was: Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-17 Thread Svante Signell
On Wed, 2012-10-17 at 11:51 +0200, Pino Toscano wrote: > If you assume getcwd is available, this check is pointless; if you > don't, then you need to skip the check below is getcwd has not been > found. New version: (has to be indented?) AC_CHECK_FUNC([getcwd], AC_DEFINE([HAVE_GETCWD],[1],[Defin

Re: Check for getcwd(NULL, 0) Was: Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-17 Thread Pino Toscano
Hi, Alle mercoledì 17 ottobre 2012, Svante Signell ha scritto: > AC_CHECK_FUNCS([getcwd]) If you assume getcwd is available, this check is pointless; if you don't, then you need to skip the check below is getcwd has not been found. > AC_MSG_RESULT([checking for getcwd(NULL, 0)... yes]) Usuall

Re: Check for getcwd(NULL, 0) Was: Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-17 Thread Samuel Thibault
Svante Signell, le Wed 17 Oct 2012 11:26:58 +0200, a écrit : > AC_MSG_RESULT([checking for getcwd(NULL, 0)... yes]) > AC_DEFINE([HAVE_GETCWD_GLIBC], 1, [Define to 1 if you have support for > `getcwd(NULL,0)`]) > ],[ > AC_MSG_RESULT([checking for getcwd(NULL, 0)... no]) > ],[ > AC_MSG_CHECKI

Re: Check for getcwd(NULL, 0) Was: Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-17 Thread Svante Signell
On Wed, 2012-10-17 at 11:07 +0200, Samuel Thibault wrote: > Svante Signell, le Wed 17 Oct 2012 11:00:38 +0200, a écrit : > > On Wed, 2012-10-17 at 09:27 +0200, Svante Signell wrote: > > For symmetry reasons the text below > > > AC_MSG_WARN([getcwd(NULL,0)... cannot run test program while cross >

Re: Check for getcwd(NULL, 0) Was: Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-17 Thread Samuel Thibault
Svante Signell, le Wed 17 Oct 2012 11:00:38 +0200, a écrit : > On Wed, 2012-10-17 at 09:27 +0200, Svante Signell wrote: > For symmetry reasons the text below > > AC_MSG_WARN([getcwd(NULL,0)... cannot run test program while cross > > compiling]) > should be changed to > AC_MSG_WARN([checking for

Re: Check for getcwd(NULL, 0) Was: Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-17 Thread Svante Signell
On Wed, 2012-10-17 at 09:27 +0200, Svante Signell wrote: For symmetry reasons the text below > AC_MSG_WARN([getcwd(NULL,0)... cannot run test program while cross > compiling]) should be changed to AC_MSG_WARN([checking for getcwd(NULL,0)... cannot run test program while cross compiling]) > If

Check for getcwd(NULL, 0) Was: Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-17 Thread Svante Signell
On Tue, 2012-10-16 at 21:30 +0200, Samuel Thibault wrote: > Svante Signell, le Tue 16 Oct 2012 13:29:58 +0200, a écrit : > No need to define HAVE_GETCWD_GLIBC to 0, people usually only define it > to 1 when the feature is available, thus allowing to just use #ifdef > HAVE_GETCWD_GLIBC. > > > ]) >

Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-16 Thread Samuel Thibault
Svante Signell, le Tue 16 Oct 2012 13:29:58 +0200, a écrit : > AC_RUN_IFELSE([ > AC_LANG_PROGRAM([ > #ifdef HAVE_GETCWD > #include > #endif > ],[ > char *result = getcwd(NULL,0); > if (result == NULL) > return 1; > ])] > ,[ > AC_MSG_RESULT([checking for getcwd(NULL, 0)... yes]) > AC_DEFINE([

Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-16 Thread Svante Signell
On Mon, 2012-10-15 at 00:00 +0200, Samuel Thibault wrote: > Svante Signell, le Thu 11 Oct 2012 17:46:33 +0200, a écrit : > > The functions realpath and getcwd are already checked for in > > configure.ac/configure > > But not whether they support being passed NULL, which is what Guillem > was refe

Re: Bug#636568: xerces-c: Updated patch, submitted upstream

2012-10-14 Thread Samuel Thibault
Svante Signell, le Thu 11 Oct 2012 17:46:33 +0200, a écrit : > The functions realpath and getcwd are already checked for in > configure.ac/configure But not whether they support being passed NULL, which is what Guillem was referring to in "And getcwd(NULL, 0) has also been supported on FreeBSD an