Re: Problems with Hurd's unlink in visudo

2012-01-14 Thread Steven McDonald
Hi, Thanks for the responses. On Sat, 14 Jan 2012 20:28:40 +0100 Pino Toscano wrote: > I did a bit of debug, and it seems sudo needs a fix, but a different > one. > Basically, when parsing the specified sudoers file (or the default one), > the "sudoerslist" list is populated with the file bei

Re: Problems with Hurd's unlink in visudo

2012-01-14 Thread Samuel Thibault
Pino Toscano, le Sat 14 Jan 2012 20:28:40 +0100, a écrit : > > Is this something that should be fixed in Hurd (or perhaps eglibc), > > I think we could also fix unlink() on the Hurd bits of glibc to give > EINVAL on NULL parameter, or that would be considered (too) broken code > anyway? As Thom

Re: Problems with Hurd's unlink in visudo

2012-01-14 Thread Pino Toscano
Hi, Alle sabato 14 gennaio 2012, Steven McDonald ha scritto: > I've been looking at the problems with visudo as tracked on > alioth[1]. I've applied Justus's fix to use flock instead of lockf, > and created a patch that solves the segfault issue (see attached). > visudo now seems to work correctly

Re: Problems with Hurd's unlink in visudo

2012-01-14 Thread Thomas Bushnell, BSG
C != Java Which is to say, a null pointer is not a valid argument to unlink, and the Hurd's use of a signal instead of an error is allowed by Posix. Thomas On Jan 14, 2012 8:48 AM, "Steven McDonald" wrote: > Hi, > > I've been looking at the problems with visudo as tracked on alioth[1]. > I've a

Problems with Hurd's unlink in visudo

2012-01-14 Thread Steven McDonald
Hi, I've been looking at the problems with visudo as tracked on alioth[1]. I've applied Justus's fix to use flock instead of lockf, and created a patch that solves the segfault issue (see attached). visudo now seems to work correctly on Hurd. However, I'm uncertain whether the segfault should act