Patches and Upstream (was: Patch to fix FTBFS of pvm on GNU/Hurd)

2011-05-17 Thread olafBuddenhagen
Hi, On Wed, May 11, 2011 at 08:43:58AM +0200, Svante Signell wrote: > One problem so far is how to write the patches to please the DMs. The > comments you get varies. Sometimes it is easier to communicate with > upstream. Indeed, if an active upstream exists, and the best approach to take is not

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-05-11 Thread Samuel Thibault
Svante Signell, le Wed 11 May 2011 08:43:58 +0200, a écrit : > However, I don't know if there exists an active upstream for this > package. Most probably not. PVM is pretty much dead as a communication protocol: the EuroPVM/MPI conference (at last!) got renamed to EuroMPI for instance. > Yes, I k

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-05-10 Thread Svante Signell
On Mon, 2011-05-09 at 11:50 +0200, olafbuddenha...@gmx.net wrote: > Hi, > > On Mon, May 09, 2011 at 08:30:23AM +0200, Svante Signell wrote: .. > > I mean that changing strcpy to strdup everywhere is a major rewrite of > > this old code. > > Who talked about changing it *everywhere*?! Your patch

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-05-10 Thread olafBuddenhagen
Hi, On Mon, May 09, 2011 at 08:30:23AM +0200, Svante Signell wrote: > On Sun, 2011-05-08 at 18:56 +0200, olafbuddenha...@gmx.net wrote: > > On Fri, Apr 15, 2011 at 03:55:49PM +0200, Svante Signell wrote: > > > On Fri, 2011-04-15 at 01:08 +0200, Emilio Pozuelo Monfort wrote: > > > > On 15/04/11 00:

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-05-08 Thread Svante Signell
On Sun, 2011-05-08 at 18:56 +0200, olafbuddenha...@gmx.net wrote: > Hi, > > On Fri, Apr 15, 2011 at 03:55:49PM +0200, Svante Signell wrote: > > On Fri, 2011-04-15 at 01:08 +0200, Emilio Pozuelo Monfort wrote: > > > On 15/04/11 00:10, Samuel Thibault wrote: > > > > Svante Signell, le Thu 14 Apr 201

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-05-08 Thread olafBuddenhagen
Hi, On Fri, Apr 15, 2011 at 03:55:49PM +0200, Svante Signell wrote: > On Fri, 2011-04-15 at 01:08 +0200, Emilio Pozuelo Monfort wrote: > > On 15/04/11 00:10, Samuel Thibault wrote: > > > Svante Signell, le Thu 14 Apr 2011 23:18:32 +0200, a écrit : > > And I wouldn't do #ifdef #else #endif, since

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Samuel Thibault
Svante Signell, le Fri 15 Apr 2011 21:21:19 +0200, a écrit : > OK, to submit after these changes, or is another review needed? If the changes are correct, yes :) Samuel -- To UNSUBSCRIBE, email to debian-hurd-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Svante Signell
On Fri, 2011-04-15 at 20:08 +0200, Samuel Thibault wrote: > Svante Signell, le Fri 15 Apr 2011 15:55:49 +0200, a écrit : > > Updated, see patch. What kind of leak is this? path is overwritten by a > > new malloced array. > > And so the old pointer is lost and will never be freed. OK. > > Are the

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Samuel Thibault
Svante Signell, le Fri 15 Apr 2011 15:55:49 +0200, a écrit : > Updated, see patch. What kind of leak is this? path is overwritten by a > new malloced array. And so the old pointer is lost and will never be freed. > Are the potential problems coming from that malloc does not clear the > memory all

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Svante Signell
On Fri, 2011-04-15 at 01:08 +0200, Emilio Pozuelo Monfort wrote: > On 15/04/11 00:10, Samuel Thibault wrote: > > Svante Signell, le Thu 14 Apr 2011 23:18:32 +0200, a écrit : > >> BTW: How to find out which packages build-depends (not depends) on > >> pvm-dev? > > > > See the graphs on my webpage >

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Svante Signell
On Fri, 2011-04-15 at 11:31 +0200, Emilio Pozuelo Monfort wrote: > > Thanks, very useful! Is there a command showing complete list of > > build-deps too? (not only showing the remaining deps, like apt-get > > build-dep package does) > > Not sure I understand. Can you rephrase of say an example?

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Emilio Pozuelo Monfort
On 15/04/11 10:45, Svante Signell wrote: > On Fri, 2011-04-15 at 10:29 +0200, Emilio Pozuelo Monfort wrote: >> On 14/04/11 23:18, Svante Signell wrote: >>> BTW: How to find out which packages build-depends (not depends) on >>> pvm-dev? I lost which package now, but was interested since I've patched

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Samuel Thibault
Svante Signell, le Fri 15 Apr 2011 10:59:39 +0200, a écrit : > On Fri, 2011-04-15 at 10:09 +0200, Samuel Thibault wrote: > > > > If you mean graph-uninstallable.fig in my opinion it is far too large to > > > be readable. > > > > Just zoom/unzoom. And to make it less large and more readable, port

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Svante Signell
On Fri, 2011-04-15 at 10:09 +0200, Samuel Thibault wrote: > > If you mean graph-uninstallable.fig in my opinion it is far too large to > > be readable. > > Just zoom/unzoom. And to make it less large and more readable, port > packages! I'm working with that! More hands would be useful. > > Addi

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Svante Signell
On Fri, 2011-04-15 at 10:29 +0200, Emilio Pozuelo Monfort wrote: > On 14/04/11 23:18, Svante Signell wrote: > > BTW: How to find out which packages build-depends (not depends) on > > pvm-dev? I lost which package now, but was interested since I've patched > > this package. Was it scilab or scalapac

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Emilio Pozuelo Monfort
On 14/04/11 23:18, Svante Signell wrote: > BTW: How to find out which packages build-depends (not depends) on > pvm-dev? I lost which package now, but was interested since I've patched > this package. Was it scilab or scalapack? build-rdeps pvm-dev Emilio -- To UNSUBSCRIBE, email to debian-hur

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-15 Thread Samuel Thibault
Svante Signell, le Fri 15 Apr 2011 08:35:24 +0200, a écrit : > On Fri, 2011-04-15 at 00:10 +0200, Samuel Thibault wrote: > > Svante Signell, le Thu 14 Apr 2011 23:18:32 +0200, a écrit : > > > BTW: How to find out which packages build-depends (not depends) on > > > pvm-dev? > > > > See the graphs o

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-14 Thread Svante Signell
On Fri, 2011-04-15 at 00:10 +0200, Samuel Thibault wrote: > Svante Signell, le Thu 14 Apr 2011 23:18:32 +0200, a écrit : > > BTW: How to find out which packages build-depends (not depends) on > > pvm-dev? > > See the graphs on my webpage > > http://people.debian.org/~sthibault/ > I thought ther

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-14 Thread Emilio Pozuelo Monfort
On 15/04/11 00:10, Samuel Thibault wrote: > Svante Signell, le Thu 14 Apr 2011 23:18:32 +0200, a écrit : >> BTW: How to find out which packages build-depends (not depends) on >> pvm-dev? > > See the graphs on my webpage > > http://people.debian.org/~sthibault/ > > >> diff -ur pvm-3.4.5/src/pvmd

Re: Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-14 Thread Samuel Thibault
Svante Signell, le Thu 14 Apr 2011 23:18:32 +0200, a écrit : > BTW: How to find out which packages build-depends (not depends) on > pvm-dev? See the graphs on my webpage http://people.debian.org/~sthibault/ > diff -ur pvm-3.4.5/src/pvmd.c pvm-3.4.5.new/src/pvmd.c > --- pvm-3.4.5/src/pvmd.c

Patch to fix FTBFS of pvm on GNU/Hurd

2011-04-14 Thread Svante Signell
Package: pvm Version: 3.4.5-12.2 Severity: important Tags: patch Usertags: hurd Attached is a patch to enable successful build of pvm on GNU/Hurd. It should be applied after the patch: 06-thread-safe-ctime.patch, preferably last. Note: Another, rather easy one to port, a PATH_MAX issue. This mail